- use err(3) instead of errx(3) if errno is available
to report why failed
- let fail prior to daemon(3) if opening a nbd file
is likely to fail after daemonizing to avoid silent
failure exit
Signed-off-by: Ryota Ozaki
---
qemu-nbd.c | 16 +++-
1 files changed, 11 insertions(
errx takes the exit status of a process as the first
argument. Passing errno to it is wrong. Instead the
patch lets errx take EXIT_FAILURE.
Signed-off-by: Ryota Ozaki
---
qemu-nbd.c | 34 +-
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/qemu-n
bdrv_open may return -errno so we have to check
if the return value is '< 0', not '== -1'.
Signed-off-by: Ryota Ozaki
---
qemu-nbd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index a393583..b89c361 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@
On Sat, Mar 20, 2010 at 2:26 PM, malc wrote:
> On Sat, 20 Mar 2010, Ryota Ozaki wrote:
>
>> - use err(3) instead of errx(3) if errno is available
>> to report why failed
>> - let fail prior to daemon(3) if opening a nbd file
>> is likely to fail after daemonizing to avoid silent
>> failure e
On Sat, 20 Mar 2010, Ryota Ozaki wrote:
> - use err(3) instead of errx(3) if errno is available
> to report why failed
> - let fail prior to daemon(3) if opening a nbd file
> is likely to fail after daemonizing to avoid silent
> failure exit
I'm under impression that you and the original au
- use err(3) instead of errx(3) if errno is available
to report why failed
- let fail prior to daemon(3) if opening a nbd file
is likely to fail after daemonizing to avoid silent
failure exit
---
qemu-nbd.c | 16 +++-
1 files changed, 11 insertions(+), 5 deletions(-)
diff --gi
bdrv_open may return -errno so we have to check
if the return value is '< 0', not '== -1'.
---
qemu-nbd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index a393583..b89c361 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -333,7 +333,7 @@ int main(i
Fix to Luiz comments.
Signed-off-by: Shahar Havivi
---
console.h |4 ++
input.c | 104 +++
monitor.c |8
qemu-monitor.hx | 17 +
qerror.c|8
qerror.h|6 +++
6 files change
Luiz Capitulino writes:
> On Wed, 17 Mar 2010 17:46:07 +0100
> Markus Armbruster wrote:
>
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> hw/qdev.c |7 ---
>> hw/qdev.h |2 +-
>> qemu-monitor.hx |3 ++-
>> 3 files changed, 7 insertions(+), 5 deletions(-)
>>
>> di
Luiz Capitulino writes:
> On Wed, 17 Mar 2010 18:56:50 +0100
> Markus Armbruster wrote:
>
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> qerror.c |2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/qerror.c b/qerror.c
>> index d0aba61..ff2fbd5 100644
>> --- a/
Luiz Capitulino writes:
> On Wed, 17 Mar 2010 18:56:49 +0100
> Markus Armbruster wrote:
>
>> Missed in commit 2f792016.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> hw/qdev-properties.c |1 +
>> monitor.c|2 --
>> sysemu.h |2 --
>> 3 files changed, 1 i
The current default stack limit of 512kB is far too small; a fair
number of gcc testsuite failures (for all guests) are directly
attributable to this. Using the -s option in every invocation of
the emulator is annoying to say the least.
A reasonable compromise seems to be to honor the system rlim
Luiz Capitulino writes:
> On Thu, 18 Mar 2010 17:33:11 +0100
> Markus Armbruster wrote:
>
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> qerror.c |4
>> qerror.h |3 +++
>> 2 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/qerror.c b/qerror.c
>> index 9fb817e
On Fri, Mar 19, 2010 at 05:22:05PM -0300, Luiz Capitulino wrote:
> Date: Fri, 19 Mar 2010 17:22:05 -0300
> From: Luiz Capitulino
> To: Shahar Havivi
> Cc: Dor Laor , qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set'
> and 'info keybaord'
>
Luiz Capitulino writes:
> On Thu, 18 Mar 2010 17:33:12 +0100
> Markus Armbruster wrote:
>
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> qemu-option.c | 17 ++---
>> 1 files changed, 6 insertions(+), 11 deletions(-)
>>
>> diff --git a/qemu-option.c b/qemu-option.c
>> index e3
Don't set PAGE_EXEC for XN pages, to avoid a bypass of XN protection
checking if the page is already in the TLB.
Signed-off-by: Rabin Vincent
---
target-arm/helper.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index
Luiz Capitulino writes:
> On Thu, 18 Mar 2010 17:33:07 +0100
> Markus Armbruster wrote:
>
> I'm getting the following build error:
>
> """
> qemu-option.o: In function `parse_option_bool':
> /home/lcapitulino/src/qmp-unstable/qemu-option.c:179: undefined reference to
> `qerror_report_internal'
On 3/19/10, Jamie Lokier wrote:
> Blue Swirl wrote:
> > But what if in addition to
> > this, the user process forked and the other process ptraced the QEMU
> > process,
>
>
> How good is the cross-arch ptrace() emulation, anyway? :-)
Probably as good as SIGABRT abuse support. But the case coul
Signed-off-by: Richard Henderson
---
tcg/arm/tcg-target.h|1 +
tcg/i386/tcg-target.h |1 +
tcg/mips/tcg-target.h |1 +
tcg/ppc/tcg-target.h|1 +
tcg/ppc64/tcg-target.h |2 ++
tcg/s390/tcg-target.h |2 ++
tcg/sparc/tcg-target.h |2 ++
tcg/tcg-op.h
Give the enumeration formed from tcg-opc.h a name: TCGOpcode.
Use that enumeration type instead of "int" whereever appropriate.
Signed-off-by: Richard Henderson
---
tcg/arm/tcg-target.c|2 +-
tcg/hppa/tcg-target.c |2 +-
tcg/i386/tcg-target.c |2 +-
tcg/mips/tcg-target.c |
Some targets (e.g. Alpha and MIPS64) need to keep 32-bit operands
sign-extended in 64-bit registers (regardless of the "real" sign
of the operand). For that, we need to be able to distinguish
between a 32-bit load with a 32-bit result and a 32-bit load with
a given extension to a 64-bit result. T
Signed-off-by: Richard Henderson
---
tcg/arm/tcg-target.h|1 +
tcg/i386/tcg-target.h |1 +
tcg/mips/tcg-target.h |1 +
tcg/ppc/tcg-target.h|1 +
tcg/ppc64/tcg-target.h |2 ++
tcg/s390/tcg-target.h |2 ++
tcg/sparc/tcg-target.h |2 ++
tcg/tcg-op.h
This opcode is unused. It was incorrectly implemented
on at least one host. Just remove it.
Signed-off-by: Richard Henderson
---
tcg/README |7 +--
tcg/arm/tcg-target.c|7 ---
tcg/hppa/tcg-target.c |5 -
tcg/i386/tcg-target.c |9 -
tcg/m
Three of the patches improve the debugging of TCG by using enumerations
where it makes sense. This avoids having to grovel through header files
to figure out what a given constant refers to.
Four of the patches have previously been posted by Nathan Froyd. Since
my ANDC and ORC patches were accep
Signed-off-by: Richard Henderson
---
tcg/README |2 +-
tcg/arm/tcg-target.h|1 +
tcg/i386/tcg-target.h |1 +
tcg/mips/tcg-target.h |1 +
tcg/ppc/tcg-target.h|1 +
tcg/ppc64/tcg-target.h |2 ++
tcg/s390/tcg-target.h |2 ++
tcg/sparc/tcg-targe
Use the TCGCond enumeration type in the brcond and setcond
related prototypes in tcg-op.h and each code generator.
Signed-off-by: Richard Henderson
---
tcg/i386/tcg-target.c |4 ++--
tcg/mips/tcg-target.c |8
tcg/ppc/tcg-target.c|7 ---
tcg/ppc64/tcg-target.c |
Signed-off-by: Richard Henderson
---
tcg/tcg-op.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
index 085a328..dc81f3e 100644
--- a/tcg/tcg-op.h
+++ b/tcg/tcg-op.h
@@ -1653,6 +1653,9 @@ static inline void tcg_gen_not_i64(TCGv_i64 ret, TCGv_
The TCGType name was already used consistently. Changing it
to an enumeration instead of a set of defines aids debugging.
---
tcg/tcg-op.h |2 --
tcg/tcg.h| 19 ---
2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
index 350a096.
On Fri, 19 Mar 2010 12:58:43 +0200
Shahar Havivi wrote:
> This new monitor command adding ability to handle which keyboard qemu will use
> and to see which keyboard are currently available.
>
>
> Signed-off-by: Shahar Havivi
> ---
> input.c | 73
> ++
On Thu, 18 Mar 2010 17:33:12 +0100
Markus Armbruster wrote:
>
> Signed-off-by: Markus Armbruster
> ---
> qemu-option.c | 17 ++---
> 1 files changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/qemu-option.c b/qemu-option.c
> index e3916be..5c39666 100644
> --- a/qemu-opti
On Thu, 18 Mar 2010 17:33:11 +0100
Markus Armbruster wrote:
>
> Signed-off-by: Markus Armbruster
> ---
> qerror.c |4
> qerror.h |3 +++
> 2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/qerror.c b/qerror.c
> index 9fb817e..97e8d4a 100644
> --- a/qerror.c
> +++
On Thu, 18 Mar 2010 17:33:07 +0100
Markus Armbruster wrote:
I'm getting the following build error:
"""
qemu-option.o: In function `parse_option_bool':
/home/lcapitulino/src/qmp-unstable/qemu-option.c:179: undefined reference to
`qerror_report_internal'
qemu-option.o: In function `parse_option_
Hello all,
As some of you might know, I've worked on supporting big real mode
emulation on VMX back in GSoC 2008. Looking at the Qemu GSoC ideas
list for this year, I found it among the possible ideas for a GSoC
project. I'd be interested in driving this feature towards completion,
and I have a few
On 03/19/2010 07:58 AM, Paolo Bonzini wrote:
1) Change the default CPUID bits from 6/2/3 to 6/6/1, this passes the
Linux kernel check. But I am not sure if that would introduce
regressions, since some OSes apply quirks if they detect certain models
(like we had with the sysenter issue in the pa
Does anyone care about this bug? I'm going to lose access to the test
machine where this is easily reproducible pretty soon, so if anyone
wants to take a look at this issue, now would be a good time.
thanks,
dan
On Thu, Mar 18, 2010 at 3:31 PM, Dan Gora wrote:
> Based on a recommendation from
1) Change the default CPUID bits from 6/2/3 to 6/6/1, this passes the
Linux kernel check. But I am not sure if that would introduce
regressions, since some OSes apply quirks if they detect certain models
(like we had with the sysenter issue in the past)
2) Only change the CPUID bits to 6/6/1 if
Shahar Havivi writes:
> gcc 4.4.1 produce a warning 'format not a string literal and no format
> arguments'
>
> Signed-off-by: Shahar Havivi
> ---
> qemu-error.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-error.c b/qemu-error.c
> index 5d5fe37..14ec14f
Hi,
since the default CPU model for QEMU (qemu64) is an AMD K7, the Linux
kernel complains and taints the kernel when it detects multiple
processors. The reason for this is a check for SMP safe CPUs in
arch/x86/kernel/cpu/amd.c:amd_k7_smp_check(). In recent kernels (since
about 2.6.29) this i
Allow the port 'id's to be set by a user on the command line. This is
needed by management apps that will want a stable port numbering scheme
for hot-plug/unplug and migration.
Since the port numbers are shared with the guest (to identify ports in
control messages), the config space now maintains
If the host connection to a port is closed on the destination machine
after migration, when the connection was open on the source, the host
has to be informed of that.
Similar for a host connection open on the destination.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 11 +++
Signed-off-by: Amit Shah
---
hw/virtio-console.c|2 +-
hw/virtio-serial-bus.c |2 +-
hw/virtio-serial.h |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index bd44ec6..e915491 100644
--- a/hw/virtio-console.c
+++ b
Current guests don't send more than one iov but it can change later.
Ensure we handle that case.
Signed-off-by: Amit Shah
CC: Avi Kivity
---
hw/virtio-serial-bus.c | 22 +++---
1 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-s
The check for a 0-sized write request to a guest port is not necessary;
the while loop below won't be executed in this case and all will be
fine.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-serial-bus.c
Current control messages are small enough to not be split into multiple
buffers but we could run into such a situation in the future or a
malicious guest could cause such a situation.
So handle the entire iov request for control messages.
Also ensure the size of the control request is >= what we
If some ports that were hot-plugged on the source are not available on
the destination, fail migration instead of trying to deref a NULL
pointer.
Signed-off-by: Amit Shah
Reported-by: Juan Quintela
---
hw/virtio-serial-bus.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff
Hello,
This series fixes a few issues pointed out by Avi and Juan. Avi
pointed out we should do full scatter/gather processing of guest data
even if current (well-behaved) guests don't send multiple iovs per
element.
Juan pointed out a few migration-related bugs.
In handling the migration fixes,
The number of ports on the source as well as the destination machines
should match. If they don't, it means some ports that got hotplugged on
the source aren't instantiated on the destination. Or that ports that
were hot-unplugged on the source are created on the destination.
Signed-off-by: Amit S
The target could be started with max_nr_ports for a virtio-serial device
lesser than what was available on the source machine. Fail the migration
in such a case.
Signed-off-by: Amit Shah
Reported-by: Juan Quintela
---
hw/virtio-serial-bus.c | 10 +-
1 files changed, 9 insertions(+), 1
gcc 4.4.1 produce a warning 'format not a string literal and no format
arguments'
Signed-off-by: Shahar Havivi
---
qemu-error.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-error.c b/qemu-error.c
index 5d5fe37..14ec14f 100644
--- a/qemu-error.c
+++ b/qemu-error
This new monitor command adding ability to handle which keyboard qemu will use
and to see which keyboard are currently available.
Signed-off-by: Shahar Havivi
---
input.c | 73 +++
monitor.c |8 ++
qemu-monitor.hx | 1
Qemu support for multiple keyboard devices:
Patch #1 adding keyboard is done to list instead of "last added keyboard
wins", when removing keyboard via device_del - next keyboard
selected.
Patch #2 adding 2 new monitor command to handle keyboard list:
'info keyboard' -
Currently you get segfault when trying to remove keyboard because no
keyboard handling is done.
This patch add keyboard list similar to the mouse device handlers.
Adding a keyboard add to the list, removing keyboard select the next
keyboard in list, and not leaving the keyboard handlers un-handled.
Signed-off-by: Paolo Bonzini
---
dyngen-exec.h | 26 --
tcg/arm/tcg-target.h|2 --
tcg/hppa/tcg-target.h |2 --
tcg/i386/tcg-target.h |2 --
tcg/mips/tcg-target.h |2 --
tcg/ppc/tcg-target.h|2 --
tcg/ppc64/tcg-target.h |2
The period for Win32 timers is very short and always the same
independent of dynticks, so it's possible that the timer fires
before qemu_run_all_timers has reset alarm_timer->pending to zero.
Reset alarm_timer->pending before rearming.
Signed-off-by: Paolo Bonzini
Signed-off-by: Paolo Bonzini
-
On 03/18/2010 01:27 AM, Edgar E. Iglesias wrote:
Hi,
I usually mail out negative test reults but this time I've just
pulled and merged to my 4 different CRIS, PPC and MicroBlaze trees
from upstream and things Just Worked.
Was this userspace or system testing?
Thanks,
Paolo
Signed-off-by: Paolo Bonzini
---
qemu-sockets.c | 24
qemu_socket.h |1 +
vl.c | 24
3 files changed, 25 insertions(+), 24 deletions(-)
diff --git a/qemu-sockets.c b/qemu-sockets.c
index 23c3def..a7399aa 100644
--- a/qemu-socke
On Fri, Mar 19, 2010 at 11:40:00AM +0100, Paolo Bonzini wrote:
> On 03/18/2010 01:27 AM, Edgar E. Iglesias wrote:
> > Hi,
> >
> > I usually mail out negative test reults but this time I've just
> > pulled and merged to my 4 different CRIS, PPC and MicroBlaze trees
> > from upstream and things Just
Signed-off-by: Paolo Bonzini
---
hw/i8259.c |1 +
hw/isa-bus.c |1 +
vl.c |6 --
3 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/i8259.c b/hw/i8259.c
index 3de22e3..37ef04e 100644
--- a/hw/i8259.c
+++ b/hw/i8259.c
@@ -68,6 +68,7 @@ static int irq_level[
Signed-off-by: Paolo Bonzini
---
Makefile.target |2 +-
balloon.c | 145 +++
balloon.h |6 ++
monitor.c | 85
vl.c| 34 -
5 files changed, 152 insertions(+),
I've had these for a while, but as they conflicted with the timer patch
I waited before sending them.
Paolo Bonzini (3):
move socket_init to qemu-sockets.c
move two variable declarations out of vl.c
move balloon handling to balloon.c
Makefile.target |2 +-
balloon.c | 145 ++
On Fri, Mar 19, 2010 at 17:33, Paolo Bonzini wrote:
> On 03/19/2010 06:24 AM, TeLeMan wrote:
>>
>> I fetched the lastest qemu-timer codes and found qemu would have no
>> response when the guest os was WinXP and the timer was "dynticks" on
>> the win32 host. After qemu froze, it seemed the win32_r
On 03/19/2010 06:24 AM, TeLeMan wrote:
I fetched the lastest qemu-timer codes and found qemu would have no
response when the guest os was WinXP and the timer was "dynticks" on
the win32 host. After qemu froze, it seemed the win32_rearm_timer()
would never be called and alarm_timer->pending was a
62 matches
Mail list logo
