[Qemu-devel] Bug: hpet timer hangs QEMU using icount

2010-03-01 Thread Xin Li
Hpet hangs QEMU when icount is present. I don't know if this is a universal problem. The cause is that for periodical timers, hpet_timer function tries to insert the timer back to the active timers queue, using an updated expire time. However, before the update, if the expire time is equal to t

[Qemu-devel] bug reporting procedure

2010-03-01 Thread Xin Li
Hello qemu devs, I'm recently playing with QEMU for my research project. I think I've found a bug on my way, and I have my patch solving it. I wonder if there is a formal procedure to follow in order to file a bug report? Thanks! -Xin

[Qemu-devel] Re: KVM call agenda for Mar 2

2010-03-01 Thread Anthony Liguori
On 03/01/2010 06:46 PM, Chris Wright wrote: - Shared memory transport - Ram area allocations - Request for 0.13 feature review/update [1] [1] http://wiki.qemu.org/Features/0.13 Regards, Anthony Liguori Please send in any additional agenda items you are interested in covering. thanks,

[Qemu-devel] Re: Regression: Windows NT 3.51/4.0 freezes when booting to first stage setup (i386)

2010-03-01 Thread Roy Tam
2010/3/2 Roy Tam : > Hi all, > > I found that QEMU 0.12.x break Windows NT 3.51 for i386 installation. > Before 0.12, which use Bochs BIOS, in the beginning of second stage > setup, after loading keyboard driver Installer will switch screen to > 80x50 text mode, trun screen in blue and showing Star

[Qemu-devel] Most PowerPC machines not working.

2010-03-01 Thread Natalia Portillo
Mac OS X 0.12.2 following: zeus:Apple_Service_Diagnostic claunia$ qemu-system-ppc -M prep qemu: hardware error: PowerPC 601 / 620 / 970 need a 1MB BIOS CPU #0: NIP LR CTR XER MSR HID0 HF idx 0 TB DECR GP

[Qemu-devel] can i get the QEMU source code for ARM host platform?

2010-03-01 Thread 현해일
Hi, my name is haeil. I want to port QEMU on the ARM11 platform. I think, many developers try to this work. So, Can I get the QEMU source code for ARM host platform? Or anything information about related work? if you have any idea, please let me know. regards. -heail

[Qemu-devel] Regression: Windows NT 3.51 freezes when booting to second stage setup (i386)

2010-03-01 Thread Roy Tam
Hi all, I found that QEMU 0.12.x break Windows NT 3.51 for i386 installation. Before 0.12, which use Bochs BIOS, in the beginning of second stage setup, after loading keyboard driver Installer will switch screen to 80x50 text mode, trun screen in blue and showing Startup banner. But in 0.12, which

[Qemu-devel] KVM call agenda for Mar 2

2010-03-01 Thread Chris Wright
- Shared memory transport Please send in any additional agenda items you are interested in covering. thanks, -chris

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-01 Thread Marcelo Tosatti
On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: > This grand cleanup drops all reset and vmsave/load related > synchronization points in favor of four(!) generic hooks: > > - cpu_synchronize_all_states in qemu_savevm_state_complete > (initial sync from kernel before vmsave) > - cpu_s

[Qemu-devel] [PATCH] arm: make RFE usable with any register

2010-03-01 Thread Adam Lackorzynski
The rfe instruction can be used with any register, not just sp. Adjust the condition check accordingly. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 0c65

[Qemu-devel] Re: Regression: segfault on ARM host

2010-03-01 Thread Aurelien Jarno
On Mon, Mar 01, 2010 at 11:33:23PM +0100, Paolo Bonzini wrote: > On 03/01/2010 10:33 PM, Aurelien Jarno wrote: >> While trying to implement setcond on TCG ARM, I have discovered it does >> not work anymore. I have bisected this regression to: >> >> commit 6113d6d3169393c323ac4c82d756a850145a5e7a >>

Re: [Qemu-devel] [patch uq/master 2/2] Add option to use file backed guest memory

2010-03-01 Thread Marcelo Tosatti
On Mon, Mar 01, 2010 at 08:25:08PM -0300, Marcelo Tosatti wrote: > Hi Paul, > > Thank you for reviewing. > > On Sun, Feb 28, 2010 at 01:28:16AM +, Paul Brook wrote: > > IMHO it would be better to check the mem_path != NULL here, rather that > > burying the check in file_ram_alloc. > > > > >

Re: [Qemu-devel] [patch uq/master 2/2] Add option to use file backed guest memory

2010-03-01 Thread Marcelo Tosatti
Hi Paul, Thank you for reviewing. On Sun, Feb 28, 2010 at 01:28:16AM +, Paul Brook wrote: > IMHO it would be better to check the mem_path != NULL here, rather that > burying the check in file_ram_alloc. > > >+if (memory < hpagesize) { > >+return NULL; > >+} > > Ah, so it's

[Qemu-devel] Re: Regression: segfault on ARM host

2010-03-01 Thread Paolo Bonzini
On 03/01/2010 10:33 PM, Aurelien Jarno wrote: While trying to implement setcond on TCG ARM, I have discovered it does not work anymore. I have bisected this regression to: commit 6113d6d3169393c323ac4c82d756a850145a5e7a Author: Paolo Bonzini Date: Fri Jan 15 09:42:09 2010 +0100 change wh

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-01 Thread Anthony Liguori
On 03/01/2010 01:27 PM, Michael S. Tsirkin wrote: On Sun, Feb 28, 2010 at 10:39:21PM +, Paul Brook wrote: I'm sympathetic to your arguments though. As qemu is today, the above is definitely the right thing to do. But ram is always ram and ram always has a fixed (albeit non-linear) mapp

[Qemu-devel] [PATCH 4/4] tcg/arm: accept immediate arguments for brcond/setcond

2010-03-01 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 26 -- 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index d743dbc..63f84c3 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -1512,8 +151

[Qemu-devel] [PATCH 3/4] tcg/arm: implement setcond2

2010-03-01 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 9a76ecb..d743dbc 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -1539,6 +1539,16 @@ static

[Qemu-devel] [PATCH 2/4] tcg/arm: implement setcond

2010-03-01 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 7bdfda9..9a76ecb 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -1531,6 +1531,14 @@ static inl

[Qemu-devel] [PATCH 1/4] tcg/arm: fix div2/divu2

2010-03-01 Thread Aurelien Jarno
When restoring register values, increase the stack register for skipped values. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 30 -- 1 files changed, 24 insertions(+), 6 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index f8d626d.

[Qemu-devel] tcg/arm fixes and improvements

2010-03-01 Thread Aurelien Jarno
This patch series fix a bug in div2/divu2 ops, implement setcond and setcond2 ops and improve brcond/setcond by allowing immediate constants. I have tested it using a modified version of target-mips/translate.c which includes setcond ops, and running mips-linux-user binaries. The first fixes wa

[Qemu-devel] Regression: segfault on ARM host

2010-03-01 Thread Aurelien Jarno
While trying to implement setcond on TCG ARM, I have discovered it does not work anymore. I have bisected this regression to: commit 6113d6d3169393c323ac4c82d756a850145a5e7a Author: Paolo Bonzini Date: Fri Jan 15 09:42:09 2010 +0100 change while to if The while loop will be executed e

[Qemu-devel] [PATCH] configure: Fix code which creates config.mak files

2010-03-01 Thread Stefan Weil
These files are created by configure and grow unnecessarily at each new call of configure: roms/seabios/config.mak roms/vgabios/config.mak libhw32/config.mak libhw64/config.mak libhw32/config.mak and libhw64/config.mak set compiler options, and the wrong old code results in very long command line

[Qemu-devel] Re: EHCI support in QEMU

2010-03-01 Thread Jan Kiszka
Niels de Vos wrote: > Hello Jan and Taimoor, > > On Mon, Feb 15, 2010 at 9:36 AM, Jan Kiszka wrote: >>> I downloaded version 0.12.2 of QEMU and I am unable to find EHCI >>> support in it. Does QEMU support EHCI emulation? Do I need to >>> download some other patch for it? QEMU documentation also

[Qemu-devel] [PATCH] configure: Fix wrong stderr redirection

2010-03-01 Thread Stefan Weil
Signed-off-by: Stefan Weil --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index dfe3e42..a14aba7 100755 --- a/configure +++ b/configure @@ -1091,8 +1091,8 @@ EOF # static link with sdl ? (note: sdl.pc's --static --libs is broke

Re: [Qemu-devel] Re: EHCI support in QEMU

2010-03-01 Thread Niels de Vos
Hello Jan and Taimoor, On Mon, Feb 15, 2010 at 9:36 AM, Jan Kiszka wrote: >> I downloaded version 0.12.2 of QEMU and I am unable to find EHCI >> support in it. Does QEMU support EHCI emulation? Do I need to >> download some other patch for it? QEMU documentation also does not >> tell anything abo

[Qemu-devel] Re: [PATCH v4 00/10] qemu-kvm: Hook cleanups and yet more use of upstream code

2010-03-01 Thread Marcelo Tosatti
On Mon, Mar 01, 2010 at 06:17:19PM +0100, Jan Kiszka wrote: > Rebased over latest master. > > Pull URL is > > git://git.kiszka.org/qemu-kvm.git queues/queues-kvm-merge > > Jan Kiszka (10): > qemu-kvm: Add KVM_CAP_X86_ROBUST_SINGLESTEP-awareness > qemu-kvm: Rework VCPU state writeback A

[Qemu-devel] [PATCH 0/4] Support NPTL support for ColdFire and related fixes

2010-03-01 Thread Maxim Kuvyrkov
The following series of 4 patches adds NPTL support for ColdFire user-mode emulation and fixes several related issues, mainly in signal handling. 0001-Add-NPTL-support-for-ColdFire.patch Implement new kernel syscalls to support TLS storage and synchronization (merged to 2.6.34 kernel) 0002-H

[Qemu-devel] [PATCH 4/4] Define MMAP_SHIFT for ColdFire

2010-03-01 Thread Maxim Kuvyrkov
>From c65168b123032ef2ab10c90254e4ac8bc6cb0120 Mon Sep 17 00:00:00 2001 From: Maxim Kuvyrkov Date: Mon, 1 Mar 2010 02:51:10 -0800 Subject: [PATCH 4/4] Define MMAP_SHIFT for ColdFire ColdFire has MMAP_SHIFT equal to TARGET_PAGE_BITS. Signed-off-by: Maxim Kuvyrkov --- target-m68k/cpu.h |1

[Qemu-devel] [PATCH 3/4] Fix signal handling for ColdFire

2010-03-01 Thread Maxim Kuvyrkov
>From 1450a09c513a3051e3cf44d948983fe48ef368e0 Mon Sep 17 00:00:00 2001 From: Maxim Kuvyrkov Date: Mon, 1 Mar 2010 02:48:31 -0800 Subject: [PATCH 3/4] Fix signal handling for ColdFire Handle FPU registers. Pack structures that contain 16-bit fields. This avoid problems due to differences betwe

[Qemu-devel] [PATCH 2/4] Handle SIGKILL and SIGCHLD

2010-03-01 Thread Maxim Kuvyrkov
>From a659ff77804712826c1c1fe739339f1b1a172ed6 Mon Sep 17 00:00:00 2001 From: Maxim Kuvyrkov Date: Mon, 1 Mar 2010 02:39:48 -0800 Subject: [PATCH 2/4] Handle SIGKILL and SIGCHLD Handle SIGKILL and SIGCHLD in linux user-space emulation. Signed-off-by: Maxim Kuvyrkov --- linux-user/signal.c |

[Qemu-devel] [PATCH 1/4] Add NPTL support for ColdFire

2010-03-01 Thread Maxim Kuvyrkov
>From 1e505c8434d42f9b4fb1cc60934f856ffc06b476 Mon Sep 17 00:00:00 2001 From: Maxim Kuvyrkov Date: Mon, 1 Mar 2010 02:35:53 -0800 Subject: [PATCH 1/4] Add NPTL support for ColdFire Add emulation of new m68k syscalls that provide kernel support for NPTL. Signed-off-by: Maxim Kuvyrkov --- confi

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-01 Thread Michael S. Tsirkin
On Sun, Feb 28, 2010 at 10:39:21PM +, Paul Brook wrote: > > I'm sympathetic to your arguments though. As qemu is today, the above > > is definitely the right thing to do. But ram is always ram and ram > > always has a fixed (albeit non-linear) mapping within a guest. > > I think this assumpt

[Qemu-devel] Another VNC crash, qemu-kvm-0.12.3

2010-03-01 Thread Chris Webb
We've just seen another VNC related qemu-kvm crash, this time an arithmetic exception at vnc.c:1424 in the newly release qemu-kvm 0.12.3. [...] 1423 if (vs->absolute) { 1424 kbd_mouse_event(x * 0x7FFF / (ds_get_width(vs->ds) - 1), 1425 y * 0x7FFF / (ds_

[Qemu-devel] [PATCH 1/4] KVM: Rework of guest debug state writing

2010-03-01 Thread Jan Kiszka
So far we synchronized any dirty VCPU state back into the kernel before updating the guest debug state. This was a tribute to a deficite in x86 kernels before 2.6.33. But as this is an arch-dependent issue, it is better handle in the x86 part of KVM and remove the writeback point for generic code.

[Qemu-devel] [PATCH 4/4] x86: Extend validity of bsp_to_cpu

2010-03-01 Thread Jan Kiszka
As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals cpu_index, bsp_to_cpu can also be based on the latter directly. This will help an early user of it: KVM while initializing mp_state. Signed-off-by: Jan Kiszka --- hw/pc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-01 Thread Jan Kiszka
This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) - cpu_synchronize_all_post_init in qemu_loadvm_state (writeback after vmload)

[Qemu-devel] [PATCH 3/4] KVM: x86: Restrict writeback of VCPU state

2010-03-01 Thread Jan Kiszka
Do not write nmi_pending, sipi_vector, and mpstate unless we at least go through a reset. And TSC as well as KVM wallclocks should only be written on full sync, otherwise we risk to drop some time on state read-modify-write. Signed-off-by: Jan Kiszka --- target-i386/kvm.c | 32

[Qemu-devel] [PATCH 0/4] [uq/master] VCPU writeback rework and related bits

2010-03-01 Thread Jan Kiszka
This is the corresponding uq/master series to [1]. Should allow smooth re-sync with upstream once merged. Pull URL is git://git.kiszka.org/qemu-kvm.git queues/kvm-upstream [1] http://thread.gmane.org/gmane.comp.emulators.kvm.devel/47706 Jan Kiszka (4): KVM: Rework of guest debug state

Re: [Qemu-devel] [PATCH 01/20] eepro100: Fix compiler errors from debug messages

2010-03-01 Thread Stefan Weil
Anthony Liguori schrieb: > On 02/14/2010 10:16 AM, Stefan Weil wrote: >> When debug output was enabled (by defining DEBUG_EEPRO100), >> some debug messages resulted in a compiler error. >> >> This is fixed here. >> >> Signed-off-by: Stefan Weil >> > > Michael, > > Can you take these through you

[Qemu-devel] Re: [PATCH v4 00/10] qemu-kvm: Hook cleanups and yet more use of upstream code

2010-03-01 Thread Jan Kiszka
Jan Kiszka wrote: > Rebased over latest master. Oh, and I added that TSC issue workaround to patch 7. My memory... Jan > > Pull URL is > > git://git.kiszka.org/qemu-kvm.git queues/queues-kvm-merge > > Jan Kiszka (10): > qemu-kvm: Add KVM_CAP_X86_ROBUST_SINGLESTEP-awareness > qemu-kv

[Qemu-devel] [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-01 Thread Jan Kiszka
As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals cpu_index, cpu_is_bsp can also be based on the latter directly. This will help an early user of it: KVM while initializing mp_state. Signed-off-by: Jan Kiszka --- hw/pc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH v4 10/10] qemu-kvm: Bring qemu_init_vcpu back home

2010-03-01 Thread Jan Kiszka
There is no need for the this hack anymore, initialization is now robust against reordering as it doesn't try to write the VCPU state on its own. Signed-off-by: Jan Kiszka --- hw/pc.c |5 - target-i386/helper.c |2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) dif

[Qemu-devel] [PATCH v4 01/10] qemu-kvm: Add KVM_CAP_X86_ROBUST_SINGLESTEP-awareness

2010-03-01 Thread Jan Kiszka
This add-on patch to recent guest debugging refactorings adds the requested awareness for KVM_CAP_X86_ROBUST_SINGLESTEP to both the upstream as well as qemu-kvm's own code. Fortunately, code sharing increased once again. Signed-off-by: Jan Kiszka --- kvm-all.c | 12 ++ kvm.h

[Qemu-devel] [PATCH v4 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback

2010-03-01 Thread Jan Kiszka
Drop kvm_load_tsc in favor of level-dependent writeback in kvm_arch_load_regs. KVM's PV clock MSRs fall in the same category and should therefore only be written back on full sync. Signed-off-by: Jan Kiszka --- qemu-kvm-x86.c| 27 +-- qemu-kvm.h|

[Qemu-devel] [PATCH v4 06/10] qemu-kvm: Use VCPU event state for reset and vmsave/load

2010-03-01 Thread Jan Kiszka
Push reading/writing of vcpu_events into kvm_arch_load/save_regs to avoid KVM-specific hooks in generic code. Signed-off-by: Jan Kiszka --- kvm.h |2 -- qemu-kvm-x86.c|6 -- target-i386/kvm.c |4 ++-- target-i386/machine.c |6 -- 4 files change

[Qemu-devel] [PATCH v4 02/10] qemu-kvm: Rework VCPU state writeback API

2010-03-01 Thread Jan Kiszka
This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) - cpu_synchronize_all_post_init in qemu_loadvm_state (writeback after vmload)

[Qemu-devel] [PATCH v4 08/10] qemu-kvm: Clean up KVM's APIC hooks

2010-03-01 Thread Jan Kiszka
The APIC is part of the VCPU state, so trigger its readout and writeback from kvm_arch_save/load_regs. Thanks to the transparent sync on reset and vmsave/load, we can also drop explicit sync code, reducing the diff to upstream. Signed-off-by: Jan Kiszka --- hw/apic.c | 37 +---

[Qemu-devel] [PATCH v4 04/10] qemu-kvm: Clean up mpstate synchronization

2010-03-01 Thread Jan Kiszka
Push mpstate reading/writing into kvm_arch_load/save_regs and, on x86, properly synchronize with halted in the accessor functions. At this chance, drop the special reset of interrupt_request and halted in kvm_arch_cpu_reset. The former is done via memset in cpu_reset, the latter in apic_init_reset

[Qemu-devel] [PATCH v4 00/10] qemu-kvm: Hook cleanups and yet more use of upstream code

2010-03-01 Thread Jan Kiszka
Rebased over latest master. Pull URL is git://git.kiszka.org/qemu-kvm.git queues/queues-kvm-merge Jan Kiszka (10): qemu-kvm: Add KVM_CAP_X86_ROBUST_SINGLESTEP-awareness qemu-kvm: Rework VCPU state writeback API x86: Extend validity of cpu_is_bsp qemu-kvm: Clean up mpstate synchro

[Qemu-devel] [PATCH v4 05/10] KVM: x86: Restrict writeback of VCPU state

2010-03-01 Thread Jan Kiszka
Do not write nmi_pending, sipi_vector, and mpstate unless we at least go through a reset. And TSC as well as KVM wallclocks should only be written on full sync, otherwise we risk to drop some time on during state read-modify-write. Signed-off-by: Jan Kiszka --- kvm.h |2 +- q

[Qemu-devel] [PATCH v4 09/10] qemu-kvm: Move kvm_set_boot_cpu_id

2010-03-01 Thread Jan Kiszka
Setting the boot CPU ID is arch-specific KVM stuff. So push it where it belongs to. Signed-off-by: Jan Kiszka --- hw/pc.c|3 --- qemu-kvm-x86.c |3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 58c32ea..d819fca 100644 --- a/hw/pc.c +++

[Qemu-devel] [PATCH] arm: Fix missing 'return' in SRS handling.

2010-03-01 Thread Adam Lackorzynski
There's a return missing in the srs handling which leads to srs always being treated an an invalid op. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 9607a

Re: [Qemu-devel] [PATCH RFC 35/48] monitor: New in_qmp_mon()

2010-03-01 Thread Luiz Capitulino
On Mon, 01 Mar 2010 10:19:49 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 24 Feb 2010 18:55:47 +0100 > > Markus Armbruster wrote: > > > >> > >> Signed-off-by: Markus Armbruster > >> --- > >> monitor.c |5 + > >> monitor.h |2 ++ > >> 2 files changed, 7

Re: [Qemu-devel] [PATCH RFC 17/48] error: Infrastructure to track locations for error reporting

2010-03-01 Thread Luiz Capitulino
On Mon, 01 Mar 2010 10:19:22 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 24 Feb 2010 18:55:29 +0100 > > Markus Armbruster wrote: > > > >> New struct Location holds a location. So far, the only location is > >> LOC_NONE, so this doesn't do anything useful yet. > >>

Re: [Qemu-devel] [PATCH RFC 15/48] error: Don't abuse qemu_error() for non-error in qdev_device_help()

2010-03-01 Thread Luiz Capitulino
On Mon, 01 Mar 2010 10:05:18 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 24 Feb 2010 18:55:27 +0100 > > Markus Armbruster wrote: > > > >> qdev_device_help() prints device information with qemu_error(). A > >> later commit will make qemu_error() print additional stuf

Re: [Qemu-devel] [PATCH RFC 12/48] error: New error_printf() and error_vprintf()

2010-03-01 Thread Luiz Capitulino
On Mon, 01 Mar 2010 09:54:32 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 24 Feb 2010 18:55:24 +0100 > > Markus Armbruster wrote: > > > >> FIXME They should return int, so callers can calculate width. > >> > >> Signed-off-by: Markus Armbruster > >> --- > >> qemu-er

Re: [Qemu-devel] [PATCH RFC 00/48] Convert device_add to QObject / QError

2010-03-01 Thread Luiz Capitulino
On Mon, 01 Mar 2010 08:59:38 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: [...] > >We didn't expose 'info', for example, because > > having a command (or 'remote procedure') returning all sorts of possible > > data is no good. > > Why? What's the f

Re: [Qemu-devel] [PATCH 2/2] [RFC] ARMv7: Support for simplified access permissions checking

2010-03-01 Thread Paul Brook
> ARMv7 has a simplified access permissions model that is enabled > by setting the AFE bit of the SCTLR. This patch adds checking > for permission values for when this mode is selected. This is already implemented. Paul

Re: [Qemu-devel] [PATCH 0/2] simplify global register save/restore

2010-03-01 Thread Paul Brook
> On 02/26/2010 07:32 PM, Paul Brook wrote: > >> > You could still use them for local register variables, but I can > >> > prepare a patch to remove them (unless you do that yourself). > > > > I'm not sure what you mean by a "local register variable". > > I'm thinking of using > >register bl

[Qemu-devel] Re: [PATCH RFC 12/48] error: New error_printf() and error_vprintf()

2010-03-01 Thread Paolo Bonzini
On 03/01/2010 09:54 AM, Markus Armbruster wrote: Luiz Capitulino writes: On Wed, 24 Feb 2010 18:55:24 +0100 Markus Armbruster wrote: FIXME They should return int, so callers can calculate width. Signed-off-by: Markus Armbruster --- qemu-error.c | 49

Re: [Qemu-devel] [PATCH 0/2] simplify global register save/restore

2010-03-01 Thread Paolo Bonzini
On 02/26/2010 07:32 PM, Paul Brook wrote: > You could still use them for local register variables, but I can prepare > a patch to remove them (unless you do that yourself). I'm not sure what you mean by a "local register variable". I'm thinking of using register blah blah asm(AREG1); as

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-03-01 Thread Shahar Havivi
On Sat, Feb 27, 2010 at 09:20:28AM -0700, David S. Ahern wrote: > Date: Sat, 27 Feb 2010 09:20:28 -0700 > From: "David S. Ahern" > To: Shahar Havivi > CC: qemu-devel@nongnu.org, Dor Laor > Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based > monitor > > > > > > On

Re: [Qemu-devel] [PATCH] VirtIO: Fix QEMU crash during Windows PNP tests

2010-03-01 Thread Gleb Natapov
On Mon, Mar 01, 2010 at 12:14:43PM +0100, Alexander Graf wrote: > > On 14.09.2009, at 15:31, Yan Vugenfirer wrote: > > > Signed-off-by: Yan Vugenfirer > > > > --- > > hw/virtio-pci.c | 14 -- > > 1 files changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/hw/virtio-pci.

Re: [Qemu-devel] [PATCH] VirtIO: Fix QEMU crash during Windows PNP tests

2010-03-01 Thread Alexander Graf
On 14.09.2009, at 15:31, Yan Vugenfirer wrote: > Signed-off-by: Yan Vugenfirer > > --- > hw/virtio-pci.c | 14 -- > 1 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c > index f812ab7..a0a22c4 100644 > --- a/hw/virtio-pci.c > +++ b/

Re: [Qemu-devel] [PATCH RFC 48/48] monitor: convert do_device_add() to QObject

2010-03-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:56:00 +0100 > Markus Armbruster wrote: > >> >> Signed-off-by: Markus Armbruster >> --- >> hw/qdev.c | 29 + >> hw/qdev.h |2 +- >> qemu-monitor.hx |3 ++- >> 3 files changed, 24 insertions(+), 1

Re: [Qemu-devel] [PATCH RFC 43/48] qemu-option: Functions to convert to/from QDict.

2010-03-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:55 +0100 > Markus Armbruster wrote: > >> FIXME Only string options are implemented. >> >> Signed-off-by: Markus Armbruster >> --- >> qemu-option.c | 54 ++ >> qemu-option.h |3 +++ >>

Re: [Qemu-devel] [PATCH RFC 35/48] monitor: New in_qmp_mon()

2010-03-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:47 +0100 > Markus Armbruster wrote: > >> >> Signed-off-by: Markus Armbruster >> --- >> monitor.c |5 + >> monitor.h |2 ++ >> 2 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/monitor.c b/monitor.c >> index a42

Re: [Qemu-devel] [PATCH RFC 17/48] error: Infrastructure to track locations for error reporting

2010-03-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:29 +0100 > Markus Armbruster wrote: > >> New struct Location holds a location. So far, the only location is >> LOC_NONE, so this doesn't do anything useful yet. >> >> Passing the current location all over the place would be too >> cumbersome.

Re: [Qemu-devel] [PATCH RFC 15/48] error: Don't abuse qemu_error() for non-error in qdev_device_help()

2010-03-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:27 +0100 > Markus Armbruster wrote: > >> qdev_device_help() prints device information with qemu_error(). A >> later commit will make qemu_error() print additional stuff that is >> only appropriate for proper errors, and then this will break.

Re: [Qemu-devel] [PATCH RFC 13/48] error: Make qemu_error() add a newline, strip it from arguments

2010-03-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:25 +0100 > Markus Armbruster wrote: > >> This fixes a few error messages lacking a newline: >> net_handle_fd_param()'s "No file descriptor named %s found", and >> tap_open()'s "vnet_hdr=1 requested, but no kernel support for >> IFF_VNET_HDR ava

Re: [Qemu-devel] [PATCH RFC 12/48] error: New error_printf() and error_vprintf()

2010-03-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:24 +0100 > Markus Armbruster wrote: > >> FIXME They should return int, so callers can calculate width. >> >> Signed-off-by: Markus Armbruster >> --- >> qemu-error.c | 49 ++--- >> qemu-error.h |

Re: [Qemu-devel] [PATCH RFC 11/48] error: Move qemu_error & friends into their own header

2010-03-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:23 +0100 > Markus Armbruster wrote: > >> >> Signed-off-by: Markus Armbruster >> --- >> hw/scsi-bus.c |2 +- >> hw/scsi-disk.c|3 +-- >> hw/scsi-generic.c |1 + >> hw/usb-serial.c |1 + >> hw/virtio-net.c |1 +

Re: [Qemu-devel] Re: [PATCH] scsi: Make device scsi-disk reject /dev/sg*

2010-03-01 Thread Gerd Hoffmann
On 02/28/10 02:45, Paul Brook wrote: On 02/25/10 11:23, Markus Armbruster wrote: You're supposed to use scsi-generic for that. Which rejects anything but /dev/sg*. Well, it isn't *that* easy. The SG_IO ioctl used by scsi-generic works on tons of devices in linux, not only /dev/sg*. I've see

Re: [Qemu-devel] [PATCH 4/4] kbd keds: vnc

2010-03-01 Thread Gerd Hoffmann
On 02/28/10 02:38, Paul Brook wrote: Usually guests use the keyboard leds to signal the capslock and numlock state to the user, so we can use this to better keep track of capslock and numlock state in the qemu vnc server. Isn't this going to break horribly when my guest starts flashing the caps

[Qemu-devel] Intel PXA270 System-on-chip emulation in QEMU

2010-03-01 Thread Taimoor Mirza
Hi all, I want to know about Intel PXA270 System-on-chip emulation in QEMU. Does this emulation includes "USB client controller" emulation? Actually I've a USB device application developed using Linux USB Gadget framework and I want to emulate this on QEMU but I am unable to find any USB

Re: [Qemu-devel] [PATCH RFC 00/48] Convert device_add to QObject / QError

2010-03-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:12 +0100 > Markus Armbruster wrote: > >> Why this is such a big job? There are two issues with a naive >> conversion: >> >> * Error message degradation [...] >> * String argument with option syntax, i.e. NAME=VALUE,... >> >> QMP uses JSON