Hi all!
Running "msgmerge" with qemu-arm (d616cf1d1510c963fc1876cb10f5f1fa226b54ef) I
get
stuck in an endless loop in exec.c (~line 1294):
code-snippet:
ptb = &tb_next->jmp_first;
for(;;) {
tb1 = *ptb;
n1 = (long)tb1 & 3;
tb1 = (TranslationBlo
On 02/26/2010 01:04 PM, Shahar Havivi wrote:
> Fix codding style
> ---
> qemu-char.c |9 +
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 4169492..4533887 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1002,6 +1002,7 @@
On Fri, 2010-02-26 at 17:26 -0300, Luiz Capitulino wrote:
> This patch fixes both. One question, though:
>
> > @@ -2332,6 +2331,7 @@ static int do_balloon(Monitor *mon, const QDict
> > *params,
> > return -1;
> > }
> >
> > +cb(opaque, NULL);
> > return 0;
> > }
>
> Ca
On Mon, 22 Feb 2010 10:51:20 -0600
Adam Litke wrote:
> On Fri, 2010-02-19 at 15:47 -0600, Anthony Liguori wrote:
> > On 02/12/2010 02:55 PM, Adam Litke wrote:
> > > Arghh... Adding missing S-O-B
> > >
> > > Hi Anthony. I wonder if there was a problem when importing my async
> > > command handler
On Mon, 22 Feb 2010 18:05:02 -0300
Luiz Capitulino wrote:
>
> Hi Paul,
>
> Commit bc3b26f5 breaks a full QEMU build for me:
This is fixed, fwiw.
Fix codding style
---
qemu-char.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 4169492..4533887 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed,
speed, par
On Wed, 24 Feb 2010 18:56:00 +0100
Markus Armbruster wrote:
>
> Signed-off-by: Markus Armbruster
> ---
> hw/qdev.c | 29 +
> hw/qdev.h |2 +-
> qemu-monitor.hx |3 ++-
> 3 files changed, 24 insertions(+), 10 deletions(-)
>
> diff --git a/hw/qd
On Wed, 24 Feb 2010 18:55:55 +0100
Markus Armbruster wrote:
> FIXME Only string options are implemented.
>
> Signed-off-by: Markus Armbruster
> ---
> qemu-option.c | 54 ++
> qemu-option.h |3 +++
> 2 files changed, 57 insertions(+), 0
On Wed, 24 Feb 2010 18:55:47 +0100
Markus Armbruster wrote:
>
> Signed-off-by: Markus Armbruster
> ---
> monitor.c |5 +
> monitor.h |2 ++
> 2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index a4263af..5c87a98 100644
> --- a/monitor.c
>
On Wed, 24 Feb 2010 18:55:29 +0100
Markus Armbruster wrote:
> New struct Location holds a location. So far, the only location is
> LOC_NONE, so this doesn't do anything useful yet.
>
> Passing the current location all over the place would be too
> cumbersome. Hide it away in static cur_loc ins
On Wed, 24 Feb 2010 18:55:23 +0100
Markus Armbruster wrote:
>
> Signed-off-by: Markus Armbruster
> ---
> hw/scsi-bus.c |2 +-
> hw/scsi-disk.c|3 +--
> hw/scsi-generic.c |1 +
> hw/usb-serial.c |1 +
> hw/virtio-net.c |1 +
> hw/virtio-pci.c |2 +-
> monit
On Wed, 24 Feb 2010 18:55:27 +0100
Markus Armbruster wrote:
> qdev_device_help() prints device information with qemu_error(). A
> later commit will make qemu_error() print additional stuff that is
> only appropriate for proper errors, and then this will break. Use
> error_printf() instead.
Ar
On Wed, 24 Feb 2010 18:55:24 +0100
Markus Armbruster wrote:
> FIXME They should return int, so callers can calculate width.
>
> Signed-off-by: Markus Armbruster
> ---
> qemu-error.c | 49 ++---
> qemu-error.h | 14 ++
> 2 files change
On Wed, 24 Feb 2010 18:55:25 +0100
Markus Armbruster wrote:
> This fixes a few error messages lacking a newline:
> net_handle_fd_param()'s "No file descriptor named %s found", and
> tap_open()'s "vnet_hdr=1 requested, but no kernel support for
> IFF_VNET_HDR available" (all three versions).
>
>
On Wed, 24 Feb 2010 18:55:12 +0100
Markus Armbruster wrote:
> Why this is such a big job? There are two issues with a naive
> conversion:
>
> * Error message degradation
>
> The error messages are worded for -device. They aren't so hot to
> begin with: we typically have many -device optio
> On 02/26/2010 12:30 PM, Paul Brook wrote:
> >> Since b567b38 (target-arm: remove T0 and T1, 2009-10-16) the only global
> >> register that is actually used is AREG0, so the complexity of
> >> hostregs_helper.h is unwarranted.
> >>
> >> Let's just say that env should be the only global register.
Hi Daniel,
Am 26.02.2010 18:13, schrieb Daniel Gutson:
> Hello Kevin,
> please let me know if this works.
> If so, please remember that I'd need somebody to commit this for me, since I
> don't have write-access.
>
> Undoing line wrap and tabs.
I'm not a committer either. The patch format
Gerd Hoffmann wrote:
> Hi,
>
> This patch series adds support for keyboard led status tracking to qemu.
> The first patch adds the infrastructure to set the led status and to
> register notify callbacks. Patches #2 and #3 add support for the usb
> and ps/2 keyboard drivers. Patch #4 makes vnc
Hello Kevin,
please let me know if this works.
If so, please remember that I'd need somebody to commit this for me, since I
don't have write-access.
Undoing line wrap and tabs.
Thanks!
Daniel.
[old same text.]
With this patch, 'gdb detach' correctly resumes the inferior executio
Adds infrastructure for keyboard led status tracking to qemu.
Signed-off-by: Gerd Hoffmann
---
console.h | 15 +++
input.c | 31 +++
2 files changed, 46 insertions(+), 0 deletions(-)
diff --git a/console.h b/console.h
index 916859d..71e8ff2 100644
-
Add led status notification support to the usb kbd driver.
Signed-off-by: Gerd Hoffmann
---
hw/usb-hid.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/hw/usb-hid.c b/hw/usb-hid.c
index bf456bb..2e4e647 100644
--- a/hw/usb-hid.c
+++ b/hw/usb-hid.c
@@ -600,12 +600
Use led status notification support in vnc.
The qemu vnc server keeps track of the capslock and numlock states based
on the key presses it receives from the vnc client. But this fails in
case the guests idea of the capslock and numlock state changes for other
reasons. One case is guest reboot (+
Add led status notification support to the ps/2 kbd driver.
Signed-off-by: Gerd Hoffmann
---
hw/ps2.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/ps2.c b/hw/ps2.c
index 15a6650..f0b206a 100644
--- a/hw/ps2.c
+++ b/hw/ps2.c
@@ -185,6 +185,7 @@ static void ps2_rese
Hi,
This patch series adds support for keyboard led status tracking to qemu.
The first patch adds the infrastructure to set the led status and to
register notify callbacks. Patches #2 and #3 add support for the usb
and ps/2 keyboard drivers. Patch #4 makes vnc use the led notification
to impro
Hi,
+int caps, num;
I think it is clearer to use a bool.
bool caps = ledstate& QEMU_CAPS_LOCK_LED;
Indeed.
+if (vs->modifiers_state[0x3a] != caps) {
+vs->modifiers_state[0x3a] = caps;
modifiers_state type needs to go from uint8_t to bool. It simplifies
lots of !!
On 02/26/10 15:50, Markus Armbruster wrote:
Markus Armbruster (2):
qdev: Improve diagnostics for bad property values
qdev: Catch attempt to attach more than one device to a netdev
Looks good.
Acked-by: Gerd Hoffmann
cheers,
Gerd
On 02/26/2010 04:36 PM, Anthony Liguori wrote:
On 02/26/2010 02:47 AM, Avi Kivity wrote:
qcow2 is still not fully asynchronous. All the other format drivers
(except raw) are fully synchronous. If we had a threaded
infrastructure, we could convert them all in a day. As it is, you
can only us
On 02/26/2010 08:51 AM, Michael S. Tsirkin wrote:
On Thu, Feb 25, 2010 at 01:47:27PM -0600, Anthony Liguori wrote:
On 02/25/2010 12:28 PM, Michael S. Tsirkin wrote:
This adds vhost binary option to tap, to enable vhost net accelerator.
Default is off for now, we'll be able to make def
On 02/26/2010 08:49 AM, Michael S. Tsirkin wrote:
KVM code needs all kind of work-arounds for KVM specific issues.
It also assumes that KVM is registered at startup, so it
does not try to optimize finding slots.
No, the slot mapping changes dynamically so KVM certainly needs to
optimize t
On Fri, Feb 26, 2010 at 08:38:27AM -0600, Anthony Liguori wrote:
> On 02/26/2010 08:32 AM, Michael S. Tsirkin wrote:
>>> and
>>> --enable-vhost/--disable-vhost options.
>>>
>>>
>> I don't really see why we need --enable-vhost/--disable-vhost.
>> Runtime flag is enough.
>>
>
> So that pack
> Bug.
Ouch.
On Fri, Feb 26, 2010 at 03:50:49PM +0100, Markus Armbruster wrote:
> Markus Armbruster (2):
> qdev: Improve diagnostics for bad property values
> qdev: Catch attempt to attach more than one device to a netdev
>
> hw/qdev-properties.c | 64
> -
On Thu, Feb 25, 2010 at 01:47:27PM -0600, Anthony Liguori wrote:
> On 02/25/2010 12:28 PM, Michael S. Tsirkin wrote:
>> This adds vhost binary option to tap, to enable vhost net accelerator.
>> Default is off for now, we'll be able to make default on long term
>> when we know it's stable.
>>
>> vho
On Thu, Feb 25, 2010 at 01:44:34PM -0600, Anthony Liguori wrote:
> On 02/25/2010 12:28 PM, Michael S. Tsirkin wrote:
>> This adds vhost net device support in qemu. Will be tied to tap device
>> and virtio by following patches. Raw backend is currently missing,
>> will be worked on/submitted separa
Guest device and host netdev are peers, i.e. it's a 1:1 relation.
However, we fail to enforce that:
$ qemu -nodefaults --nographic -netdev user,id=net0 -device
e1000,netdev=net0 -device virtio-net-pci,netdev=net0 -monitor stdio
QEMU 0.12.50 monitor - type 'help' for more information
(
Property "vlan" reports "failed to parse" even when the value parses
just fine, but the result doesn't name an existing VLAN.
Similarly, properties "drive", "chr" and "netdev" misleadingly report
"failed to parse" when the value doesn't name an existing host device.
Change PropertyInfo method par
Markus Armbruster (2):
qdev: Improve diagnostics for bad property values
qdev: Catch attempt to attach more than one device to a netdev
hw/qdev-properties.c | 64 --
net.c|1 +
2 files changed, 42 insertions(+), 23 deletion
Gerd Hoffmann writes:
> On 02/26/10 10:30, Markus Armbruster wrote:
>> This made a lot of sense if each parser threw largely different errors.
>> Which isn't the case: we have one so far ("failed to parse"), and we
>> just encountered a use for a second.
>
> There are actually three: parse error
On 02/26/2010 08:32 AM, Michael S. Tsirkin wrote:
and
--enable-vhost/--disable-vhost options.
I don't really see why we need --enable-vhost/--disable-vhost.
Runtime flag is enough.
So that packagers can disable features at build time that they don't
want to support.
Regards,
Ant
On 02/26/2010 02:47 AM, Avi Kivity wrote:
qcow2 is still not fully asynchronous. All the other format drivers
(except raw) are fully synchronous. If we had a threaded
infrastructure, we could convert them all in a day. As it is, you can
only use the other block format drivers in 'qemu-img co
On Thu, Feb 25, 2010 at 08:04:21PM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" wrote:
> > This adds vhost net device support in qemu. Will be tied to tap device
> > and virtio by following patches. Raw backend is currently missing,
> > will be worked on/submitted separately.
> >
>
> +obj-
On 02/26/2010 12:30 PM, Paul Brook wrote:
Since b567b38 (target-arm: remove T0 and T1, 2009-10-16) the only global
register that is actually used is AREG0, so the complexity of
hostregs_helper.h is unwarranted.
Let's just say that env should be the only global register. AREG1 and
AREG2 in princ
When this was merged in qemu-kvm/master (commit
6249f61a891b6b003531ca4e459c3a553faa82bc) it removed Avi's compile fix when
!CONFIG_EVENTFD (db311e8619d310bd7729637b702581d3d8565049).
So current master fails to build:
CCosdep.o
cc1: warnings being treated as errors
osdep.c: In function 'qem
> Since b567b38 (target-arm: remove T0 and T1, 2009-10-16) the only global
> register that is actually used is AREG0, so the complexity of
> hostregs_helper.h is unwarranted.
>
> Let's just say that env should be the only global register. AREG1 and
> AREG2 in principle could still be used to work
Hi Amit,
On 25.02.2010, at 14:45, Amit Shah wrote:
> Hello,
>
> This series fixes a compile error and adds 0.12 and 0.13 machine
> types, disabling newer virtio-serial features for 0.12.
>
> Note: The name for the machine type changes from s390-virtio to
> s390-virtio-vXX, this may not be compa
On Thu, Feb 25, 2010 at 12:13:04PM -0300, Luiz Capitulino wrote:
>
> It's emitted whenever the watchdog device's timer expires. The action
> taken is provided in the 'data' member.
>
> Signed-off-by: Luiz Capitulino
> ---
> QMP/qmp-events.txt | 19 +++
> hw/watchdog.c |
On 02/26/10 10:30, Markus Armbruster wrote:
This made a lot of sense if each parser threw largely different errors.
Which isn't the case: we have one so far ("failed to parse"), and we
just encountered a use for a second.
There are actually three: parse error, not found
(netdev=) and busy (ne
Patch http://permalink.gmane.org/gmane.comp.emulators.qemu/63472 handle
close when using tty devices (like /dev/ttyS0),
yet tty based monitor are not restoring terminal attributes (as done
with stdio based monitor), when closing qemu after that command:
$ qemu -monitor /dev/tty
the terminal is no
Gerd Hoffmann writes:
> Hi,
>
>> Gerd, what do you think about changing the contract for property parse
>> methods to return -EINVAL, -EBUSY and such?
>
> Hmm, wouldn't it make more sense to integrate with qerror somehow?
Depends.
If you want to move error reporting from qdev_prop_parse() and
On 02/25/2010 09:55 PM, Anthony Liguori wrote:
On 02/25/2010 11:33 AM, Avi Kivity wrote:
On 02/25/2010 07:15 PM, Anthony Liguori wrote:
I agree. Further, once we fine-grain device threading, the
iothread essentially disappears and is replaced by device-specific
threads. There's no "idle" any
On Thu, Feb 25, 2010 at 01:25:46PM -0600, Anthony Liguori wrote:
> On 02/25/2010 12:27 PM, Michael S. Tsirkin wrote:
> >vhost needs physical addresses for ring and other queue fields,
> >so add APIs for these.
> >
> >Signed-off-by: Michael S. Tsirkin
> >---
> > hw/virtio.c | 50 +
Commit b5ec5ce0 broke 'make install' from non source-dir build. Fix.
Signed-off-by: Amit Shah
---
Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 296f500..14c1930 100644
--- a/Makefile
+++ b/Makefile
@@ -207,7 +207,7 @@ endif
instal
52 matches
Mail list logo
