Re: [Qemu-devel] [PATCH] use "%lld" instead of "%I64d" for qobject_from_jsonf in monitor.c and migration.c

2010-02-07 Thread Roy Tam
2010/2/8 TeLeMan : > The json parser does not support "%I64d", so we have to use "%lld" > instead of "%I64d". > We use PRId64 with json in more places besides migration.c and monitor.c, adding %I64d support in json lexer/parser is a better choice IMO. > Signed-off-by: TeLeMan > --- > migration.

[Qemu-devel] [PATCH] use "%lld" instead of "%I64d" for qobject_from_jsonf in monitor.c and migration.c

2010-02-07 Thread TeLeMan
The json parser does not support "%I64d", so we have to use "%lld" instead of "%I64d". Signed-off-by: TeLeMan --- migration.c |6 +++--- monitor.c |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration.c b/migration.c index f20315f..f44b857 100644 --- a/migra

[Qemu-devel] [PATCH] apb_pci: fix header type of pbm pci host bridge.

2010-02-07 Thread Isaku Yamahata
The change set of 776e1bbb6cf4fe66a93c1a5dd814bbb650deca00 specifies pbm pci host bridge is type of bridge. It contradicts with pbm_pci_host_init(). Blue Swirl, could you please check this patch? To be honest I don't know about pbm pci host bridge so that I don't know which is correct, pbm_pci_hos

[Qemu-devel] [PATCH] pci: initialize header type register.

2010-02-07 Thread Isaku Yamahata
initialize header type register in pci generic code. Cc: Blue Swirl Cc: "Michael S. Tsirkin" Signed-off-by: Isaku Yamahata --- hw/pci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index eb2043e..7b055b4 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -6

[Qemu-devel] [PATCH] pci: fix info pci with host bridge.

2010-02-07 Thread Isaku Yamahata
This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5. pci host bridge doesn't have header type of bridge. The check should be by header type, instead of pci class device. Cc: Blue Swirl Cc: "Michael S. Tsirkin" Signed-off-by: Isaku Yamahata --- hw/pci.c |6 +++--- 1 files changed, 3 i

[Qemu-devel] [PATCH] pci: fix pci_find_bus()

2010-02-07 Thread Isaku Yamahata
typo in c021f8e65f5009a5ab5711d9d5326fcab553ef1c. comparison fix. Cc: Blue Swirl Cc: "Michael S. Tsirkin" Signed-off-by: Isaku Yamahata --- hw/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 9ad63dd..e91d2e6 100644 --- a/hw/pci.c +++ b/

[Qemu-devel] Re: [PATCH] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-07 Thread OHMURA Kei
> Sounds logical - do you have numbers on the improvement? Sure. The patch showed approximately 3-7 times speed up when measured with rdtsc. The test environment and detailed results are described below. --- tmp = rdtsc(); /* function of original code*/ t1 += rdtsc() - tmp; tmp = rdtsc();

Re: [gPXE] [Qemu-devel] [RFC] gPXE fw_cfg file interface support

2010-02-07 Thread Shao Miller
Gerd Hoffmann wrote: ...Then you can easily have qemu guests netboot from somewhere without any local pxe/tftp setup, like this: qemu -fw-file gpxe/default=bko.gpxe That looks a bit like: # qemu -kernel gpxe.lkrn -initrd bko.gpxe -hda /dev/null which might be useful iff the *.lkrn build

[Qemu-devel] [PATCH] fix the static compilation for sdl

2010-02-07 Thread TeLeMan
The static compilation for sdl is broken after 79427693174a553d62f3da44aacd3f19ba8df3a7. Signed-off-by: TeLeMan --- configure |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 4c95c27..213dddf 100644 --- a/configure +++ b/configure @@ -106

Re: [Qemu-devel] [PATCH] rtl8139 timer interrupt rewrote

2010-02-07 Thread Igor Kovalenko
On Sun, Feb 7, 2010 at 6:22 PM, Frediano Ziglio wrote: > rewrote timer implementation for rtl8139. Add a QEMU > timer only when needed (timeout status not set, timeout irq wanted and > timer set). > > Signed-off-by: Frediano Ziglio > -- > diff --git a/hw/rtl8139.c b/hw/rtl8139.c > index f04dd54..

RE: [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address.

2010-02-07 Thread Zheng, Jiajia
Anthony Liguori wrote: > On 02/07/2010 10:31 AM, Avi Kivity wrote: >>> Only insofar as you don't have to deal with getting at the VM fd. >>> You can avoid the problem by having the kvm ioctl interface take a >>> pid or something. >> >> >> That's a racy interface. > > The mechanism itself is racy

Re: [Qemu-devel] [PATCH] User mode: Handle x86_64 vsyscall

2010-02-07 Thread Richard Henderson
On 02/06/2010 03:50 PM, Laurent Desnogues wrote: * target-i386 code should not have to know about linux vsyscall Given that we have to workaround 64-bit virtual address limitations (cf. Richard mail and previous discussions on the list), doing otherwise looks difficult. Actually, it should

Re: [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address.

2010-02-07 Thread Anthony Liguori
On 02/07/2010 10:31 AM, Avi Kivity wrote: Only insofar as you don't have to deal with getting at the VM fd. You can avoid the problem by having the kvm ioctl interface take a pid or something. That's a racy interface. The mechanism itself is racy. That said, pid's don't recycle very quic

Re: [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address.

2010-02-07 Thread Avi Kivity
On 02/07/2010 06:23 PM, Anthony Liguori wrote: On 02/07/2010 08:03 AM, Avi Kivity wrote: On 02/03/2010 06:14 PM, Anthony Liguori wrote: aren't we putting the cart before the horse here? qemu has support for triggering MCEs on the monitor. Also the KVM code base has support for forwarding the

Re: [Qemu-devel] [PATCH] Add assignment operation to config file parser..

2010-02-07 Thread Anthony Liguori
On 02/06/2010 12:59 PM, john cooper wrote: This patch reworks support for both assignment and append in the config file parser. It was motivated by comments received on the cpu model config file format. Commit dc9ca4ba27be4fe6a0284061b8f056c4364fb0d9 changed the behavior of "=" from assign to a

Re: [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address.

2010-02-07 Thread Anthony Liguori
On 02/07/2010 08:03 AM, Avi Kivity wrote: On 02/03/2010 06:14 PM, Anthony Liguori wrote: aren't we putting the cart before the horse here? qemu has support for triggering MCEs on the monitor. Also the KVM code base has support for forwarding the MCEs automatically. KVM has all of the inform

[Qemu-devel] [PATCH] rtl8139 timer interrupt rewrote

2010-02-07 Thread Frediano Ziglio
rewrote timer implementation for rtl8139. Add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). Signed-off-by: Frediano Ziglio -- diff --git a/hw/rtl8139.c b/hw/rtl8139.c index f04dd54..0d877b7 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -41,6 +41,10 @@

[Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Avi Kivity
On 02/07/2010 04:26 PM, Jan Kiszka wrote: Well, to me it makes more sense to name them from the point of view of the vcpu that is doing the update. I'm open for a better name - except for "sync" as writebacks are always synchronous from the POV of the modified VCPU. I meant that the st

[Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Jan Kiszka
Avi Kivity wrote: > On 02/07/2010 03:51 PM, Jan Kiszka wrote: >> Avi Kivity wrote: >> >>> On 02/03/2010 10:53 AM, Jan Kiszka wrote: >>> This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_

[Qemu-devel] [PATCH v3] block: more read-only changes, related to backing files

2010-02-07 Thread Naphtali Sprei
This version addresses comments by Kevin Wolf to v2 Also separate commits squashed. Open image file read-only where possible Upgrade file to read-write during commit, back to read-only after commit Added option for qemu-img.c bdrv_new_open() to open file as read-only qemu-img changes based on p

Re: [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address.

2010-02-07 Thread Avi Kivity
On 02/03/2010 06:14 PM, Anthony Liguori wrote: aren't we putting the cart before the horse here? qemu has support for triggering MCEs on the monitor. Also the KVM code base has support for forwarding the MCEs automatically. KVM has all of the information you need (guest physical -> host phy

[Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Avi Kivity
On 02/07/2010 03:51 PM, Jan Kiszka wrote: Avi Kivity wrote: On 02/03/2010 10:53 AM, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (i

[Qemu-devel] Re: [PATCH v2 01/21] qemu-kvm: Drop vmport changes

2010-02-07 Thread Jan Kiszka
Avi Kivity wrote: > On 02/03/2010 10:53 AM, Jan Kiszka wrote: >> This attempt to make vmport KVM compatible is half-broken and is >> scheduled to be replaced by proper upstream support. >> > > Does "scheduled" mean you have patches for adding > cpu_synchronize_state() to vmport? See patch 2 i

[Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Jan Kiszka
Avi Kivity wrote: > On 02/03/2010 10:53 AM, Jan Kiszka wrote: >> This grand cleanup drops all reset and vmsave/load related >> synchronization points in favor of four(!) generic hooks: >> >> - cpu_synchronize_all_states in qemu_savevm_state_complete >>(initial sync from kernel before vmsave) >>

[Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Avi Kivity
On 02/03/2010 10:53 AM, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) - cpu_synchronize_all_post_init in

Re: [Qemu-devel] Updated rtl8139 timer interrupt rewrote

2010-02-07 Thread Roy Tam
2010/2/7 Frediano Ziglio : > Hi, > I rewrote timer implementation for this card. I wrote even a small > Linux guest test program (attached as main.c). This patch add a QEMU > timer only when needed (timeout status not set, timeout irq wanted and > timer set). I tested this patch with a Darwin syst

[Qemu-devel] Re: [PATCH v2 01/21] qemu-kvm: Drop vmport changes

2010-02-07 Thread Avi Kivity
On 02/03/2010 10:53 AM, Jan Kiszka wrote: This attempt to make vmport KVM compatible is half-broken and is scheduled to be replaced by proper upstream support. Does "scheduled" mean you have patches for adding cpu_synchronize_state() to vmport? -- error compiling committee.c: too many ar

Re: [Qemu-devel] [PATCH 4/4] target-arm: neon fix

2010-02-07 Thread Laurent Desnogues
On Sun, Feb 7, 2010 at 1:54 PM, Laurent Desnogues wrote: > On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio wrote: >> From: Juha Riihimäki >> >> add an extra check in "two registers and a shift" to ensure element >> size decoding logic cannot fail. >> >> Signed-off-by: Juha Riihimäki >> Signed-off-b

Re: [Qemu-devel] [PATCH 4/4] target-arm: neon fix

2010-02-07 Thread Laurent Desnogues
On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio wrote: > From: Juha Riihimäki > > add an extra check in "two registers and a shift" to ensure element > size decoding logic cannot fail. > > Signed-off-by: Juha Riihimäki > Signed-off-by: Riku Voipio > --- >  target-arm/translate.c |    3 ++- >  1 fil

Re: [Qemu-devel] [PATCH 2/4] target-arm: neon vshll instruction fix

2010-02-07 Thread Laurent Desnogues
On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio wrote: > From: Juha Riihimäki > > implementation only widened the 32bit source vector elements into a > 64bit destination vector but forgot to perform the actual shifting > operation. > > Signed-off-by: Juha Riihimäki > Signed-off-by: Riku Voipio Ack

Re: [Qemu-devel] [PATCH 1/4] target-arm: neon - fix VRADDHN/VRSUBHN vs VADDHN/VSUBHN

2010-02-07 Thread Laurent Desnogues
On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio wrote: > From: Riku Voipio > > The rounding/truncating options were inverted. truncating > was done when rounding was meant and vice verse. > > Signed-off-by: Riku Voipio Acked-by: Laurent Desnogues Laurent > --- >  target-arm/translate.c |    4 +

[Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code

2010-02-07 Thread Gleb Natapov
On Sun, Feb 07, 2010 at 12:28:49PM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote: > >> This version addresses the feedback on v2, namely: > >> - assert( || thread>) on low-level > >> load/save registers > >> - fixed mpstate initializ

[Qemu-devel] Updated rtl8139 timer interrupt rewrote

2010-02-07 Thread Frediano Ziglio
Hi, I rewrote timer implementation for this card. I wrote even a small Linux guest test program (attached as main.c). This patch add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). I tested this patch with a Darwin system and with my test program (I bough

[Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code

2010-02-07 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote: >> This version addresses the feedback on v2, namely: >> - assert( || thread>) on low-level >> load/save registers >> - fixed mpstate initialization >> > With those patched, doing "info cpus" in monitor kill the gue

Re: [Qemu-devel] [PATCH] User mode: Handle x86_64 vsyscall

2010-02-07 Thread Laurent Desnogues
On Sun, Feb 7, 2010 at 1:22 AM, Jamie Lokier wrote: [...] >> >> How would you achieve that?  Your guest OS >> doesn't necessarily have the code mapped.  I >> think this has to be considered as other syscalls, >> though slightly different. > > There is no guest OS when doing -user emulation. > Only

[Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code

2010-02-07 Thread Gleb Natapov
On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote: > This version addresses the feedback on v2, namely: > - assert( || thread>) on low-level > load/save registers > - fixed mpstate initialization > With those patched, doing "info cpus" in monitor kill the guest, which, unfortunately, me