Re: [Qemu-devel] Adding support for MIPS64 as host

2010-02-04 Thread pinery
於 四,2010-02-04 於 22:56 +0530,Utkarsh Sopan 提到: > > Can you tell me what is the status of adding MIPS64 support? > as at the wiki page it showed Red earlier. > On Wed, Feb 3, 2010 at 10:29 PM, Laurent Desnogues > wrote: > On Wed, Feb 3, 2010 at 5:53 PM, Utkarsh Sopan > wrote: >

[Qemu-devel] kqemu and XP guest - lock-up at mup.sys

2010-02-04 Thread Gordan Bobic
Hi, It would appear that kqemu somehow breaks the XP guest under some circumstances. If I install from scratch in qemu+kqemu, it works fine in kqemu, but not on bare metal. The fact it doesn't work on bare metal COULD be related to the fact that on bare metal I'm running off a USB stick (it'

Re: [Qemu-devel] [PATCH v2 resend 0/4] block: more read-only changes, related to backing files

2010-02-04 Thread Sheng Yang
On Friday 05 February 2010 06:04:25 Naphtali Sprei wrote: > This is version 2. The change between previous patch (only 3/4) is the > order of closing/re-opening the image. > > Naphtali Sprei (4): > Add open_flags to BlockDriverState Will be used later > qemu-img: Fix qemu-img can't create qco

Re: [Qemu-devel] [PATCH v2 resend 2/4] qemu-img: Fix qemu-img can't create qcow image based on read-only image

2010-02-04 Thread Sheng Yang
On Friday 05 February 2010 06:04:27 Naphtali Sprei wrote: > Open image file read-only where possible > Patch originally written by Sheng Yang > Signed-off-by: Sheng Yang > Signed-off-by: Naphtali Sprei -- regards Yang, Sheng > --- > qemu-img.c | 15 ++- > 1 files changed, 10

[Qemu-devel] Re: [PATCH 0/4] Fix printf calls embedding preprocessor directives

2010-02-04 Thread Sheng Yang
On Thursday 04 February 2010 23:49:55 Paolo Bonzini wrote: > Patch 1 is the same I sent earlier. Patches 2 and 3/4 fix the > other two problems by Sheng (tip: next time use "make -k" and > report all problems in a single message). > > Paolo Bonzini (4): > qemu-img: avoid preprocessor directives

RE: [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address.

2010-02-04 Thread Zheng, Jiajia
Hi, Anthony Anthony Liguori wrote: > On 02/03/2010 09:49 AM, Kleen, Andi wrote: >> >>> Yeah, but if we put a feature in qemu, we need to be able to >>> support it for anyone who wants to use it. >>> >> It's useful for anyone who wants to use it for testing purposes. >> And it's useful to make sur

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-04 Thread Anthony Liguori
On 02/04/2010 02:13 PM, Luiz Capitulino wrote: Add an assert() to qobject_from_jsonf() to assure that the returned QObject is not NULL. Currently this is duplicated in the callers. Signed-off-by: Luiz Capitulino --- qjson.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH] User mode: Handle x86_64 vsyscall

2010-02-04 Thread Stefan Weil
Laurent Desnogues schrieb: > On Sun, Oct 18, 2009 at 5:09 AM, Jamie Lokier wrote: > [...] >> Please don't do that. Some code traces instructions through the >> vsyscall/vdso page, and will be surprised if a syscall instruction >> does not do what's expected based on the registers at that point. >

[Qemu-devel] [PATCH v2 resend 2/4] qemu-img: Fix qemu-img can't create qcow image based on read-only image

2010-02-04 Thread Naphtali Sprei
Open image file read-only where possible Patch originally written by Sheng Yang Signed-off-by: Naphtali Sprei --- qemu-img.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index cbba4fc..b0ac9eb 100644 --- a/qemu-img.c +++ b/qemu-

[Qemu-devel] [PATCH v2 resend 3/4] Block: readonly changes

2010-02-04 Thread Naphtali Sprei
Open backing file for read-only During commit upgrade to read-write and back at end to read-only Signed-off-by: Naphtali Sprei --- block.c | 68 --- block_int.h |1 + 2 files changed, 61 insertions(+), 8 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 resend 4/4] Open backing file read-only also for snapshot mode

2010-02-04 Thread Naphtali Sprei
Signed-off-by: Naphtali Sprei --- block.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/block.c b/block.c index 4a9df91..780cea9 100644 --- a/block.c +++ b/block.c @@ -483,19 +483,11 @@ int bdrv_open2(BlockDriverState *bs, const char *filename, int flags,

[Qemu-devel] [PATCH v2 resend 1/4] Add open_flags to BlockDriverState Will be used later

2010-02-04 Thread Naphtali Sprei
Signed-off-by: Naphtali Sprei --- block.c |1 + block_int.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 1919d19..66564de 100644 --- a/block.c +++ b/block.c @@ -363,6 +363,7 @@ int bdrv_open2(BlockDriverState *bs, const char *filename,

[Qemu-devel] [PATCH v2 resend 0/4] block: more read-only changes, related to backing files

2010-02-04 Thread Naphtali Sprei
This is version 2. The change between previous patch (only 3/4) is the order of closing/re-opening the image. Naphtali Sprei (4): Add open_flags to BlockDriverState Will be used later qemu-img: Fix qemu-img can't create qcow image based on read-only image Block: readonly changes Open

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-04 Thread Marcelo Tosatti
On Thu, Feb 04, 2010 at 08:21:08PM +0100, Jan Kiszka wrote: > Jan Kiszka wrote: > > Marcelo Tosatti wrote: > >> With kvm-autotest the failure is not sporadic (and the above commit > >> applied): with KVM_SET_GUEST_DEBUG in arch_put_regs all migration > >> tests fail, without, all of them succeed.

[Qemu-devel] [PATCH 3/4] QError: Don't abort on multiple faults

2010-02-04 Thread Luiz Capitulino
Ideally, Monitor code should report an error only once and return the error information up the call chain. To assure that this happens as expected and that no error is lost, we have an assert() in qemu_error_internal(). However, we still have not fully converted handlers using monitor_printf() to

[Qemu-devel] [PATCH v0 0/4]: QMP related fixes

2010-02-04 Thread Luiz Capitulino
Should be applied on top of feature negotiation series. Thanks.

[Qemu-devel] [PATCH 2/4] Monitor: remove unneeded checks

2010-02-04 Thread Luiz Capitulino
It's not needed to check the return of qobject_from_jsonf() anymore, as an assert() has been added there. Signed-off-by: Luiz Capitulino --- block.c |3 --- hw/pci-hotplug.c |1 - migration.c |3 --- monitor.c|5 - 4 files changed, 0 insertions(+), 12 de

[Qemu-devel] [PATCH 4/4] QMP: Don't leak on connection close

2010-02-04 Thread Luiz Capitulino
QMP's chardev event callback doesn't call json_message_parser_destroy() on CHR_EVENT_CLOSED. As the call to json_message_parser_init() on CHR_EVENT_OPENED allocates memory, we'are leaking on close. Fix that by just calling json_message_parser_destroy() on CHR_EVENT_CLOSED. Signed-off-by: Luiz Cap

[Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-04 Thread Luiz Capitulino
Add an assert() to qobject_from_jsonf() to assure that the returned QObject is not NULL. Currently this is duplicated in the callers. Signed-off-by: Luiz Capitulino --- qjson.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qjson.c b/qjson.c index 9ad8a91..0922c06 10064

[Qemu-devel] [PATCH 4/4] QMP: spec: Capability negotiation updates

2010-02-04 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- QMP/qmp-spec.txt | 46 +- 1 files changed, 29 insertions(+), 17 deletions(-) diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt index b2617bb..f3c0327 100644 --- a/QMP/qmp-spec.txt +++ b/QMP/qmp-spec.txt @@ -44,7 +44,

[Qemu-devel] [PATCH 3/4] QMP: Enforce capability negotiation rules

2010-02-04 Thread Luiz Capitulino
With this commit QMP will be started in Capabilities Negotiation mode, where the only command allowed to run is 'qmp_capabilities'. All other commands will return CommandNotFound error. Asynchronous messages are not delivered either. When 'qmp_capabilities' is successfully executed QMP enters in

[Qemu-devel] [PATCH 2/4] QMP: Introduce the qmp_capabilities command

2010-02-04 Thread Luiz Capitulino
This command will be used to enable QMP capabilities advertised by the capabilities array. Note that it will be mandatory to issue this command in order to make QMP functional (although this behavior is not being enforced by this commit). Also, as we don't have any capabilities yet, the new comma

[Qemu-devel] [PATCH 1/4] QMP: Add QEMU's version to the greeting message

2010-02-04 Thread Luiz Capitulino
With capability negotiation support clients will only have a chance to check QEMU's version (ie. issue 'query-version') after the negotiation procedure is done. It might be useful to clients to check QEMU's version before negotiating features, though. To allow that, this commit adds the QEMU's ve

[Qemu-devel] [PATCH v2 0/4]: QMP capability negotiation support

2010-02-04 Thread Luiz Capitulino
Capability negotiation allows clients to enable new QMP capabilities they support and thus allows QMP to evolve in a compatible way. This series implements Markus's design and is a revamp of the previous one. It's very simple now, as mode-oriented support has been dropped. I've maintained the sa

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-04 Thread Jan Kiszka
Jan Kiszka wrote: > Marcelo Tosatti wrote: >> With kvm-autotest the failure is not sporadic (and the above commit >> applied): with KVM_SET_GUEST_DEBUG in arch_put_regs all migration >> tests fail, without, all of them succeed. >> >> So env->kvm_guest_debug has been zeroed by cpu_x86_init, which

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-04 Thread Jan Kiszka
Jan Kiszka wrote: > Marcelo Tosatti wrote: >> >> Unrelated to this problem, won't put_vcpu_events, which is executed >> after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions? > > Good point, SET_GUEST_DEBUG should be last in the writeback for that reason. Actually, we no longer need t

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-04 Thread Jan Kiszka
Marcelo Tosatti wrote: > On Thu, Feb 04, 2010 at 04:41:44PM +0100, Jan Kiszka wrote: >> Jan Kiszka wrote: >>> Marcelo Tosatti wrote: On Thu, Feb 04, 2010 at 01:33:50AM +0100, Jan Kiszka wrote: > Marcelo Tosatti wrote: >> On Wed, Feb 03, 2010 at 10:29:45PM +0100, Jan Kiszka wrote: >

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-04 Thread Marcelo Tosatti
On Thu, Feb 04, 2010 at 04:41:44PM +0100, Jan Kiszka wrote: > Jan Kiszka wrote: > > Marcelo Tosatti wrote: > >> On Thu, Feb 04, 2010 at 01:33:50AM +0100, Jan Kiszka wrote: > >>> Marcelo Tosatti wrote: > On Wed, Feb 03, 2010 at 10:29:45PM +0100, Jan Kiszka wrote: > > So far we synchronized

Re: [Qemu-devel] Converting existing name=value,... arguments to QMP

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 06:43:22PM +0100, Markus Armbruster wrote: > The human monitor uses positional arguments. This is fine; nobody wants > to type "info item=network" instead of "info network". > > QMP uses named arguments. Also fine. > > Internally, we use named arguments: we pass them as

Re: [Qemu-devel] "Enable _FORTIFY_SOURCE=2" result in building failure for qemu-img.c

2010-02-04 Thread Markus Armbruster
Jamie Lokier writes: > Sheng Yang wrote: >> printf("qemu-img version " QEMU_VERSION ", Copyright (c) 2004-2008 >> Fabrice >> Bellard\n" >>"usage: qemu-img command [command options]\n" >>"QEMU disk image utility\n" >>"\n" >>"Command syntax:\n"

[Qemu-devel] Converting existing name=value,... arguments to QMP

2010-02-04 Thread Markus Armbruster
The human monitor uses positional arguments. This is fine; nobody wants to type "info item=network" instead of "info network". QMP uses named arguments. Also fine. Internally, we use named arguments: we pass them as QDict to the command handler. This involves associating positional arguments w

Re: [Qemu-devel] Adding support for MIPS64 as host

2010-02-04 Thread Laurent Desnogues
On Thu, Feb 4, 2010 at 6:26 PM, Utkarsh Sopan wrote: > > Can you tell me what is the status of adding MIPS64 support? > as at the wiki page it showed Red earlier. Look here: http://git.aurel32.net/?p=qemu.git;a=summary Laurent

Re: [Qemu-devel] Adding support for MIPS64 as host

2010-02-04 Thread Utkarsh Sopan
Can you tell me what is the status of adding MIPS64 support? as at the wiki page it showed Red earlier. On Wed, Feb 3, 2010 at 10:29 PM, Laurent Desnogues < laurent.desnog...@gmail.com> wrote: > On Wed, Feb 3, 2010 at 5:53 PM, Utkarsh Sopan > wrote: > > I am trying to add support for MIPS 64 as H

Re: [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel] system_reset command cause assert failed)

2010-02-04 Thread Roy Tam
2010/2/4 Luiz Capitulino : > On Thu, 4 Feb 2010 10:30:30 +0800 > Roy Tam wrote: > >> 2010/2/4 Roy Tam : >> > 2010/2/3 Luiz Capitulino : >> >> OK we are fooled by the json lexer and parser. As we use %I64d to >> print 'long long' variables in Win32, but lexer and parser only deal >> with %lld but n

Re: [Qemu-devel] [PATCH v1 0/4]: QMP capability negotiation support

2010-02-04 Thread Markus Armbruster
Luiz Capitulino writes: > Capability negotiation allows clients to enable new QMP capabilities they > support and thus allows QMP to evolve in a compatible way. > > This series implements Markus's design and is a revamp of the previous > one. It's very simple now, as mode-oriented support has b

Re: [Qemu-devel] [PATCH 2/4] QMP: Introduce the qmp_capabilities command

2010-02-04 Thread Markus Armbruster
Luiz Capitulino writes: > This command will be used to enable QMP capabilities advertised > by the capabilities array. > > Note that it will be mandatory to issue this command in order > to make QMP functional (although this behavior is not being > enforced yet). The next commit enforces it. >

Re: [Qemu-devel] [PATCH 1/4] QMP: Add QEMU's version to the greeting message

2010-02-04 Thread Markus Armbruster
Luiz Capitulino writes: > With capability negotiation support clients will only have a chance > to check QEMU's version (ie. issue 'query-version') after the > negotiation procedure is done. > > It might be useful to clients to check QEMU's version before > negotiating features, though. > > To al

[Qemu-devel] [PATCH 4/4] vl.c: avoid preprocessor directives in a printf call

2010-02-04 Thread Paolo Bonzini
Similar to the qemu-img.c patch, but I also have to unescape remaining % signs in qemu-options.hx. Signed-off-by: Paolo Bonzini --- qemu-options.hx |4 ++-- vl.c| 18 ++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/qemu-options.hx b/qemu-opti

[Qemu-devel] [PATCH 3/4] do not interpolate % from vl.c to qemu-options.h

2010-02-04 Thread Paolo Bonzini
Since qemu-options.h is only used in vl.c, we can avoid using brittle interpolation from a generated file. Signed-off-by: Paolo Bonzini --- qemu-options.hx | 11 ++- vl.c|9 + 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/qemu-options.hx b/qemu

[Qemu-devel] [PATCH 2/4] cope with printf macro definition in readline.c

2010-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- readline.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/readline.c b/readline.c index 7834af0..92f9cd1 100644 --- a/readline.c +++ b/readline.c @@ -28,6 +28,7 @@ #define IS_ESC 1 #define IS_CSI 2 +#undef printf #define printf do_

[Qemu-devel] [PATCH 1/4] qemu-img: avoid preprocessor directives in a printf call

2010-02-04 Thread Paolo Bonzini
Other choices include using "(printf)", but this one is not bad in terms of readability. Signed-off-by: Paolo Bonzini --- qemu-img.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index cbba4fc..eb5c0f0 100644 --- a/qemu-img.c +++ b/qemu-

[Qemu-devel] [PATCH 0/4] Fix printf calls embedding preprocessor directives

2010-02-04 Thread Paolo Bonzini
Patch 1 is the same I sent earlier. Patches 2 and 3/4 fix the other two problems by Sheng (tip: next time use "make -k" and report all problems in a single message). Paolo Bonzini (4): qemu-img: avoid preprocessor directives in a printf call cope with printf macro definition in readline.c d

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-04 Thread Jan Kiszka
Jan Kiszka wrote: > Marcelo Tosatti wrote: >> On Thu, Feb 04, 2010 at 01:33:50AM +0100, Jan Kiszka wrote: >>> Marcelo Tosatti wrote: On Wed, Feb 03, 2010 at 10:29:45PM +0100, Jan Kiszka wrote: > So far we synchronized any dirty VCPU state back into the kernel before > updating the gues

[Qemu-devel] Re: [PATCH] qemu-img: avoid preprocessor directives in a printf call

2010-02-04 Thread Sheng Yang
On Thursday 04 February 2010 21:29:40 Paolo Bonzini wrote: > Other choices include using "(printf)", but this one is not bad in > terms of readability. This works well. :) Acked-by: Sheng Yang > > Signed-off-by: Paolo Bonzini And there is two more... One is: readline.c:31:1: error: "printf"

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-04 Thread Jan Kiszka
Marcelo Tosatti wrote: > On Thu, Feb 04, 2010 at 01:33:50AM +0100, Jan Kiszka wrote: >> Marcelo Tosatti wrote: >>> On Wed, Feb 03, 2010 at 10:29:45PM +0100, Jan Kiszka wrote: So far we synchronized any dirty VCPU state back into the kernel before updating the guest debug state. This was a

[Qemu-devel] MIPS(EL) broken on i386 Linux host?

2010-02-04 Thread Dirk Ullrich
Hi, I have a problem running a MIPS(EL) guest on a i386 linux host (actually, on Debian testing with a 2.6.32 kernel) when using the current Git master code for QEMU (compiled at the same Debian host). The MIPS(EL) guests I have tried are those provided http://people.debian.org/~aurel32/qemu/mips

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-04 Thread Marcelo Tosatti
On Thu, Feb 04, 2010 at 01:33:50AM +0100, Jan Kiszka wrote: > Marcelo Tosatti wrote: > > On Wed, Feb 03, 2010 at 10:29:45PM +0100, Jan Kiszka wrote: > >> So far we synchronized any dirty VCPU state back into the kernel before > >> updating the guest debug state. This was a tribute to a deficit in x

[Qemu-devel] [PATCH v2 2/4] qemu-img: Fix qemu-img can't create qcow image based on read-only image

2010-02-04 Thread Naphtali Sprei
Open image file read-only where possible Patch originally written by Sheng Yang Signed-off-by: Naphtali Sprei --- qemu-img.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index cbba4fc..b0ac9eb 100644 --- a/qemu-img.c +++ b/qemu-

[Qemu-devel] [PATCH] vnc: Migrate to using QTAILQ instead of custom implementation

2010-02-04 Thread Amit Shah
Just a 1-1 conversion for now. Signed-off-by: Amit Shah --- vnc.c | 73 - vnc.h |5 ++- 2 files changed, 30 insertions(+), 48 deletions(-) diff --git a/vnc.c b/vnc.c index 92facde..16fc4e9 100644 --- a/vnc.c +++ b/vnc.c @@ -3

[Qemu-devel] [PATCH] kvm: reduce code duplication in config_iothread

2010-02-04 Thread Amit Shah
We have some duplicated code in the CONFIG_IOTHREAD #ifdef and #else cases. Fix that. Signed-off-by: Amit Shah --- kvm-all.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 15ec38e..a2bd78e 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -90

[Qemu-devel] [PATCH 4/4] QMP: spec: Capability negotiation updates

2010-02-04 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- QMP/qmp-spec.txt | 46 +- 1 files changed, 29 insertions(+), 17 deletions(-) diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt index b2617bb..f3c0327 100644 --- a/QMP/qmp-spec.txt +++ b/QMP/qmp-spec.txt @@ -44,7 +44,

[Qemu-devel] [PATCH v1 0/4]: QMP capability negotiation support

2010-02-04 Thread Luiz Capitulino
Capability negotiation allows clients to enable new QMP capabilities they support and thus allows QMP to evolve in a compatible way. This series implements Markus's design and is a revamp of the previous one. It's very simple now, as mode-oriented support has been dropped. I've maintained the sa

[Qemu-devel] [PATCH 3/4] QMP: Enforce capability negotiation rules

2010-02-04 Thread Luiz Capitulino
With this commit QMP will be started in Capabilities Negotiation mode, where the only command allowed to run is 'qmp_capabilities'. All other commands will return CommandNotFound error. Asynchronous messages are not delivered either. When 'qmp_capabilities' is successfully executed QMP enters in

[Qemu-devel] [PATCH 2/4] QMP: Introduce the qmp_capabilities command

2010-02-04 Thread Luiz Capitulino
This command will be used to enable QMP capabilities advertised by the capabilities array. Note that it will be mandatory to issue this command in order to make QMP functional (although this behavior is not being enforced yet). Also, as we don't have any capabilities yet, the new command doesn't

[Qemu-devel] [PATCH 1/4] QMP: Add QEMU's version to the greeting message

2010-02-04 Thread Luiz Capitulino
With capability negotiation support clients will only have a chance to check QEMU's version (ie. issue 'query-version') after the negotiation procedure is done. It might be useful to clients to check QEMU's version before negotiating features, though. To allow that, this commit adds the QEMU's ve

Re: [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel] system_reset command cause assert failed)

2010-02-04 Thread Luiz Capitulino
On Thu, 4 Feb 2010 10:30:30 +0800 Roy Tam wrote: > 2010/2/4 Roy Tam : > > 2010/2/3 Luiz Capitulino : > > OK we are fooled by the json lexer and parser. As we use %I64d to > print 'long long' variables in Win32, but lexer and parser only deal > with %lld but not %I64d, this patch add support for

Re: [Qemu-devel] Need QEMU source and documentation

2010-02-04 Thread Anthony Liguori
On 02/04/2010 02:18 AM, Taimoor Mirza wrote: Hi all, I need QEMU source and documentation but qemu.org is down. Is there any other place from where I can get both source and documentation? It's back again. It wasn't actually down. qemu.org runs in a qemu virtual machine with kvm accelera

[Qemu-devel] Re: [PATCH v2 0/4] block: more read-only changes, related to backing files

2010-02-04 Thread Naphtali Sprei
Naphtali Sprei wrote: > This is version 2. The change between previous patch (only 3/4) is the order > of closing/re-opening the image. Sorry, patch sent without the change of version 2 (in 3/4). Will send later. Naphtali

[Qemu-devel] [PATCH v2 4/4] Open backing file read-only also for snapshot mode

2010-02-04 Thread Naphtali Sprei
Signed-off-by: Naphtali Sprei --- block.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/block.c b/block.c index 527b146..1db9961 100644 --- a/block.c +++ b/block.c @@ -483,19 +483,11 @@ int bdrv_open2(BlockDriverState *bs, const char *filename, int flags,

[Qemu-devel] [PATCH v2 3/4] Block: readonly changes

2010-02-04 Thread Naphtali Sprei
Open backing file for read-only During commit upgrade to read-write and back at end to read-only Signed-off-by: Naphtali Sprei --- block.c | 64 +++--- block_int.h |1 + 2 files changed, 57 insertions(+), 8 deletions(-) diff --git a/

[Qemu-devel] [PATCH v2 1/4] Add open_flags to BlockDriverState Will be used later

2010-02-04 Thread Naphtali Sprei
Signed-off-by: Naphtali Sprei --- block.c |1 + block_int.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 1919d19..66564de 100644 --- a/block.c +++ b/block.c @@ -363,6 +363,7 @@ int bdrv_open2(BlockDriverState *bs, const char *filename,

[Qemu-devel] [PATCH v2 0/4] block: more read-only changes, related to backing files

2010-02-04 Thread Naphtali Sprei
This is version 2. The change between previous patch (only 3/4) is the order of closing/re-opening the image. The read-only changes broke qemu-img create with read-only base image These changes fix it. It also make things a little safer, opening the backing file for read-only, upgrading to read-w

[Qemu-devel] [PATCH v2 2/4] qemu-img: Fix qemu-img can't create qcow image based on read-only image

2010-02-04 Thread Naphtali Sprei
Open image file read-only where possible Patch originally written by Sheng Yang Signed-off-by: Naphtali Sprei --- qemu-img.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index cbba4fc..b0ac9eb 100644 --- a/qemu-img.c +++ b/qemu-

[Qemu-devel] [PATCH v2 RESEND 4/5] vnc.c: remove dead code

2010-02-04 Thread Paolo Bonzini
to= is handled in qemu-sockets.c inet_listen. Signed-off-by: Paolo Bonzini --- vnc.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/vnc.c b/vnc.c index 92facde..a49cff2 100644 --- a/vnc.c +++ b/vnc.c @@ -2537,7 +2537,6 @@ int vnc_display_open(DisplayState *ds, const c

[Qemu-devel] [PATCH v2 RESEND 5/5] usb-linux.c: remove write-only variable

2010-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- usb-linux.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 1aaa595..ba8facf 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -1007,11 +1007,9 @@ USBDevice *usb_host_device_open(const char *devname) { st

[Qemu-devel] [PATCH v2 RESEND 0/5] clang fixes

2010-02-04 Thread Paolo Bonzini
I removed the patch that malc NACKed. Paolo Bonzini (5): remove two dead assignments in target-i386/translate.c fix undefined shifts by >32 exec.c: dead assignments vnc.c: remove dead code usb-linux.c: remove write-only variable exec.c |4 target-i386/translat

[Qemu-devel] [PATCH v2 RESEND 3/5] exec.c: dead assignments

2010-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- exec.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index 76831a1..b2a1cf1 100644 --- a/exec.c +++ b/exec.c @@ -2489,17 +2489,13 @@ void *qemu_get_ram_ptr(ram_addr_t addr) ram_addr_t qemu_ram_addr_from_host(void *ptr

[Qemu-devel] [PATCH v2 RESEND 2/5] fix undefined shifts by >32

2010-02-04 Thread Paolo Bonzini
This one is for 0.12 too. Signed-off-by: Paolo Bonzini --- vl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 39833fc..ea9a95c 100644 --- a/vl.c +++ b/vl.c @@ -2380,9 +2380,9 @@ static void numa_add(const char *optarg) fpri

[Qemu-devel] [PATCH v2 RESEND 1/5] remove two dead assignments in target-i386/translate.c

2010-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-i386/translate.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 8078112..a597e80 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -4692,8 +4692,6 @@ stat

[Qemu-devel] [PATCH] qemu-img: avoid preprocessor directives in a printf call

2010-02-04 Thread Paolo Bonzini
Other choices include using "(printf)", but this one is not bad in terms of readability. Signed-off-by: Paolo Bonzini --- qemu-img.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index cbba4fc..eb5c0f0 100644 --- a/qemu-img.c +++ b/qemu-

[Qemu-devel] [PATCH 15/15] virtio-net: vhost net support

2010-02-04 Thread Michael S. Tsirkin
This connects virtio-net to vhost net backend. The code is structured in a way analogous to what we have with vnet header capability in tap. We start/stop backend on driver start/stop as well as on save and vm start (for migration). Signed-off-by: Michael S. Tsirkin --- hw/virtio-net.c | 67 +

[Qemu-devel] [PATCH 14/15] tap: add API to retrieve vhost net header

2010-02-04 Thread Michael S. Tsirkin
will be used by virtio-net for vhost net support Signed-off-by: Michael S. Tsirkin --- net/tap.c |7 +++ net/tap.h |3 +++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index d9f2e41..166cf05 100644 --- a/net/tap.c +++ b/net/tap.c @@ -491,3 +49

[Qemu-devel] [PATCH 13/15] tap: add vhost/vhostfd options

2010-02-04 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- net.c |8 net/tap.c | 29 + qemu-options.hx |4 +++- 3 files changed, 40 insertions(+), 1 deletions(-) diff --git a/net.c b/net.c index 6ef93e6..b942d03 100644 --- a/net.c +++ b/net.c @@ -976,6 +

[Qemu-devel] [PATCH 12/15] vhost: vhost net support

2010-02-04 Thread Michael S. Tsirkin
This adds vhost net support in qemu. Will be tied to tap device and virtio by following patches. Raw backend is currently missing, will be worked on/submitted separately. Signed-off-by: Michael S. Tsirkin --- Makefile.target |1 + hw/vhost.c | 603 +

[Qemu-devel] [PATCH 11/15] tap: add interface to get device fd

2010-02-04 Thread Michael S. Tsirkin
Will be used by vhost to attach/detach to backend. Signed-off-by: Michael S. Tsirkin --- net/tap.c |7 +++ net/tap.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index d3492de..7e9ca79 100644 --- a/net/tap.c +++ b/net/tap.c @@ -269,6 +26

[Qemu-devel] [PATCH 10/15] virtio-pci: fill in notifier support

2010-02-04 Thread Michael S. Tsirkin
Support host/guest notifiers in virtio-pci. The last one only with kvm, that's okay because vhost relies on kvm anyway. Signed-off-by: Michael S. Tsirkin --- hw/virtio-pci.c | 62 +++ 1 files changed, 62 insertions(+), 0 deletions(-) diff --

[Qemu-devel] [PATCH 09/15] virtio: move typedef to qemu-common

2010-02-04 Thread Michael S. Tsirkin
make it possible to use type without header include Signed-off-by: Michael S. Tsirkin --- hw/virtio.h |1 - qemu-common.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio.h b/hw/virtio.h index 235e7c4..5dae591 100644 --- a/hw/virtio.h +++ b/hw/virtio.h @@

[Qemu-devel] [PATCH 08/15] virtio: add status change callback

2010-02-04 Thread Michael S. Tsirkin
vhost net backend needs to be notified when frontend status changes. Add a callback. Signed-off-by: Michael S. Tsirkin --- hw/s390-virtio-bus.c |3 +++ hw/syborg_virtio.c |2 ++ hw/virtio-pci.c |6 ++ hw/virtio.h |1 + 4 files changed, 12 insertions(+), 0 dele

[Qemu-devel] [PATCH 07/15] virtio: add APIs for queue fields

2010-02-04 Thread Michael S. Tsirkin
vhost needs physical addresses for ring and other queue fields, so add APIs for these. Signed-off-by: Michael S. Tsirkin --- hw/virtio.c | 51 +++ hw/virtio.h | 10 +- 2 files changed, 56 insertions(+), 5 deletions(-) diff --git a/hw/v

[Qemu-devel] [PATCH 06/15] virtio: add notifier support

2010-02-04 Thread Michael S. Tsirkin
Add binding API to set host/guest notifiers. Will be used by vhost. Signed-off-by: Michael S. Tsirkin --- hw/virtio.c | 13 ++--- hw/virtio.h |5 - 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 7c020a3..b9411e9 100644 --- a/hw/v

[Qemu-devel] [PATCH 05/15] notifier: event notifier implementation

2010-02-04 Thread Michael S. Tsirkin
event notifiers are slightly generalized eventfd descriptors. Current implementation depends on eventfd because vhost is the only user, and vhost depends on eventfd anyway, but a stub is provided for non-eventfd case. We'll be able to further generalize this when another user comes along and we se

[Qemu-devel] [PATCH 04/15] kvm: add API to set ioeventfd

2010-02-04 Thread Michael S. Tsirkin
This adds API to set ioeventfd to kvm, as well as stubs for non-eventfd case, making it possible for users to use this API without ifdefs. Signed-off-by: Michael S. Tsirkin --- kvm-all.c | 20 kvm.h | 16 2 files changed, 36 insertions(+), 0 deletion

[Qemu-devel] [PATCH 03/15] kvm: move kvm to use memory notifiers

2010-02-04 Thread Michael S. Tsirkin
remove direct kvm calls from exec.c, make kvm use memory notifiers framework instead. Signed-off-by: Michael S. Tsirkin Acked-by: Avi Kivity --- exec.c| 17 + kvm-all.c | 40 ++-- kvm.h |8 3 files changed, 35 insertio

[Qemu-devel] [PATCH 02/15] kvm: move kvm_set_phys_mem around

2010-02-04 Thread Michael S. Tsirkin
move kvm_set_phys_mem so that it will be later available earlier in the file. needed for next patch using memory notifiers. Signed-off-by: Michael S. Tsirkin Acked-by: Avi Kivity --- kvm-all.c | 276 ++-- 1 files changed, 138 insertions(+

[Qemu-devel] [PATCH 01/15] exec: memory notifiers

2010-02-04 Thread Michael S. Tsirkin
This adds notifiers for phys memory changes: a set of callbacks that vhost can register and update kernel accordingly. Down the road, kvm code can be switched to use these as well, instead of calling kvm code directly from exec.c as is done now. Signed-off-by: Michael S. Tsirkin --- cpu-common.

[Qemu-devel] [PATCH 00/15] vhost-net: preview

2010-02-04 Thread Michael S. Tsirkin
Here's a patchset with vhost support for upstream qemu. Note that irqchip/MSI is no longer required for vhost, but you should not expect performance gains from vhost unless in-kernel irqchip is enabled (which is not in upstream qemu now), and unless guest enables MSI. A follow-up patchset against

[Qemu-devel] Re: "Enable _FORTIFY_SOURCE=2" result in building failure for qemu-img.c

2010-02-04 Thread Juan Quintela
Sheng Yang wrote: > Got this building failure: > > In file included from qemu-img.c:68: > > > qemu-img-cmds.h:22:1: error: unterminated argument lis

Re: [Qemu-devel] "Enable _FORTIFY_SOURCE=2" result in building failure for qemu-img.c

2010-02-04 Thread Jamie Lokier
Sheng Yang wrote: > printf("qemu-img version " QEMU_VERSION ", Copyright (c) 2004-2008 > Fabrice > Bellard\n" >"usage: qemu-img command [command options]\n" >"QEMU disk image utility\n" >"\n" >"Command syntax:\n" > #define DEF(option, callback,

[Qemu-devel] Re: "Enable _FORTIFY_SOURCE=2" result in building failure for qemu-img.c

2010-02-04 Thread Paolo Bonzini
On 02/04/2010 08:04 AM, Sheng Yang wrote: Got this building failure: In file included from qemu-img.c:68: qemu-img-cmds.h:22:1: error: unterminated argument list invoking macro "printf" cc1: warnings being treated as errors qemu-img.c: In function ‘help’: qemu-img.c:95: warning: statement with n

Re: [Qemu-devel] [PATCH 3/4] Block: readonly changes

2010-02-04 Thread Kevin Wolf
Am 04.02.2010 10:36, schrieb Naphtali Sprei: > Jamie Lokier wrote: >> Naphtali Sprei wrote: >>> Open backing file for read-only >>> During commit upgrade to read-write and back at end to read-only >> >>> +if (ro) { /* re-open as RO */ >>> +bs_ro = bdrv_new(""); >>> +ret = bdrv_o

Re: [Qemu-devel] Need QEMU source and documentation

2010-02-04 Thread Roy Tam
2010/2/4 Taimoor Mirza : > > > Hi all, > > I need QEMU source and documentation but qemu.org is down. Is there any > other place from where I can get both source and documentation? You can get it from savannah. http://savannah.nongnu.org/projects/qemu > > Regards, > Taimoor > > __

Re: [Qemu-devel] [PATCH 3/4] Block: readonly changes

2010-02-04 Thread Naphtali Sprei
Jamie Lokier wrote: > Naphtali Sprei wrote: >> Open backing file for read-only >> During commit upgrade to read-write and back at end to read-only > >> +if (ro) { /* re-open as RO */ >> +bs_ro = bdrv_new(""); >> +ret = bdrv_open2(bs_ro, bs->backing_hd->filename, >> bs->backin

[Qemu-devel] Need QEMU source and documentation

2010-02-04 Thread Taimoor Mirza
Hi all, I need QEMU source and documentation but qemu.org is down. Is there any other place from where I can get both source and documentation? Regards, Taimoor _ Hotmail: Free,