[Qemu-devel] Re: [PATCH] Seabios - read e820 table from qemu_cfg

2010-01-29 Thread Kevin O'Connor
On Fri, Jan 29, 2010 at 10:03:55AM +0100, Jes Sorensen wrote: > On 01/28/10 05:39, Kevin O'Connor wrote: > >The advantage being that it should be possible to write one set of > >helper functions in both qemu and seabios that can then be used to > >pass arbitrary content. > > The only issue here is

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-29 Thread identifier scorpio
BUG? In tcg_out_qemu_ld tcg_out_ld(s, TCG_TYPE_I64, r1, r1,    offsetof(CPUTLBEntry, addend)    - offsetof(CPUTLBEntry, addr_read)); should be modified to tcg_out_ld(s, TCG_TYPE_I64, r1, r1,    offsetof(CPUTLBEntry, addend)); since the when calling tcg_out

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-29 Thread Laurent Desnogues
On Sat, Jan 30, 2010 at 12:04 AM, Stefan Weil wrote: [...] > > that was a good suggestion. bntest raises a segmentation fault > (NULL pointer, p == 0, see below) with qemu-x86_64 on a x86_64 host. Compile bntest statically and it should work. x86_64 user mode is completely broken for dynamically

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-29 Thread Edgar E. Iglesias
On Sat, Jan 30, 2010 at 12:04:29AM +0100, Stefan Weil wrote: > Edgar E. Iglesias schrieb: > > On Fri, Jan 29, 2010 at 09:04:58AM -0800, Richard Henderson wrote: > >> On 01/28/2010 05:55 PM, identifier scorpio wrote: > >>> Your code is more skilled and I learn a lot from it, but I haven't yet > >>>

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-29 Thread Stefan Weil
Edgar E. Iglesias schrieb: > On Fri, Jan 29, 2010 at 09:04:58AM -0800, Richard Henderson wrote: >> On 01/28/2010 05:55 PM, identifier scorpio wrote: >>> Your code is more skilled and I learn a lot from it, but I haven't yet >>> recognized the key difference between your version and mine. In last >>

Re: [Qemu-devel] [RFC] wiki.qemu.org

2010-01-29 Thread Anthony Liguori
On 01/29/2010 03:47 PM, Stefan Weil wrote: Hi, it's great to have an "official" QEMU wiki. What will happen with http://qemu.kidsquid.com/? I don't know. It's certainly provided a great service over the years. I see no reason not to continue to link to it and if people want to move con

[Qemu-devel] [PATCH] Documentation: Add build support for documentation in pdf format

2010-01-29 Thread Stefan Weil
Makefile already supported dvi, html and info formats, but pdf was missing. pdf is especially convenient for printing and for documentation reviews. I hope it will help to improve qemu's documentation. Make now supports the new target 'pdf' which will create qemu-doc.pdf and qemu-tech.pdf. It is

Re: [Qemu-devel] [RFC] wiki.qemu.org

2010-01-29 Thread Stefan Weil
Anthony Liguori schrieb: > Hi, > > I've been (slowly) working to convert qemu.org to a wiki in order to > allow more community participation in the website. I've finally got a > site setup and to my liking with all of the www.qemu.org content > migrated. > > Before doing the switch, I need to figu

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-29 Thread Edgar E. Iglesias
On Fri, Jan 29, 2010 at 09:04:58AM -0800, Richard Henderson wrote: > On 01/28/2010 05:55 PM, identifier scorpio wrote: > > Your code is more skilled and I learn a lot from it, but I haven't yet > > recognized the key difference between your version and mine. In last > > mail, you've said that "Main

[Qemu-devel] RE: Qemu-devel Digest, Vol 82, Issue 324

2010-01-29 Thread Yasin Yenidünya
gt;type& VIRTIO_BLK_T_OUT) { > -qemu_iovec_init_external(&req->qiov,&req->elem.out_sg[1], > - req->elem.out_num - 1); > -virtio_blk_handle_write(blkreq,&num_writes, req,&old_bs); > -

[Qemu-devel] Re: [PATCH qemu-kvm] Add raw(af_packet) network backend to qemu

2010-01-29 Thread Sridhar Samudrala
On Wed, 2010-01-27 at 14:56 -0800, Sridhar Samudrala wrote: > On Wed, 2010-01-27 at 22:39 +0100, Arnd Bergmann wrote: > > On Wednesday 27 January 2010, Anthony Liguori wrote: > > > >> I think -net socket,fd should just be (trivially) extended to work > > > >> with raw > > > >> sockets out of the b

Re: [Qemu-devel] [RFC] wiki.qemu.org

2010-01-29 Thread Anthony Liguori
On 01/29/2010 02:29 PM, Andreas Färber wrote: Hi, Am 29.01.2010 um 20:44 schrieb Anthony Liguori: I need to figure out what to do with the current texi documentation. I think it makes sense to move qemu-doc.texi to a wiki page and remove it from the source repository. The other option would

Re: [Qemu-devel] [PATCH][STABLE] cirrus: Properly re-register cirrus_linear_io_addr on vram unmap

2010-01-29 Thread Anthony Liguori
On 01/29/2010 08:12 AM, Jan Kiszka wrote: This fixes CONFIG_FB_CIRRUS for Linux guests and probably much more: When switching away from linearly mapped vram, we also have to restore the I/O handlers for the LFB. This regression was once introduced by commit 2bec46dc97. Signed-off-by: Jan Kiszk

Re: [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification

2010-01-29 Thread Anthony Liguori
On 01/27/2010 10:22 AM, Amit Shah wrote: This commit enables one to use multiple virtio-serial devices and to assign ports to arbitrary devices like this: -device virtio-serial,id=foo -device virtio-serial,id=bar \ -device virtserialport,bus=foo.0,name=foo \ -device virtserialport,bus=b

Re: [Qemu-devel] [PATCH 1/3] virtio_blk: Factor virtio_blk_handle_request out

2010-01-29 Thread Anthony Liguori
On 01/27/2010 06:12 AM, Kevin Wolf wrote: We need a function that handles a single request. Create one by splitting out code from virtio_blk_handle_output. Signed-off-by: Kevin Wolf Applied all. Thanks. Regards, Anthony Liguori --- hw/virtio-blk.c | 78

Re: [Qemu-devel] [RFC] wiki.qemu.org

2010-01-29 Thread Andreas Färber
Hi, Am 29.01.2010 um 20:44 schrieb Anthony Liguori: I need to figure out what to do with the current texi documentation. I think it makes sense to move qemu-doc.texi to a wiki page and remove it from the source repository. The other option would be to link to it as an external page and k

Re: [Qemu-devel] [RFC] wiki.qemu.org

2010-01-29 Thread Scott Tsai
On Sat, Jan 30, 2010 at 3:44 AM, Anthony Liguori wrote: > Hi, > > I've been (slowly) working to convert qemu.org to a wiki in order to allow > more community participation in the website.  I've finally got a site setup > and to my liking with all of the www.qemu.org content migrated. > > Before do

[Qemu-devel] [RFC] wiki.qemu.org

2010-01-29 Thread Anthony Liguori
Hi, I've been (slowly) working to convert qemu.org to a wiki in order to allow more community participation in the website. I've finally got a site setup and to my liking with all of the www.qemu.org content migrated. Before doing the switch, I need to figure out what to do with the current

[Qemu-devel] [PATCH] doc: Update mingw cross compile instructions

2010-01-29 Thread Scott Tsai
The "Cross compilation for Windows with Linux" section of qemu-doc.texi still instructs the user to use 'configure --enable-mingw32' even after the option was removed in Aug 2008: http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=cd01b4a312248dd4e12c3d389d1a349cea4015d8 This documentation only

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-29 Thread Richard Henderson
+} else if (cond == TCG_COND_EQ || cond == TCG_COND_NE) { +tcg_out_mem_long(s, INSN_LDA, TMP_REG1, arg1, -arg2); +opc = (cond == TCG_COND_EQ ? INSN_BEQ : INSN_BNE); Bug here. What was intended was to add "arg1 = TMP_REG1". But since the constraints use "I" for ui

[Qemu-devel] [PATCH 5/5] virtio-blk: add topology support

2010-01-29 Thread Christoph Hellwig
Export all topology information in the block config structure, guarded by a new VIRTIO_BLK_F_TOPOLOGY config flag. Note that there is no savevm support for the new information yet, as it would be a pain without the table driven savevm format. Juan has promised to send out a new version of the tabl

[Qemu-devel] [PATCH 4/5] ide: add topology support

2010-01-29 Thread Christoph Hellwig
Export the physical block size in the ATA IDENTIFY command. The other topology values are not supported in ATA so skip them. Add a new field to the savevm information which is initialized to zero if migrating from an older qemu version. Signed-off-by: Christoph Hellwig Index: qemu/hw/ide/core.

[Qemu-devel] [PATCH 3/5] scsi: add topology support

2010-01-29 Thread Christoph Hellwig
Export the physical block size in the READ CAPACITY (16) command, and add the new block limits VPD page to export the minimum and optiomal I/O sizes. Note that we also need to bump the scsi revision level to SPC-2 as that is the minimum requirement by at least the Linux kernel to try READ CAPACIT

[Qemu-devel] [PATCH 2/4] block: add block topology options

2010-01-29 Thread Christoph Hellwig
Add three new suboptions for the drive option to export block topology information to the guest. This is needed to get optimal I/O alignment for RAID arrays or SSDs. The options are: - physical_block_size to specify the physical block size of the device, this is going to increase from 512 by

[Qemu-devel] [PATCH 1/4] virtio-blk: revert serial number support

2010-01-29 Thread Christoph Hellwig
The addition of the whole ATA IDENTIY page caused the config space to go above the allowed size in the PCI spec, and thus the feature was already reverted in the Linux guest driver and disabled by default in qemu. Signed-off-by: Christoph Hellwig Index: qemu/hw/virtio-blk.c =

[Qemu-devel] [PATCH 1/7] qemu-option: Make qemu_opts_foreach() accumulate return values

2010-01-29 Thread Markus Armbruster
Return the bitwise inclusive or of all return values instead of the last call's value. This lets you find out whether any of the calls returned a non-zero value. No functional change, as existing users either don't care for the value, or pass non-zero abort_on_failure, which breaks the loop on th

[Qemu-devel] [PATCH 7/7] qdev: Add rudimentary help for property value

2010-01-29 Thread Markus Armbruster
This provides the same information as reverted commit 2ba6edf0. Not much, just better than nothing. Signed-off-by: Markus Armbruster --- hw/qdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 7c3701c..539b5a2 100644 --- a/hw/qdev.c +++ b/

[Qemu-devel] [PATCH 2/7] qdev: Fix exit code for -device ?

2010-01-29 Thread Markus Armbruster
Help was shoehorned into device creation, qdev_device_add(). Since help doesn't create a device, it returns NULL, which looks to callers just like failed device creation. Monitor handler do_device_add() doesn't care, but main() exits unsuccessfully. Move help out of device creation, into new qde

[Qemu-devel] [PATCH 6/7] qdev: update help on -device

2010-01-29 Thread Markus Armbruster
While there, use "property" rather than "option", for consistency with -global. Signed-off-by: Markus Armbruster --- qemu-options.hx | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 5c9f482..4c1bcfb 100644 --- a

[Qemu-devel] [PATCH 4/7] Revert "qdev: Add help for device properties"

2010-01-29 Thread Markus Armbruster
This reverts commit 2ba6edf0dd740166632df80caa85992b20791a68. The commit has two issues: * When it runs from the monitor, e.g. "device_add e1000,?", it prints to stderr instead of the monitor. * Help looks to callers just like failed device creation. This makes main() exit unsuccessfully on

[Qemu-devel] [PATCH 3/7] Revert "qdev: Add help for property value"

2010-01-29 Thread Markus Armbruster
This reverts commit 922910ce42d15bdb7c2347436b1b5798b5401de4. The commit has four issues: * When it runs from the monitor, e.g. "device_add e1000,mac=?", it prints to stderr instead of the monitor. * Help looks to callers just like failed device creation. This makes main() exit unsuccessful

[Qemu-devel] [PATCH 5/7] qdev: Add help for device properties

2010-01-29 Thread Markus Armbruster
Option "-device DRIVER,?" and monitor command "device_add DRIVER,?" print the supported properties instead of creating a device. The former also terminates the program. This is commit 2ba6edf0 (just reverted) done right. Signed-off-by: Markus Armbruster --- hw/qdev.c | 15 ++- 1

[Qemu-devel] [PATCH 0/7] Clean up -device help

2010-01-29 Thread Markus Armbruster
It has a number of issues: * Some help is printed to stderr, which is wrong in the monitor. * We terminate the program unsuccessfully after giving help. * Help crept into -global, where it behaves funnily. * Help on property values does not work for properties that accept the value "?". Mark

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-29 Thread Richard Henderson
On 01/25/2010 05:19 PM, Richard Henderson wrote: +} else if (~val == (uint8_t)~val) { +tcg_out_fmt_opi(s, INSN_BIC, ra, ~val, rc); Bug here. I've applied the following to my local tree. r~ commit 2ecce92da6eee4b3496c7655da45259308abb536 Author: Richard Henderson Date: Fri Jan

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-29 Thread Richard Henderson
On 01/28/2010 05:55 PM, identifier scorpio wrote: 1. adding constraints for operation mov_i32/movi_i32/mov_i64/movi_i64 2. replacing "goto do_arith" with "break" for INDEX_op_not_i32/i64 case handling in tcg_out_op Oops. 3. removing the redundant declaration for "alpha_tb_set_jmp_target()" at

[Qemu-devel] Re: [PATCH] Seabios - read e820 table from qemu_cfg

2010-01-29 Thread Gleb Natapov
On Fri, Jan 29, 2010 at 10:03:55AM +0100, Jes Sorensen wrote: > On 01/28/10 05:39, Kevin O'Connor wrote: > >I think defining accessor functions for every piece of data passed > >through qemu-cfg interface is going to get tiring. I'd prefer to > >extend the existing qemu-cfg "file" interface for ne

Re: [Qemu-devel] Merge qemu android

2010-01-29 Thread Anthony Liguori
Hi David, On 01/28/2010 08:41 PM, David Turner wrote: On Thu, Jan 28, 2010 at 2:44 AM, Bastien ROUCARIES mailto:roucaries.bast...@gmail.com>> wrote: They use also craps like sdl :S That's totally orthogonal to upstream QEMU. The code for our SDL-supported interface is totally separate f

Re: [Qemu-devel] [RFC][PATCH] KVM: Introduce modification context for cpu_synchronize_state

2010-01-29 Thread Anthony Liguori
On 01/29/2010 09:25 AM, Jan Kiszka wrote: Anthony Liguori wrote: On 01/27/2010 08:54 AM, Jan Kiszka wrote: This patch originates in the mp_state writeback issue: During runtime and even on reset, we must not write the previously saved VCPU state back into the kernel in an uncontrolled

Re: [Qemu-devel] [RFC][PATCH] KVM: Introduce modification context for cpu_synchronize_state

2010-01-29 Thread Jan Kiszka
Anthony Liguori wrote: > On 01/27/2010 08:54 AM, Jan Kiszka wrote: >> This patch originates in the mp_state writeback issue: During runtime >> and even on reset, we must not write the previously saved VCPU state >> back into the kernel in an uncontrolled fashion. E.g mp_state should >> only written

[Qemu-devel] About MIPS framebuffer

2010-01-29 Thread daniel tian
Hi, your guys: Now I am working on Poky linux porting on mipsel(little endian). I am wondering whether the qemu mips can run just like ARM-qemu showing the X-window. Now I can run the qemu-system-mipsel with malta board kernel and poky rootfs. Here is the command I used: qe

Re: [Qemu-devel] [RFC][PATCH] KVM: Introduce modification context for cpu_synchronize_state

2010-01-29 Thread Anthony Liguori
On 01/27/2010 08:54 AM, Jan Kiszka wrote: This patch originates in the mp_state writeback issue: During runtime and even on reset, we must not write the previously saved VCPU state back into the kernel in an uncontrolled fashion. E.g mp_state should only written on reset or on VCPU setup. Certain

[Qemu-devel] [PATCH][STABLE] cirrus: Properly re-register cirrus_linear_io_addr on vram unmap

2010-01-29 Thread Jan Kiszka
This fixes CONFIG_FB_CIRRUS for Linux guests and probably much more: When switching away from linearly mapped vram, we also have to restore the I/O handlers for the LFB. This regression was once introduced by commit 2bec46dc97. Signed-off-by: Jan Kiszka --- hw/cirrus_vga.c |6 -- 1 fil

Re: [Qemu-devel] Merge qemu android

2010-01-29 Thread Luiz Capitulino
On Thu, 28 Jan 2010 18:35:16 -0800 David Turner wrote: > Anthony is right, and unfortunately the Android team doesn't have the > bandwidth to support sending patches to upstream > at the moment. You should also consider the benefits for yourself of merging your bits upstream: more peer review,

Re: [Qemu-devel] [RFC] gPXE fw_cfg file interface support

2010-01-29 Thread Stefan Hajnoczi
On Wed, Jan 27, 2010 at 10:15 AM, Gerd Hoffmann wrote: >> Note that this patch only adds the fw_cfg file interface mechanism, it >> does not >> automatically probe for a special file when gPXE starts.  You will >> need to manually >> "chain fw_cfg:genroms/file". > > That should be changed too IMHO

[Qemu-devel] [PATCH 2/2] Revert "QError: New QERR_INVALID_CPU_INDEX"

2010-01-29 Thread Markus Armbruster
This reverts commit 64a34bb14c0e358a6b2f14805e59ef25bf62d6d5. Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 --- 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/qerror.c b/qerror.c index 6c2aba0..2f657f4 100644 --- a/qerror.c +++ b/qerror.c @@ -81,10 +

[Qemu-devel] [PATCH 0/2] Avoid extra error for do_cpu_set()

2010-01-29 Thread Markus Armbruster
The conversion created a special error, to avoid changing the error message in the human monitor. Anthony thinks that's not necessary. Remove it and use a suitable generic error instead. Markus Armbruster (2): monitor: Use QERR_INVALID_PARAMETER instead of QERR_INVALID_CPU_INDEX Revert "QErro

[Qemu-devel] [PATCH 1/2] monitor: Use QERR_INVALID_PARAMETER instead of QERR_INVALID_CPU_INDEX

2010-01-29 Thread Markus Armbruster
This changes the error message from "Invalid CPU index" to "Invalid parameter index" in the human monitor. Signed-off-by: Markus Armbruster --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index fb7c572..69ebac5 100644 --- a/monitor.c

[Qemu-devel] Re: [PATCH] Seabios - read e820 table from qemu_cfg

2010-01-29 Thread Jes Sorensen
On 01/28/10 05:39, Kevin O'Connor wrote: I think defining accessor functions for every piece of data passed through qemu-cfg interface is going to get tiring. I'd prefer to extend the existing qemu-cfg "file" interface for new content. For example, add a helper with something like: int qemu_cf

[Qemu-devel] Re: Merge qemu android

2010-01-29 Thread Jan Kiszka
David Turner wrote: > On Thu, Jan 28, 2010 at 2:44 AM, Bastien ROUCARIES < > roucaries.bast...@gmail.com> wrote: > >> They use also craps like sdl :S >> >> > That's totally orthogonal to upstream QEMU. The code for our SDL-supported > interface is totally separate from the rest > of QEMU changes (