On Mon, Jan 04, 2010 at 07:47:00PM +0100, Aurelien Jarno wrote:
> I am still waiting for you to list patches from Anthony or me,
Why should I go look for them? I thought you basically agreed it's a
good idea to post patches publically either before or - for trivial
patches - after commit?
--
MS
Anthony Liguori wrote:
> introduces a subtle semantic change. Previously, timers always ran
> before bottom halves whereas after this change, timers may run after
> some bottoms halves but before others. While this should be okay in
> principle, in practice, I'm sure it'll introduce regression
On 12/22/2009 11:40 AM, TAKEDA, toshiya wrote:
Signed-off-by: TAKEDA, toshiya
---
hw/pc98.c | 317 +
hw/pc98.h | 65 +
2 files changed, 382 insertions(+), 0 deletions(-)
create mode 100644 hw/pc98.c
create mode 100
Hi,
Why is this needed verses qemu_system_reset()?
Regards,
Anthony Liguori
On 12/21/2009 02:09 AM, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
Makefile.target |1 +
cpu-all.h |2 +
qemu-timer.c| 1218 +++
qemu-timer.h| 11 +
vl.c| 1164
On 12/21/2009 02:09 AM, Paolo Bonzini wrote:
Make the timer subsystem register its own bottom half instead of
placing the bottom half code in the heart of the main loop. To
test if an alarm timer is pending, just check if the bottom half is
scheduled.
Signed-off-by: Paolo Bonzini
I'm not a hu
On 12/21/2009 02:09 AM, Paolo Bonzini wrote:
As a side exercise, move 200 lines out of vl.c already into common
code that only needs to be compiled once.
Maybe input.c instead of event.c?
Please split this out of the series and resubmit. It's a pretty obvious
patch to include on it's own.
On Mon, Jan 04, 2010 at 07:04:38PM +, Blue Swirl wrote:
> On Mon, Jan 4, 2010 at 6:33 PM, Michael S. Tsirkin wrote:
> >> On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote:
> >> > Likewise, if you see a patch go in that you think would have benefited
> >> > from being on the list,
On Mon, Jan 4, 2010 at 6:33 PM, Michael S. Tsirkin wrote:
>> On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote:
>> > Likewise, if you see a patch go in that you think would have benefited
>> > from being on the list, point it out. People are reasonable and if you
>> > have a good su
On Mon, Jan 04, 2010 at 08:33:56PM +0200, Michael S. Tsirkin wrote:
> > On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote:
> > > Likewise, if you see a patch go in that you think would have benefited
> > > from being on the list, point it out. People are reasonable and if you
> >
On 01/04/2010 08:34 PM, Anthony Liguori wrote:
On 12/21/2009 02:09 AM, Paolo Bonzini wrote:
The code is initializing an unsigned int to UINT_MAX using "-1", so that
the following always-true comparison seems to be always-false at a
first look. Just remove the if.
This really needs a better com
> On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote:
> > Likewise, if you see a patch go in that you think would have benefited
> > from being on the list, point it out. People are reasonable and if you
> > have a good suggestion, they'll value your input and be likely to seek
On 12/21/2009 02:09 AM, Paolo Bonzini wrote:
The code is initializing an unsigned int to UINT_MAX using "-1", so that
the following always-true comparison seems to be always-false at a
first look. Just remove the if.
This really needs a better comment message as at first it wasn't obvious
to
On 12/21/2009 02:09 AM, Paolo Bonzini wrote:
This series makes a few cleanup in the timer handling code and
splits out ~1500 lines out of the huge vl.o file. So far I've tested
it by booting a live CD both under Linux and by cross-compiling to
Windows. If the series is considered helpful, I can
On 01/03/2010 11:19 AM, David S. Ahern wrote:
>
> After weeks of fruitless effort I could use some help getting a USB
> audio device to work. I have instrumented the hell out of the guest
> driver and uhci code, qemu's linux and uhci code, and the host side usb
> code. Near as I can tell data fro
This patch adds generic serial ports over the virtio serial bus.
These ports have a few more options that are not relevant for
virtio console ports: the ability to cache buffers that are
received for a port while it's disconnected, setting of limits
to the bytes that are cached so as to prevent OOM
There's nothing target-dependent in the virtio-serial code so allow it
to be compiled just once for all the targets.
Signed-off-by: Amit Shah
---
Makefile.hw |2 +-
Makefile.target |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.hw b/Makefile.hw
index b
Guests send us one buffer at a time. Current guests send buffers sized
4K bytes. If guest userspace applications sent out > 4K bytes in one
write() syscall, the write request actually sends out multiple buffers,
each of 4K in size.
This usually isn't a problem but for some apps, like VNC, the enti
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |2 ++
hw/virtio-serial.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index bc47629..cf532f6 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@
The port 'id' or number is internal state between the guest kernel and
our bus implementation. This is invocation-dependent and isn't part of
the guest-host ABI.
To correcly enumerate and map ports between the host and the guest, the
'name' property is used.
Example:
-device virtserialport,n
Via control channel messages, the guest can tell us whether a port got
opened or closed. Similarly, we can also indicate to the guest of host
port open/close events.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 73
hw/virtio-serial.c
This commit converts the virtio-console device to create a new
virtio-serial bus that can host console and generic serial ports. The
file hosting this code is now called virtio-serial-bus.c.
The virtio console is now a very simple qdev device that sits on the
virtio-serial-bus and communicates bet
Hello,
This series addresses some comments from last time:
- locking is removed
- send/receive struct elements in endian-safe way
- appropriate device is created based on machine being used
(virtio-serial-pci vs virtio-serial-s390).
This series splits up the patches by functionality. Note, howe
VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
hw/virtio.h.
Also, bump up the value of the maximum allowed virtqueues to 64. This is
in preparation to allow multiple ports per virtio-console device.
Signed-off-by: Amit Shah
---
hw/virtio.c |2 --
hw/virtio.h |2
2009/12/23 TAKEDA, toshiya :
> Dear members,
>
> Sorry too late reply for comments of previous patch.
> (I was busy in these months for my business...)
> This is new patch.
>
> Change from v3 to v4:
> - use vmstate for save/load state
> - remove sound device with MAME opna sound core
>
+1 for addi
Rename features->guest_features. This is what they are, avoid confusion
with host features which we also need to keep around.
Signed-off-by: Michael S. Tsirkin
---
hw/s390-virtio-bus.c |2 +-
hw/syborg_virtio.c |4 ++--
hw/virtio-net.c | 10 +-
hw/virtio-pci.c |
Add feature bits as properties to virtio. This makes it possible to e.g. define
machine without indirect buffer support, which is required for 0.10
compatibility, or without hardware checksum support, which is required for 0.11
compatibility. Since default values for optional features are now set
This adds "bit" property type, which is a boolean stored in a 32 bit
integer field, with legal values on and off. Will be used by virtio for
feature bits.
Signed-off-by: Michael S. Tsirkin
Acked-by: Gerd Hoffmann
---
hw/qdev-properties.c | 62 -
Here's what I came up with for solving the problem of differences in
features in virtio between 0.12 and 0.11. This also enables migration
between different backends, e.g. between host where tap supports virtio
net header and where it does not: management just needs to set features
appropriately.
On 12/24/09 09:26, Markus Armbruster wrote:
We could declare that -virtioconsole always creates a bus a feature, but
I can do that in good conscience only if the console created along with
it always gets attached to it, even when other suitable buses exist.
I'd just discourage mixing -virtiocon
On 01/04/10 16:36, Michael S. Tsirkin wrote:
Here's what I came up with for solving the problem of differences in
features in virtio between 0.12 and 0.11. This also enables migration
between different backends, e.g. between host where tap supports virtio
net header and where it does not: manag
On Mon, Jan 04, 2010 at 04:22:25PM +0100, Gerd Hoffmann wrote:
> On 12/23/09 12:37, Avi Kivity wrote:
>> On 12/23/2009 12:58 PM, Thomas Treutner wrote:
>>> On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
Please post a full log, after 'make clean'.
>>> http://pastebin.com/f404c8648
>>>
Add feature bits as properties to virtio. This makes it possible to e.g. define
machine without indirect buffer support, which is required for 0.10
compatibility, or without hardware checksum support, which is required for 0.11
compatibility. Since default values for optional features are now set
On Mon, Jan 04, 2010 at 03:22:36PM +0100, Gerd Hoffmann wrote:
> On 12/24/09 13:43, Michael S. Tsirkin wrote:
>> This adds "bit" property type, which is a boolean stored in a 32 bit
>> integer field, with legal values on and off. Will be used by virtio for
>> feature bits.
>
>> +static void *qdev_
On Mon, Jan 04, 2010 at 03:24:18PM +0100, Gerd Hoffmann wrote:
> On 12/24/09 13:44, Michael S. Tsirkin wrote:
>> Add feature bits as properties to virtio. This makes it possible to e.g.
>> define
>> machine without indirect buffer support, which is required for 0.10
>> compatibility, or without ha
This adds "bit" property type, which is a boolean stored in a 32 bit
integer field, with legal values on and off. Will be used by virtio for
feature bits.
Signed-off-by: Michael S. Tsirkin
---
hw/qdev-properties.c | 62 -
hw/qdev.h|
Here's what I came up with for solving the problem of differences in
features in virtio between 0.12 and 0.11. This also enables migration
between different backends, e.g. between host where tap supports virtio
net header and where it does not: management just needs to set features
appropriately.
On 12/23/09 12:37, Avi Kivity wrote:
On 12/23/2009 12:58 PM, Thomas Treutner wrote:
On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
Please post a full log, after 'make clean'.
http://pastebin.com/f404c8648
Oh, I missed it at first - looks like libxenguest and libxenctrl conflict.
On 12/24/09 09:08, Isaku Yamahata wrote:
Anthony. Can you please merge those patches as Gerd has agreed
with the direction of this patch series.
Gerd, can you provide acked-by or reviewed-by for patches
you like?
Whole series looks pretty good to me, except for two minor nits (see
replies to i
On 12/24/09 09:09, Isaku Yamahata wrote:
The argument will be used later to remove global variable.
-static int piix4_device_hotplug(PCIDevice *dev, int state);
+static int piix4_device_hotplug(void *opaque, PCIDevice *dev, int state);
You are using that to pass the piix4-pm device state. H
+void pc_smbus_init(PCSMBus *smb)
+{
+smb->smbus = i2c_init_bus(NULL, "i2c");
+}
This function should take a additional "DeviceState *parent" argument
and pass it down to i2c_init_bus() instead of NULL. Patch #21
(acpi_piix4: qdevfy) should pass the piix4-pm DeviceState to
pc_smbus_init(
On 12/24/09 13:44, Michael S. Tsirkin wrote:
Add feature bits as properties to virtio. This makes it possible to e.g. define
machine without indirect buffer support, which is required for 0.10
compatibility, or without hardware checksum support, which is required for 0.11
compatibility. Since de
On 12/24/09 13:43, Michael S. Tsirkin wrote:
This adds "bit" property type, which is a boolean stored in a 32 bit
integer field, with legal values on and off. Will be used by virtio for
feature bits.
+static void *qdev_bit_prop_ptr(DeviceState *dev, Property *prop)
+{
+void *ptr = dev;
+
On 12/29/09 22:51, H. Peter Anvin wrote:
Add generic support for debugging consoles (simple I/O ports which
when written to cause debugging output to be written to a target.)
The current implementation matches Bochs' port 0xe9, allowing the same
debugging code to be used for both Bochs and Qemu.
Tristan Gingold schrieb:
> On Dec 29, 2009, at 4:30 PM, Stefan Weil wrote:
>
>
>> Hi,
>>
>> When qemu-system-ppc is started with argument "-icount auto"
>> (needed for running qemu in the emulated system),
>> it will print lots of "Bad clock read" on stderr.
>>
>> env->can_do_io toggles between
On 04.01.2010, at 12:07, Michael S. Tsirkin wrote:
> On Mon, Jan 04, 2010 at 07:45:16PM +0900, Isaku Yamahata wrote:
>> +static PCIDevice *pci_host_dev_find_fn_noswap(PCIHostState *s, uint32_t
>> addr)
>> +{
>> +return pci_host_find_dev_active(s->bus, pci_host_pci_addr(s, addr));
>> +}
>> +
On Mon, Jan 04, 2010 at 07:45:16PM +0900, Isaku Yamahata wrote:
> +static PCIDevice *pci_host_dev_find_fn_noswap(PCIHostState *s, uint32_t addr)
> +{
> +return pci_host_find_dev_active(s->bus, pci_host_pci_addr(s, addr));
> +}
> +
> +static PCIDevice *pci_host_dev_find_fn(PCIHostState *s, uint3
On Mon, Jan 04, 2010 at 11:55:10AM +0100, Alexander Graf wrote:
>
> On 04.01.2010, at 11:45, Isaku Yamahata wrote:
>
> > On Mon, Jan 04, 2010 at 04:26:46AM +0100, Alexander Graf wrote:
> >>
> >> On 03.01.2010, at 21:50, Benjamin Herrenschmidt wrote:
> >>
> >>> On Sun, 2010-01-03 at 21:27 +0100,
On 04.01.2010, at 11:45, Isaku Yamahata wrote:
> On Mon, Jan 04, 2010 at 04:26:46AM +0100, Alexander Graf wrote:
>>
>> On 03.01.2010, at 21:50, Benjamin Herrenschmidt wrote:
>>
>>> On Sun, 2010-01-03 at 21:27 +0100, Alexander Graf wrote:
>>>
I think if unin_pci is the only user, it'd be b
On Mon, Jan 04, 2010 at 04:26:46AM +0100, Alexander Graf wrote:
>
> On 03.01.2010, at 21:50, Benjamin Herrenschmidt wrote:
>
> > On Sun, 2010-01-03 at 21:27 +0100, Alexander Graf wrote:
> >
> >> I think if unin_pci is the only user, it'd be better to do it hacky
> >> inside unin_pci.c. But if th
On Dec 29, 2009, at 4:30 PM, Stefan Weil wrote:
> Hi,
>
> When qemu-system-ppc is started with argument "-icount auto"
> (needed for running qemu in the emulated system),
> it will print lots of "Bad clock read" on stderr.
>
> env->can_do_io toggles between 0 and 1.
I have a patch to enable -i
This adds a few more vpath suffixes and points the remaining two paths
explicitly to $(SRC_PATH) in order to eliminate the VPATH assignment
from config-host.mak.
Signed-off-by: Paolo Bonzini
Cc: Juan Quintela
---
Makefile|2 +-
Makefile.target |2 +-
configure |3 ---
Hi,
@@ -321,13 +321,9 @@ void qdev_machine_creation_done(void)
CharDriverState *qdev_init_chardev(DeviceState *dev)
{
static int next_serial;
-static int next_virtconsole;
+
/* FIXME: This is a nasty hack that needs to go away. */
-if (strncmp(dev->info->name, "virtio"
Hi,
Works great, thanks.
Acked-By: Riku Voipio
On Tue, Dec 29, 2009 at 10:39:21PM +0100, Loïc Minier wrote:
> Hey there
>
> This patch for linux-user adapts the output of the emulated uname()
> syscall to match the configured CPU. Tested with x86, x86-64 and arm
> emulation.
>
>
On Tue, Dec 29, 2009 at 12:07:58PM +0200, Avi Kivity wrote:
> Guests use this number as a hint for alignment and I/O request sizes. Given
> that modern disks have 4K block sizes, and cached file-backed images also
> have 4K block sizes, this hint can improve guest performance.
>
> We probably nee
On Tue, Dec 29, 2009 at 02:39:38PM +0100, Luca Tettamanti wrote:
> Linux tools put the first partition at sector 63 (512-byte) to retain
> compatibility with Windows;
Well, some of them, and depending on the exact disks. It's all rather
complicated.
> > It has been discussed for hardware disk de
On Mon, Jan 04, 2010 at 01:38:51PM +1030, Rusty Russell wrote:
> I thought this was what I was doing, but I have shown over and over that
> I have no idea about block devices.
>
> Our current driver treats BLK_SIZE as the logical and physical size (see
> blk_queue_logical_block_size).
>
> I have
Hi,
I will do it tomorrow!
sorry for that ,today i prepare for a ppt for my boss.
sorry
Steven Liu
On Mon, 2010-01-04 at 15:17 +0700, Mulyadi Santosa wrote:
> On Mon, Jan 4, 2010 at 3:10 PM, Dejun.Liu wrote:
> >>
> >> I will land a fix in a second. What you want to change in
> > libsdl-native
Hi,
OE's Holger has patch OE with this problem
---
> On Monday 04 January 2010 04:11:33 Dejun.Liu wrote:
> > -->I used the OE build Qemu which at the staging
> > dir(angstrom-dev/staging/i686-linux/usr/bin).
> > and i executed the command in the buildserver not using ssh
>
> The
On Mon, Jan 4, 2010 at 3:10 PM, Dejun.Liu wrote:
>>
>> I will land a fix in a second. What you want to change in
> libsdl-native as
>> a quick solution is to add DEPENDS += "libx11-native" and change
>> --disable- video-x11" to --enable-video-x11".
>
> I(Holger) have comitted two patches for it
60 matches
Mail list logo
