[Qemu-devel] Re: [PATCH] ppc64: Change default machine to mac99

2009-12-19 Thread Alexander Graf
Am 20.12.2009 um 00:22 schrieb Andreas Färber : Also change the New World default CPU to 970FX for ppc64, since the G4 is a 32-bit CPU. Looks good :). Thanks! Acked-by: Alexander Graf

[Qemu-devel] [PATCH 18/18] linux-user/mmap.c: fix warnings with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCi386-linux-user/mmap.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c: In function 'mmap_frag': /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c:253: error: ignoring return value of 'pread', declared with attribute warn_unused_result /usr/src/RPM/B

[Qemu-devel] [PATCH 17/18] path.c fix warning with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CClibuser/path.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/path.c: In function 'new_entry': /usr/src/RPM/BUILD/qemu-0.11.92/path.c:49: error: ignoring return value of 'asprintf', declared with attribute warn_unused_result make[1]: *** [path.o] Error 1 Signed-off-

[Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCi386-softmmu/pc.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/hw/pc.c: In function 'load_multiboot': /usr/src/RPM/BUILD/qemu-0.11.92/hw/pc.c:614: error: ignoring return value of 'fread', declared with attribute warn_unused_result /usr/src/RPM/BUILD/qemu-0.11.92/hw

[Qemu-devel] [PATCH 15/18] monitor.c: fix warnings with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCi386-softmmu/monitor.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c: In function 'do_memory_save': /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c:1318: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result /usr/src/RPM/BUILD/qemu

[Qemu-devel] [PATCH 14/18] vl.c: fix warning with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCi386-softmmu/vl.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'qemu_event_increment': /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:3404: error: ignoring return value of 'write', declared with attribute warn_unused_result /usr/src/RPM/BUILD/qemu-0.11.92/v

[Qemu-devel] [PATCH 13/18] slirp/misc.c: fix warning with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCslirp/misc.o cc1: warnings being treated as errors slirp/misc.c: In function 'fork_exec': slirp/misc.c:209: error: ignoring return value of 'write', declared with attribute warn_unused_result make: *** [slirp/misc.o] Error 1 Signed-off-by: Kirill A. Shutemov --- slirp/misc.c | 10 ++--

[Qemu-devel] [PATCH 12/18] savevm.c: fix warning with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCsavevm.o cc1: warnings being treated as errors savevm.c: In function 'file_put_buffer': savevm.c:342: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result make: *** [savevm.o] Error 1 Signed-off-by: Kirill A. Shutemov --- savevm.c |3 +-- 1 files chan

[Qemu-devel] [PATCH 11/18] usb-linux.c: fix warning with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCusb-linux.o cc1: warnings being treated as errors usb-linux.c: In function 'usb_host_read_file': usb-linux.c:1204: error: ignoring return value of 'fgets', declared with attribute warn_unused_result make: *** [usb-linux.o] Error 1 Signed-off-by: Kirill A. Shutemov --- usb-linux.c |7

[Qemu-devel] [PATCH 10/18] net/slirp.c: fix warning with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCnet/slirp.o cc1: warnings being treated as errors net/slirp.c: In function 'slirp_smb_cleanup': net/slirp.c:470: error: ignoring return value of 'system', declared with attribute warn_unused_result make: *** [net/slirp.o] Error 1 Signed-off-by: Kirill A. Shutemov --- net/slirp.c |7

[Qemu-devel] [PATCH 09/18] block/qcow2.c: fix warnings with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCblock/qcow2.o cc1: warnings being treated as errors block/qcow2.c: In function 'qcow_create2': block/qcow2.c:829: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow2.c:838: error: ignoring return value of 'write', declared with attribute warn_un

[Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCblock/bochs.o cc1: warnings being treated as errors block/bochs.c: In function 'seek_to_sector': block/bochs.c:202: error: ignoring return value of 'read', declared with attribute warn_unused_result make: *** [block/bochs.o] Error 1 Signed-off-by: Kirill A. Shutemov --- block/bochs.c |

[Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCblock/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result make: *** [block/vvfat.o] Error 1 CCblock/vvfat.o In file included from /usr/i

[Qemu-devel] [PATCH 06/18] block/vmdk.o: fix warnings with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCblock/vmdk.o cc1: warnings being treated as errors block/vmdk.c: In function 'vmdk_snapshot_create': block/vmdk.c:236: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result block/vmdk.c: In function 'vmdk_create': block/vmdk.c:775: error: ignoring return v

[Qemu-devel] [PATCH 04/18] block/cow.c: fix warnings with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCblock/cow.o cc1: warnings being treated as errors block/cow.c: In function 'cow_create': block/cow.c:251: error: ignoring return value of 'write', declared with attribute warn_unused_result block/cow.c:253: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_r

[Qemu-devel] [PATCH 05/18] block/qcow.c: fix warnings with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCblock/qcow.o cc1: warnings being treated as errors block/qcow.c: In function 'qcow_create': block/qcow.c:804: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow.c:806: error: ignoring return value of 'write', declared with attribute warn_unused_

[Qemu-devel] [PATCH 03/18] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCposix-aio-compat.o cc1: warnings being treated as errors posix-aio-compat.c: In function 'aio_signal_handler': posix-aio-compat.c:505: error: ignoring return value of 'write', declared with attribute warn_unused_result make: *** [posix-aio-compat.o] Error 1 Signed-off-by: Kirill A. Shutem

[Qemu-devel] [PATCH 02/18] block.c: fix warning with _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
CCblock.o cc1: warnings being treated as errors block.c: In function 'bdrv_open2': block.c:400: error: ignoring return value of 'realpath', declared with attribute warn_unused_result Signed-off-by: Kirill A. Shutemov --- block.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-

[Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE

2009-12-19 Thread Kirill A. Shutemov
Let's fix code instead! Signed-off-by: Kirill A. Shutemov --- configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure b/configure index d815c7a..17f3d42 100755 --- a/configure +++ b/configure @@ -97,7 +97,6 @@ CFLAGS="-g $CFLAGS" QEMU_CFLAGS="-Wall -Wundef -

Re: [Qemu-devel] [PATCH 3/5] tcg-i386: Implement small forward branches.

2009-12-19 Thread Richard Henderson
On 12/19/2009 03:32 PM, Laurent Desnogues wrote: switch(args[4]) { case TCG_COND_EQ: -tcg_out_brcond(s, TCG_COND_NE, args[0], args[2], const_args[2], label_next); -tcg_out_brcond(s, TCG_COND_EQ, args[1], args[3], const_args[3], args[5]); +tcg_out_brcond(s, TCG_

Re: [Qemu-devel] [PATCH 2/3] tcg-mips: Implement setcond, setcond2.

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:38:01PM +, Richard Henderson wrote: > --- > tcg/mips/tcg-target.c | 177 > + > 1 files changed, 177 insertions(+), 0 deletions(-) While this code is surely highly optimized, it is not easily readable. I think droppin

Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 03:24:22PM -0800, Richard Henderson wrote: > On 12/19/2009 03:11 PM, Aurelien Jarno wrote: >> On Sat, Dec 19, 2009 at 10:01:57AM -0800, Richard Henderson wrote: >>> Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. >> >> I do wonder if setcond2_i32 and brcond2_i32

Re: [Qemu-devel] [PATCH 0/5] tcg conditional set, round 4

2009-12-19 Thread malc
On Sun, 20 Dec 2009, Aurelien Jarno wrote: > On Sat, Dec 19, 2009 at 10:52:52AM -0800, Richard Henderson wrote: > > Changes from round 3: > > > > * Drop movcond for now. > > * Only use movzbl and not xor in setcond. > > > > > > Thanks for the update, it looks like ready, I only have cosmetic

Re: [Qemu-devel] [PATCH 3/5] tcg-i386: Implement small forward branches.

2009-12-19 Thread Laurent Desnogues
On Sat, Dec 19, 2009 at 7:44 PM, Richard Henderson wrote: > There are places, like brcond2, where we know that the destination > of a forward branch will be within 127 bytes. > > Add the R_386_PC8 relocation type to support this.  Add a flag to > tcg_out_jxx and tcg_out_brcond* to enable it.  Set

[Qemu-devel] [PATCH 1/3] target-alpha: Emit tcg debug_insn_start.

2009-12-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-alpha/translate.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 45cb697..5e0647b 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -2627,6 +26

[Qemu-devel] [PATCH 3/3] linux-user: Initialize Alpha FPCR register.

2009-12-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 12502ad..b67662c 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3052,6 +3052,8 @@ int main(int argc, char **argv

[Qemu-devel] [PATCH 2/3] linux-user: Add aliases for some Alpha syscalls

2009-12-19 Thread Richard Henderson
Alpha always used 32-bit uids, but never renamed the syscalls to match i386 when 32-bit uids were added there. This enables the proper bits in syscall.c. Signed-off-by: Richard Henderson --- linux-user/alpha/syscall_nr.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --

Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-19 Thread Richard Henderson
On 12/19/2009 03:11 PM, Aurelien Jarno wrote: On Sat, Dec 19, 2009 at 10:01:57AM -0800, Richard Henderson wrote: Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. I do wonder if setcond2_i32 and brcond2_i32 should be added there. Those are internal ops that are actually not exported

[Qemu-devel] [PATCH] ppc64: Change default machine to mac99

2009-12-19 Thread Andreas Färber
Also change the New World default CPU to 970FX for ppc64, since the G4 is a 32-bit CPU. Signed-off-by: Andreas Färber Cc: Alexander Graf --- hw/ppc_newworld.c |7 +++ hw/ppc_oldworld.c |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/hw/ppc_newworld.c b/hw/ppc_n

Re: [Qemu-devel] [PATCH 5/5] tcg-i386: Implement setcond.

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:46:38AM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson This looks ok, though I would appreciate someone else to review it in details. > --- > tcg/i386/tcg-target.c | 73 > +++-- > 1 files changed, 70 i

Re: [Qemu-devel] [PATCH 4/5] tcg: Add tcg_invert_cond.

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:44:52AM -0800, Richard Henderson wrote: > It is very handy to have a reliable mapping of a condition to its inverse. Acked-by: Aurelien Jarno > Signed-off-by: Richard Henderson > --- > tcg/tcg.h |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > di

Re: [Qemu-devel] [PATCH 3/5] tcg-i386: Implement small forward branches.

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:44:11AM -0800, Richard Henderson wrote: > There are places, like brcond2, where we know that the destination > of a forward branch will be within 127 bytes. > > Add the R_386_PC8 relocation type to support this. Add a flag to > tcg_out_jxx and tcg_out_brcond* to enable

Re: [Qemu-devel] [PATCH 2/5] tcg-x86_64: Implement setcond.

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 08:50:19AM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/x86_64/tcg-target.c | 38 +- > 1 files changed, 33 insertions(+), 5 deletions(-) > > diff --git a/tcg/x86_64/tcg-tar

Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:01:57AM -0800, Richard Henderson wrote: > Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. I do wonder if setcond2_i32 and brcond2_i32 should be added there. Those are internal ops that are actually not exported in tcg-op.h. > Signed-off-by: Richard Henderso

Re: [Qemu-devel] [PATCH 0/5] tcg conditional set, round 4

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:52:52AM -0800, Richard Henderson wrote: > Changes from round 3: > > * Drop movcond for now. > * Only use movzbl and not xor in setcond. > > Thanks for the update, it looks like ready, I only have cosmetic or minor comments. See my comments in the individual patches

Re: [Qemu-devel] [PATCH 0/3] mips setcond and movcond

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:43:31PM +, Richard Henderson wrote: > It has been compile tested, but nothing else. > > I'm moderately surprised at the implementation of brcond. It's > missing the BLTZ, BLEZ, BGTZ, BGEZ branches. It's could be > improved with the SLTI and SLTIU insns used here w

Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 08:19:32AM -0800, Richard Henderson wrote: > On 12/19/2009 05:03 AM, Aurelien Jarno wrote: > >- For the movcond instruction, is there a real use for vtrue and vfalse > > values? Most CPU actually implement a version with one value. > > Implementing it with two values mov

Re: [Qemu-devel] [PATCH 5/7] tcg-sparc: Implement setcond, movcond, setcond2, brcond2.

2009-12-19 Thread Richard Henderson
On 12/19/2009 01:25 PM, Blue Swirl wrote: On Sat, Dec 19, 2009 at 5:47 PM, Richard Henderson wrote: On 12/19/2009 02:31 AM, Blue Swirl wrote: static inline void tcg_out_movi_imm32(TCGContext *s, int ret, uint32_t arg) { -if (check_fit_tl(arg, 12)) +if (check_fit_tl(arg, 13))

[Qemu-devel] [PATCH 0/3] mips setcond and movcond

2009-12-19 Thread Richard Henderson
It has been compile tested, but nothing else. I'm moderately surprised at the implementation of brcond. It's missing the BLTZ, BLEZ, BGTZ, BGEZ branches. It's could be improved with the SLTI and SLTIU insns used here with setcond. Indeed, I suspect that a good implementation of brcond would be

[Qemu-devel] [PATCH 3/3] tcg-mips: Implement movcond.

2009-12-19 Thread Richard Henderson
--- tcg/mips/tcg-target.c | 119 - 1 files changed, 117 insertions(+), 2 deletions(-) diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c index 2a2913d..123a7af 100644 --- a/tcg/mips/tcg-target.c +++ b/tcg/mips/tcg-target.c @@ -297,6 +297,8

[Qemu-devel] [PATCH 1/3] tcg: Add tcg_swap_cond.

2009-12-19 Thread Richard Henderson
Returns the condition as if with swapped comparison operands. --- tcg/tcg.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 376d6af..ac38390 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -205,11 +205,19 @@ typedef enum { TCG_COND_GTU, }

[Qemu-devel] [PATCH 2/3] tcg-mips: Implement setcond, setcond2.

2009-12-19 Thread Richard Henderson
--- tcg/mips/tcg-target.c | 177 + 1 files changed, 177 insertions(+), 0 deletions(-) diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c index 8fcb5c9..2a2913d 100644 --- a/tcg/mips/tcg-target.c +++ b/tcg/mips/tcg-target.c @@ -274,6 +274,8

Re: [Qemu-devel] [PATCH] PPC: Use interrupts for escc

2009-12-19 Thread Alexander Graf
Am 19.12.2009 um 22:58 schrieb Andreas Färber : Am 18.12.2009 um 23:37 schrieb Alexander Graf: When using the escc with Linux, we need interrupts. So instead of creating a dummy device, let's just map them to the openpic we have anyways. This makes Linux on PPC64 with console=ttyPZ0 work.

Re: [Qemu-devel] [PATCH] PPC: Use interrupts for escc

2009-12-19 Thread Andreas Färber
Am 18.12.2009 um 23:37 schrieb Alexander Graf: When using the escc with Linux, we need interrupts. So instead of creating a dummy device, let's just map them to the openpic we have anyways. This makes Linux on PPC64 with console=ttyPZ0 work. With these patches and OpenBIOS r646, booting 'in

Re: [Qemu-devel] [PATCH 5/7] tcg-sparc: Implement setcond, movcond, setcond2, brcond2.

2009-12-19 Thread Blue Swirl
On Sat, Dec 19, 2009 at 5:47 PM, Richard Henderson wrote: > On 12/19/2009 02:31 AM, Blue Swirl wrote: >>> >>>  static inline void tcg_out_movi_imm32(TCGContext *s, int ret, uint32_t >>> arg) >>>  { >>> -    if (check_fit_tl(arg, 12)) >>> +    if (check_fit_tl(arg, 13)) >>>         tcg_out_movi_imm

[Qemu-devel] [PATCH 3/6] tcg-sparc: Use TCG_TARGET_REG_BITS in conditional compilation.

2009-12-19 Thread Richard Henderson
The test TCG_TARGET_REG_BITS==64 is exactly the feature that we are checking for, whereas something involving __sparc_v9__ or __sparc_v8plus__ should be reserved for something ISA related, as with SMULX. --- tcg/sparc/tcg-target.c | 32 1 files changed, 16 insert

[Qemu-devel] [PATCH 0/6] tcg sparc improvements

2009-12-19 Thread Richard Henderson
Here's a split up version of the patch you looked at yesterday. r~ Richard Henderson (6): tcg-sparc: Fix imm13 check in movi. tcg-sparc: Improve tcg_out_movi for sparc64. tcg-sparc: Use TCG_TARGET_REG_BITS in conditional compilation. tcg: Add tcg_unsigned_cond. tcg-sparc: Implement b

[Qemu-devel] [PATCH 6/6] tcg-sparc: Implement setcond, movcond, setcond2.

2009-12-19 Thread Richard Henderson
For the time being, the movcond opcodes are protected by MOVCOND_PATCH_APPLIED. But since setcond largely depends on movcond, it didn't seem worthwhile to spend too much effort splitting this into two patches. Hopefully we can simply resolve the issue of what to do with movcond before having to i

[Qemu-devel] [PATCH 1/6] tcg-sparc: Fix imm13 check in movi.

2009-12-19 Thread Richard Henderson
We were unnecessarily restricting imm13 constants to 12 bits. --- tcg/sparc/tcg-target.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 23cd9cd..b480ed6 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-target.c

[Qemu-devel] [PATCH 2/6] tcg-sparc: Improve tcg_out_movi for sparc64.

2009-12-19 Thread Richard Henderson
Generate sign-extended 32-bit constants with SETHI+XOR. Otherwise tidy the routine to avoid the need for conditional compilation and code duplication with movi_imm32. --- tcg/sparc/tcg-target.c | 27 +++ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/tcg

[Qemu-devel] [PATCH 4/6] tcg-sparc: Implement brcond2.

2009-12-19 Thread Richard Henderson
Split out tcg_out_cmp and properly handle immediate arguments. Fix constraints on brcond to match what SUBCC accepts. Add tcg_out_brcond2_i32 for 32-bit host. --- tcg/sparc/tcg-target.c | 83 +++ 1 files changed, 69 insertions(+), 14 deletions(-) diff

[Qemu-devel] [PATCH 5/6] tcg: Add tcg_unsigned_cond.

2009-12-19 Thread Richard Henderson
Returns an unsigned version of a signed condition; returns the original condition otherwise. --- tcg/tcg.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 376d6af..b218abe 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -210,6 +210,11 @@ static in

[Qemu-devel] [FOR 0.12][PATCH] Multiboot support: Fix rom_copy

2009-12-19 Thread Kevin Wolf
ROMs need to be loaded if they are anywhere in the requested area, not only at the very beginning. This fixes Multiboot with ELF kernels that have more than one program header. Signed-off-by: Kevin Wolf --- hw/loader.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-19 Thread Richard Henderson
Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. Signed-off-by: Richard Henderson --- tcg/README| 20 +++- tcg/tcg-op.h | 47 +++ tcg/tcg-opc.h |3 +++ tcg/tcg.c | 21 +++-- 4 files changed

[Qemu-devel] [PATCH 4/5] tcg: Add tcg_invert_cond.

2009-12-19 Thread Richard Henderson
It is very handy to have a reliable mapping of a condition to its inverse. Signed-off-by: Richard Henderson --- tcg/tcg.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 9824493..376d6af 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -205,6 +20

[Qemu-devel] [PATCH 5/5] tcg-i386: Implement setcond.

2009-12-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 73 +++-- 1 files changed, 70 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 4c42caf..43e0155 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i3

[Qemu-devel] [PATCH 3/5] tcg-i386: Implement small forward branches.

2009-12-19 Thread Richard Henderson
There are places, like brcond2, where we know that the destination of a forward branch will be within 127 bytes. Add the R_386_PC8 relocation type to support this. Add a flag to tcg_out_jxx and tcg_out_brcond* to enable it. Set the flag in the brcond2 label_next branches; pass along the input fl

[Qemu-devel] [PATCH 0/5] tcg conditional set, round 4

2009-12-19 Thread Richard Henderson
Changes from round 3: * Drop movcond for now. * Only use movzbl and not xor in setcond. r~ Richard Henderson (5): tcg: Generic support for conditional set tcg-x86_64: Implement setcond. tcg-i386: Implement small forward branches. tcg: Add tcg_invert_cond. tcg-i386: Implement setcon

[Qemu-devel] [PATCH 2/5] tcg-x86_64: Implement setcond.

2009-12-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/x86_64/tcg-target.c | 38 +- 1 files changed, 33 insertions(+), 5 deletions(-) diff --git a/tcg/x86_64/tcg-target.c b/tcg/x86_64/tcg-target.c index 2339091..33dc452 100644 --- a/tcg/x86_64/tcg-target.c +++ b/tcg/x86_6

Re: [Qemu-devel] [PATCH 5/7] tcg-sparc: Implement setcond, movcond, setcond2, brcond2.

2009-12-19 Thread Richard Henderson
On 12/19/2009 02:31 AM, Blue Swirl wrote: static inline void tcg_out_movi_imm32(TCGContext *s, int ret, uint32_t arg) { -if (check_fit_tl(arg, 12)) +if (check_fit_tl(arg, 13)) tcg_out_movi_imm13(s, ret, arg); IIRC sign extension prevents this. Pardon? check_fit_tl checks

Re: [Qemu-devel] [PATCH] Add SH4 ELF magic into qemu-binfmt-conf.sh.

2009-12-19 Thread Aurelien Jarno
On Wed, Dec 16, 2009 at 11:03:42PM +0100, David Kozub wrote: > > Signed-off-by: David Kozub > --- > qemu-binfmt-conf.sh |9 - > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/qemu-binfmt-conf.sh b/qemu-binfmt-conf.sh > index ba916ac..9c65c9a 100644 > --- a/qemu-binf

Re: [Qemu-devel] [PATCH] Drop --whole-archive and static libraries

2009-12-19 Thread Andreas Färber
Hello Anthony, These two patches were already the fourth proposed solution to eliminate --whole-archive issues on Solaris. The last one was limited to CONFIG_SOLARIS, and if accepted a 0.12 candidate from my view; this one is a major rework of the build system to drop static libraries alt

Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Richard Henderson
On 12/19/2009 05:03 AM, Aurelien Jarno wrote: - For the movcond instruction, is there a real use for vtrue and vfalse values? Most CPU actually implement a version with one value. Implementing it with two values moves complexity within the arch specific tcg code. The reason I added bot

Re: [Qemu-devel] Re: tcg conditional set/move, round 3

2009-12-19 Thread Richard Henderson
On 12/19/2009 03:40 AM, Laurent Desnogues wrote: BTW for compiling to 32-bit on a 64-bit x86, the configure script is broken as it checks gcc before having set -m32, so passing -march=i686 will make it fail (in the end it means I could not convince QEMU to use cmov :-). One of my servers has a

Re: [Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 03:48:52PM +, Blue Swirl wrote: > On Sat, Dec 19, 2009 at 3:34 PM, Aurelien Jarno wrote: > > On Sat, Dec 19, 2009 at 03:19:02PM +, Blue Swirl wrote: > >> On Sat, Dec 19, 2009 at 1:05 PM, Aurelien Jarno > >> wrote: > >> > On Sat, Dec 19, 2009 at 10:08:43AM +, B

Re: [Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-19 Thread Blue Swirl
On Sat, Dec 19, 2009 at 3:58 PM, Aurelien Jarno wrote: > On Sat, Dec 19, 2009 at 04:34:22PM +0100, Aurelien Jarno wrote: >> On Sat, Dec 19, 2009 at 03:19:02PM +, Blue Swirl wrote: >> > On Sat, Dec 19, 2009 at 1:05 PM, Aurelien Jarno >> > wrote: >> > > On Sat, Dec 19, 2009 at 10:08:43AM +

Re: [Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 04:34:22PM +0100, Aurelien Jarno wrote: > On Sat, Dec 19, 2009 at 03:19:02PM +, Blue Swirl wrote: > > On Sat, Dec 19, 2009 at 1:05 PM, Aurelien Jarno > > wrote: > > > On Sat, Dec 19, 2009 at 10:08:43AM +, Blue Swirl wrote: > > >> On Sat, Dec 19, 2009 at 12:44 AM, J

Re: [Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-19 Thread Blue Swirl
On Sat, Dec 19, 2009 at 3:34 PM, Aurelien Jarno wrote: > On Sat, Dec 19, 2009 at 03:19:02PM +, Blue Swirl wrote: >> On Sat, Dec 19, 2009 at 1:05 PM, Aurelien Jarno wrote: >> > On Sat, Dec 19, 2009 at 10:08:43AM +, Blue Swirl wrote: >> >> On Sat, Dec 19, 2009 at 12:44 AM, Juan Quintela >

Re: [Qemu-devel] [PATCH] target-alpha: Emit tcg debug_insn_start.

2009-12-19 Thread Aurelien Jarno
On Wed, Dec 16, 2009 at 06:33:05PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-alpha/translate.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/target-alpha/translate.c b/target-alpha/translate.c > index 45cb697..ceff9bf 100

Re: [Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 03:19:02PM +, Blue Swirl wrote: > On Sat, Dec 19, 2009 at 1:05 PM, Aurelien Jarno wrote: > > On Sat, Dec 19, 2009 at 10:08:43AM +, Blue Swirl wrote: > >> On Sat, Dec 19, 2009 at 12:44 AM, Juan Quintela > >> wrote: > >> > "Kirill A. Shutemov" wrote: > >> >> ping?

[Qemu-devel] [Fwd: qemu-0.11.1 / tap device bug]

2009-12-19 Thread Victor Dorneanu
Hi there! I send you some bug report I've reported to NetBSD's mailing lists. -- Victor Dorneanu --- Begin Message --- Hello there! I don't know if you can remember this thread [1]. Whenever I tried to use some previously configured TAP device, I got a segmentation fault. I thought it could so

Re: [Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-19 Thread Blue Swirl
On Sat, Dec 19, 2009 at 1:05 PM, Aurelien Jarno wrote: > On Sat, Dec 19, 2009 at 10:08:43AM +, Blue Swirl wrote: >> On Sat, Dec 19, 2009 at 12:44 AM, Juan Quintela wrote: >> > "Kirill A. Shutemov" wrote: >> >> ping? >> > >> > Blue or Anthony, please apply. >> > Patch is needed to get libuser

[Qemu-devel] eepro100.c patches

2009-12-19 Thread Stefan Weil
Hi, these patches are still missing in QEMU master (and would also be good for 0.12.x because many people wait for the multicast fix needed for junos, see "junos qemu eepro100.c" at google): 089c60f8e467cfd567a946e005f10559b2fb9462 f925f386761fe1abb82aad8472c6fb388b022756 5a89b50ef52e7c9c3cf07263

Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 02:03:46PM +0100, Aurelien Jarno wrote: > On Fri, Dec 18, 2009 at 01:38:24PM -0800, Richard Henderson wrote: > > On 12/18/2009 03:37 AM, Laurent Desnogues wrote: > >>> tcg: Generic support for conditional set and conditional move. > >> > >> Needs cosmetics changes. > > > >

Re: [Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:08:43AM +, Blue Swirl wrote: > On Sat, Dec 19, 2009 at 12:44 AM, Juan Quintela wrote: > > "Kirill A. Shutemov" wrote: > >> ping? > > > > Blue or Anthony, please apply. > > Patch is needed to get libuser + pie working well. > > 0.12.0 has been tagged, but I think th

Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Aurelien Jarno
On Fri, Dec 18, 2009 at 01:38:24PM -0800, Richard Henderson wrote: > On 12/18/2009 03:37 AM, Laurent Desnogues wrote: >>> tcg: Generic support for conditional set and conditional move. >> >> Needs cosmetics changes. > > Fixed, attachment 1. > >>> tcg-x86_64: Implement setcond and movcond. >> >>

Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Andreas Färber
Hello, Am 18.12.2009 um 22:38 schrieb Richard Henderson: jmps.txt> Please send patches inline (and one patch per mail, like your original series), then a) you get more review comments and b) we can apply the patches with git-am (including your description) for testing. You can use git-send

Re: [Qemu-devel] [PATCH 4/8] fw_cfg: add API for file transfer.

2009-12-19 Thread Blue Swirl
On Fri, Dec 18, 2009 at 11:01 AM, Gerd Hoffmann wrote: > This patch adds a file transfer interface to fw_cfg.  Intended to be > used for passing non-pci option roms and vgabios to seabios.  Namespace > is modeled after the existing cbfs filesystem support in seabios. > > Reading the new FW_CFG_FIL

[Qemu-devel] Re: tcg conditional set/move, round 3

2009-12-19 Thread Laurent Desnogues
On Fri, Dec 18, 2009 at 10:38 PM, Richard Henderson wrote: > On 12/18/2009 03:37 AM, Laurent Desnogues wrote: >>> >>>  tcg: Generic support for conditional set and conditional move. >> >> Needs cosmetics changes. > > Fixed, attachment 1. > >>>  tcg-x86_64: Implement setcond and movcond. >> >> Some

Re: [Qemu-devel] [PATCH 1/8] Support PCI based option rom loading

2009-12-19 Thread Blue Swirl
On Fri, Dec 18, 2009 at 11:01 AM, Gerd Hoffmann wrote: > From: Anthony Liguori > > Currently, we preload option roms into the option rom space in memory.  This > prevents DDIM from functioning correctly which severely limits the number > of roms we can support. > > This patch introduces a pci_add

Re: [Qemu-devel] CELF Project Proposal - Device tree support for QEMU system emulation.

2009-12-19 Thread Blue Swirl
On Thu, Dec 17, 2009 at 4:46 AM, Rob Landley wrote: > For background of CELF project proposals, see: > >  http://elinux.org/CELF_Open_Project_Proposal_2010 > > Summary: > > Integrate a flattened device tree parser into the emulator QEMU, so QEMU can > create board emulations on the fly (at runtime

[Qemu-devel] Re: [sparc32] do_unassigned_access vs. cpu_sparc_handle_mmu_fault

2009-12-19 Thread Blue Swirl
On Wed, Dec 16, 2009 at 7:11 PM, Artyom Tarasenko wrote: > The function do_unassigned_access in op_helper.c looks very similar >  to the function cpu_sparc_handle_mmu_fault in helper.c and it is > called after the later one. > > Why do we need to set env->mmuregs[3] and env->mmuregs[4]  twice? > S

Re: [Qemu-devel] Solaris 2.6 as a Guest O/S

2009-12-19 Thread Blue Swirl
On Wed, Dec 16, 2009 at 2:10 PM, wrote: > Hi, > Sorry if I can already find this answer somwhere on the Qemu site, but I > really would like to find out if QEMU support Solaris 2.6 as a Guest > operating system but can't find the answer. The status page links to official supported guest OS lis

Re: [Qemu-devel] [PATCH 5/7] tcg-sparc: Implement setcond, movcond, setcond2, brcond2.

2009-12-19 Thread Blue Swirl
On Wed, Dec 16, 2009 at 11:26 PM, Richard Henderson wrote: > An initial cut at conditional moves for the sparc backend. > > Untested, as I don't have sparc hardware and the build system > resists attempts at cross-compilation. I can try if you have a test case. > Note fixes to tcg_out_movi_imm32

[Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-19 Thread Blue Swirl
On Sat, Dec 19, 2009 at 12:44 AM, Juan Quintela wrote: > "Kirill A. Shutemov" wrote: >> ping? > > Blue or Anthony, please apply. > Patch is needed to get libuser + pie working well. 0.12.0 has been tagged, but I think this is still good candidate material for 0.12.1.