Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Gleb Natapov
On Thu, Nov 26, 2009 at 02:48:46AM -0500, Kevin O'Connor wrote: > On Thu, Nov 26, 2009 at 09:20:34AM +0200, Gleb Natapov wrote: > > On Thu, Nov 26, 2009 at 02:15:27AM -0500, Kevin O'Connor wrote: > > > Now, if the bios is reloaded, the jump to the resume vector will skip > > > ide, bios table, and

[Qemu-devel] MPC5200

2009-11-25 Thread joe
Hi, is anyone working on support for MCP5200 and its peripherals? I'am interested in implementing SoC support for this device. Is there any further documentation for developing new machine emulation (beside source code of course)? Thanks, Joerg

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Kevin O'Connor
On Thu, Nov 26, 2009 at 09:20:34AM +0200, Gleb Natapov wrote: > On Thu, Nov 26, 2009 at 02:15:27AM -0500, Kevin O'Connor wrote: > > Now, if the bios is reloaded, the jump to the resume vector will skip > > ide, bios table, and other internal state setup. So, later calls to > > the bios will likely

[Qemu-devel] Re: [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread Jan Kiszka
H. Peter Anvin wrote: ... > diff --git a/qemu-options.hx b/qemu-options.hx > index b65fd74..92ade30 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1586,6 +1586,17 @@ The default device is @code{vc} in graphical mode and > @code{stdio} in > non graphical mode. > ETEXI > > +DEF("de

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-25 Thread Gleb Natapov
On Wed, Nov 25, 2009 at 09:09:19PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Tue, Nov 24, 2009 at 10:57:02AM -0500, Kevin O'Connor wrote: > >> > >>That said, I think SeaBIOS should autodetect any values where that's > >>feasible. So, for example, if the cpu identification is avai

[Qemu-devel] Re: [PATCH 2/3 v5] Block live migration

2009-11-25 Thread Jan Kiszka
Liran Schour wrote: > jan.kis...@web.de wrote on 25/11/2009 00:55:57: > > >> trying to understand the code and fixing some cosmetic issues around >> progress reporting, one potentially performance-relevant question popped > up: >> lir...@il.ibm.com wrote: >>> diff --git a/block-migration.c b/bloc

Re: [Qemu-devel] [sneak preview] major scsi overhaul

2009-11-25 Thread Hannes Reinecke
Gerd Hoffmann wrote: > On 11/24/09 14:51, Paul Brook wrote: >> On Tuesday 24 November 2009, Gerd Hoffmann wrote: >>> On 11/16/09 19:53, Paul Brook wrote: Capping the amount of memory required for a transfer *is* implemented, in both LSI and virtio-blk. The exception being SCSI passt

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Gleb Natapov
On Thu, Nov 26, 2009 at 02:15:27AM -0500, Kevin O'Connor wrote: > On Thu, Nov 26, 2009 at 08:49:25AM +0200, Gleb Natapov wrote: > > On Wed, Nov 25, 2009 at 05:53:49PM -0500, Kevin O'Connor wrote: > > > * If qemu does reload the bios (a hard-reset) then there is a good > > > chance that old DOS pr

[Qemu-devel] Re: [PATCH 2/3 v5] Block live migration

2009-11-25 Thread Liran Schour
jan.kis...@web.de wrote on 25/11/2009 00:55:57: > trying to understand the code and fixing some cosmetic issues around > progress reporting, one potentially performance-relevant question popped up: > > lir...@il.ibm.com wrote: > > diff --git a/block-migration.c b/block-migration.c > > new file m

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Kevin O'Connor
On Thu, Nov 26, 2009 at 08:49:25AM +0200, Gleb Natapov wrote: > On Wed, Nov 25, 2009 at 05:53:49PM -0500, Kevin O'Connor wrote: > > * If qemu does reload the bios (a hard-reset) then there is a good > > chance that old DOS programs will break when they invoke a reset in > > an attempt to switch

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Gleb Natapov
On Wed, Nov 25, 2009 at 05:53:49PM -0500, Kevin O'Connor wrote: > On Wed, Nov 25, 2009 at 11:04:20PM +0100, Sebastian Herbszt wrote: > >> Do different things during reset depending on CMOS values doesn't sound > >> right to me. I don't know what is implemented right now. I thought that > >> we relo

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Gleb Natapov
On Wed, Nov 25, 2009 at 11:04:20PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Wed, Nov 25, 2009 at 06:09:51AM +, Jamie Lokier wrote: > >>Gleb Natapov wrote: > >>> > But QEMU is used to run old OSes too. > >>> > > That's OK. I don't expect BIOS to be reloaded if OS > >>restart b

[Qemu-devel] Re: [PATCH 0/4] pci: interrupt status/interrupt disable support

2009-11-25 Thread Isaku Yamahata
On Wed, Nov 25, 2009 at 06:58:34PM +0200, Michael S. Tsirkin wrote: > This patchset adds support for mandatory interupt > status and interrupt disable bits to all > PCI devices. This is required for PCI compliancy. > > These patches are on top of my pci tree, > including Isaku Yamahata's fixes. >

[Qemu-devel] Re: [PATCH 4/4] pci: interrupt disable bit support

2009-11-25 Thread Isaku Yamahata
On Wed, Nov 25, 2009 at 06:59:06PM +0200, Michael S. Tsirkin wrote: > interrupt disable bit is mandatory in PCI spec, > so we must implement it to be spec compliant. > > Signed-off-by: Michael S. Tsirkin > --- > hw/pci.c | 57 - > hw/pci.

[Qemu-devel] Socket reconnection.

2009-11-25 Thread Ian Molton
Hi folks, I need my source of data for virtio-rng to be reliable - IOW. if the server dies and comes back up, I want qemu to reconnect and suck down fresh entropy, rather than hand the rngd process on the guest. I'm using the chardev 'socket' type to make the connection to the host. Would a patc

Re: [Qemu-devel] [PATCH] virtio: Add virtio-rng driver

2009-11-25 Thread Ian Molton
Ian Molton wrote: > This patch adds support for virtio-rng. Data is read from a chardev and > can be either raw entropy or received via the EGD protocol. No comments?

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 23:31, H. Peter Anvin wrote: On 11/25/2009 02:26 PM, H. Peter Anvin wrote: As such, I think there is still a place for the simple command line options like "-hda", "-serial" and my proposed "-debugcon", in addition to the full-featured connect-anything options and configuration file

[Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread H. Peter Anvin
From: H. Peter Anvin Add generic support for debugging consoles (simple I/O ports which when written to cause debugging output to be written to a target.) The current implementation matches Bochs' port 0xe9, allowing the same debugging code to be used for both Bochs and Qemu. There is no vm stat

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Kevin O'Connor
On Wed, Nov 25, 2009 at 11:04:20PM +0100, Sebastian Herbszt wrote: >> Do different things during reset depending on CMOS values doesn't sound >> right to me. I don't know what is implemented right now. I thought that >> we reload BIOS on reset. > > Currently the BIOS seems to be only loaded once an

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread H. Peter Anvin
On 11/25/2009 02:26 PM, H. Peter Anvin wrote: > > As such, I think there is still a place for the simple command line > options like "-hda", "-serial" and my proposed "-debugcon", in addition > to the full-featured connect-anything options and configuration files. > That's all. > I guess one que

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread H. Peter Anvin
On 11/25/2009 02:21 PM, Gerd Hoffmann wrote: > > You can happily mixup things as you like. Use pure command line. Use > pure config file (well, at least is that the plan, it doesn't fully work > yet). Mix cmd line switches and config file. Reading multiple config > files works just fine too

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 19:01, H. Peter Anvin wrote: Gerd Hoffmann wrote: You can stick it into a config file[1] like this: [chardev "debuglog"] backend = "file" path = "/path/to/debug.log" [device] driver = "isa-debugcon" chardev = "debuglog" Then use "qemu -readconfig $file". Great... at least in m

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Sebastian Herbszt
Kevin O'Connor wrote: On Wed, Nov 25, 2009 at 02:20:39PM +0200, Gleb Natapov wrote: On Wed, Nov 25, 2009 at 06:09:51AM +, Jamie Lokier wrote: > But the BIOS must be reloaded from ROM, I'm guessing, if the keyboard > controller method is used and the word asking for a branch back to the > app

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Sebastian Herbszt
Gleb Natapov wrote: On Wed, Nov 25, 2009 at 06:09:51AM +, Jamie Lokier wrote: Gleb Natapov wrote: > > But QEMU is used to run old OSes too. > > > That's OK. I don't expect BIOS to be reloaded if OS restart by jumping > to BIOS reset code. That's good then. What about DOS and DOS-extender

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Sebastian Herbszt
Jamie Lokier wrote: What about DOS and DOS-extender programs which do a soft reset by triple-faulting the CPU (see Sebastian's notes on i440FX behaviour), and asking the keyboard controller? Both of those methods are used by DOS and DOS-extender programs to switch from protected mode to real mod

[Qemu-devel] [PATCH] Remove rule for config-devices.h

2009-11-25 Thread Stefan Weil
Since commit a992fe3d0fc185112677286f7a02204d8245b61e config-devices.h is no longer used. So there is no need to keep the dependency rules any longer. Signed-off-by: Stefan Weil --- Makefile.target |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/Makefile.target b/Make

Re: [Qemu-devel] [PATCH 09/44] net: introduce qemu_new_net_client()

2009-11-25 Thread Blue Swirl
On Wed, Nov 25, 2009 at 6:49 PM, Mark McLoughlin wrote: > A replacement for qemu_new_vlan_client(), using NetClientInfo to > replace most arguments. > +VLANClientState *qemu_new_net_client(NetClientInfo *info, > +                                     VLANState *vlan, > +                          

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-25 Thread Sebastian Herbszt
Gleb Natapov wrote: On Tue, Nov 24, 2009 at 10:57:02AM -0500, Kevin O'Connor wrote: That said, I think SeaBIOS should autodetect any values where that's feasible. So, for example, if the cpu identification is available via cpuid, then I think that should be used. However, for example, if cpu

[Qemu-devel] [PATCH 31/44] net: convert stellaris to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/stellaris_enet.c | 34 +++--- 1 files changed, 19 insertions(+), 15 deletions(-) diff --git a/hw/stellaris_enet.c b/hw/stellaris_enet.c index 2252f1a..d1d755e 100644 --- a/hw/stellaris_enet.c +++ b/hw/stellaris_enet.c @@ -66,7 +

[Qemu-devel] [PATCH 44/44] net: fix vnet_hdr handling in solaris tap code

2009-11-25 Thread Mark McLoughlin
Print an error if the user specifies vnet_hdr=1 on the cmdline. Signed-off-by: Mark McLoughlin --- net/tap-solaris.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/net/tap-solaris.c b/net/tap-solaris.c index ef4e60c..e14fe36 100644 --- a/net/tap-solaris.c +++

[Qemu-devel] [PATCH 29/44] net: convert musicpal to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/musicpal.c | 31 ++- 1 files changed, 18 insertions(+), 13 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index 264669f..4a33e28 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -151,7 +151,7 @@ typedef struct mv88w861

[Qemu-devel] [PATCH 16/44] net: convert dump to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/dump.c | 47 +++ 1 files changed, 27 insertions(+), 20 deletions(-) diff --git a/net/dump.c b/net/dump.c index 05a102b..4ed3f5f 100644 --- a/net/dump.c +++ b/net/dump.c @@ -28,7 +28,7 @@ #include "qemu-log.h"

[Qemu-devel] [PATCH 24/44] net: convert dp8393x to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/dp8393x.c | 41 + 1 files changed, 25 insertions(+), 16 deletions(-) diff --git a/hw/dp8393x.c b/hw/dp8393x.c index 5143cc8..be9714d 100644 --- a/hw/dp8393x.c +++ b/hw/dp8393x.c @@ -154,7 +154,8 @@ typedef struct dp8

[Qemu-devel] [PATCH 08/44] net: introduce NetClientInfo

2009-11-25 Thread Mark McLoughlin
This structure holds data which is common to all instances of a given net client type/model. Signed-off-by: Mark McLoughlin --- net.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/net.h b/net.h index 9ffcfe3..56c5849 100644 --- a/net.h +++ b/net.h @@ -42,6 +

[Qemu-devel] [PATCH 18/44] net: convert virtio to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/virtio-net.c | 73 +- 1 files changed, 39 insertions(+), 34 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 2f147e5..4f8d89e 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -31,7 +

[Qemu-devel] [PATCH 15/44] net: convert socket to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/socket.c | 74 +++-- 1 files changed, 45 insertions(+), 29 deletions(-) diff --git a/net/socket.c b/net/socket.c index 551fc2b..7331d87 100644 --- a/net/socket.c +++ b/net/socket.c @@ -33,7 +33,7 @@ #in

[Qemu-devel] [PATCH 20/44] net: convert rtl8139 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/rtl8139.c | 43 --- 1 files changed, 24 insertions(+), 19 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index c166db0..931cde9 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -459,7 +459,7 @@ typedef struct R

[Qemu-devel] [PATCH] virtio-blk: add max sectors feature

2009-11-25 Thread Avishay Traeger1
This is a patch to have the guest virtio-blk driver get the value for the maximum I/O size from the host bdrv, rather than assume that there is no limit. Right now we use it for an in-house bdrv driver that needs this option. The patches are below, against the latest gits, split into kernel (kvm

[Qemu-devel] [PATCH 19/44] net: convert e1000 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/e1000.c | 47 ++- 1 files changed, 26 insertions(+), 21 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 00f6a57..683fdcc 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -75,7 +75,7 @@ enum { typedef struct

[Qemu-devel] [PATCH 30/44] net: convert smc91c111 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/smc91c111.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/hw/smc91c111.c b/hw/smc91c111.c index b7398c9..c1a88c9 100644 --- a/hw/smc91c111.c +++ b/hw/smc91c111.c @@ -18,7 +18,7 @@ typedef struc

[Qemu-devel] [PATCH 23/44] net: convert eepro100 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/eepro100.c | 43 --- 1 files changed, 24 insertions(+), 19 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 8734907..eb16a51 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -195,7 +195,7 @@ typedef str

[Qemu-devel] [PATCH 37/44] net: remove VLANClientState members now in NetClientInfo

2009-11-25 Thread Mark McLoughlin
Add a NetClientInfo pointer to VLANClientState and use that for the typecode and function pointers. Signed-off-by: Mark McLoughlin --- hw/dp8393x.c|4 ++-- hw/virtio-net.c |2 +- net.c | 45 - net.h | 10 +-

[Qemu-devel] [PATCH 27/44] net: convert mcf_fec to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/mcf_fec.c | 58 +- 1 files changed, 33 insertions(+), 25 deletions(-) diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c index 8242c8a..4e7fbed 100644 --- a/hw/mcf_fec.c +++ b/hw/mcf_fec.c @@ -25,7 +25,8 @@ do

[Qemu-devel] [PATCH 42/44] net: check for TUNSETOFFLOAD support before trying to enable offload features

2009-11-25 Thread Mark McLoughlin
From: Pierre Riteau This avoids the "TUNSETOFFLOAD ioctl() failed: Invalid argument" message on kernels without TUNSETOFFLOAD support. Signed-off-by: Pierre Riteau Signed-off-by: Mark McLoughlin --- net/tap-linux.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/n

[Qemu-devel] [PATCH 25/44] net: convert etrax to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/etraxfs_eth.c | 45 +++-- 1 files changed, 27 insertions(+), 18 deletions(-) diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c index 2cc2332..dedd107 100644 --- a/hw/etraxfs_eth.c +++ b/hw/etraxfs_eth.c @@ -319,7 +319

[Qemu-devel] [PATCH 43/44] net: initialize vnet_hdr in net_init_tap()

2009-11-25 Thread Mark McLoughlin
net_tap_init() always sets vnet_hdr using qemu_opt_get_bool(), but initialize it in net_init_tap() just to reduce confusion. Signed-off-by: Mark McLoughlin --- net/tap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/tap.c b/net/tap.c index a327a9a..0d8b424 100644

[Qemu-devel] [PATCH 32/44] net: convert usb-net to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/usb-net.c | 57 +++-- 1 files changed, 31 insertions(+), 26 deletions(-) diff --git a/hw/usb-net.c b/hw/usb-net.c index 7b8cc7a..2556e05 100644 --- a/hw/usb-net.c +++ b/hw/usb-net.c @@ -610,7 +610,6 @@ ty

[Qemu-devel] [PATCH 40/44] net: print correct error for '-netdev ""'

2009-11-25 Thread Mark McLoughlin
Reported-by: Markus Armbruster Signed-off-by: Mark McLoughlin --- net.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/net.c b/net.c index c71699d..13bdbb2 100644 --- a/net.c +++ b/net.c @@ -1055,12 +1055,18 @@ int net_client_init(Monitor *mon, QemuOpts

[Qemu-devel] [PATCH 38/44] net: add qemu_foreach_nic()

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net.c | 20 net.h |2 ++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index a1ec243..c71699d 100644 --- a/net.c +++ b/net.c @@ -326,6 +326,26 @@ qemu_find_vlan_client_by_name(Monitor *mon, int vlan_id,

[Qemu-devel] [PATCH 36/44] net: remove qemu_new_vlan_client()

2009-11-25 Thread Mark McLoughlin
... and VLANClientState::opaque and qemu_find_vlan_client(). All of these are now unused Signed-off-by: Mark McLoughlin --- net.c | 44 net.h | 13 - 2 files changed, 0 insertions(+), 57 deletions(-) diff --git a/net.c b/net.c index

[Qemu-devel] [PATCH 33/44] net: convert xilinx_ethlite to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/xilinx_ethlite.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/hw/xilinx_ethlite.c b/hw/xilinx_ethlite.c index b7129d5..37e33ec 100644 --- a/hw/xilinx_ethlite.c +++ b/hw/xilinx_ethlite.c @@ -51,7

[Qemu-devel] [PATCH 14/44] net: convert vde to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/vde.c | 45 - 1 files changed, 28 insertions(+), 17 deletions(-) diff --git a/net/vde.c b/net/vde.c index 4d09967..42b4633 100644 --- a/net/vde.c +++ b/net/vde.c @@ -34,7 +34,7 @@ #include "sysemu.h" typedef

[Qemu-devel] [PATCH 41/44] net: fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-25 Thread Mark McLoughlin
From: Pierre Riteau vnet_hdr is initialized at 1 by default. We need to reset it to 0 if the kernel doesn't support IFF_VNET_HDR. Signed-off-by: Pierre Riteau Signed-off-by: Mark McLoughlin --- net/tap-linux.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/tap-l

[Qemu-devel] [PATCH 39/44] net: fix qemu_announce_self()

2009-11-25 Thread Mark McLoughlin
Now that we have a way to iterate NICs. Signed-off-by: Mark McLoughlin --- savevm.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/savevm.c b/savevm.c index 4668843..3cfc5aa 100644 --- a/savevm.c +++ b/savevm.c @@ -123,24 +123,24 @@ static int

[Qemu-devel] [PATCH 26/44] net: convert LAN9118 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/lan9118.c | 45 + 1 files changed, 25 insertions(+), 20 deletions(-) diff --git a/hw/lan9118.c b/hw/lan9118.c index 6394f3a..ba982d1 100644 --- a/hw/lan9118.c +++ b/hw/lan9118.c @@ -137,7 +137,7 @@ typedef struct

[Qemu-devel] [PATCH 13/44] net: convert slirp to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/slirp.c | 61 +++--- 1 files changed, 37 insertions(+), 24 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index d6d5772..3f91c4b 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -64,8 +64,8 @@ struct s

[Qemu-devel] [PATCH 05/44] net: clean up includes in net.c

2009-11-25 Thread Mark McLoughlin
This is probably a little drastic, but the includes in this file are now totally out of control when compared with what includes are actually needed. This may break the build on e.g. *BSD, but it will be easily fixed by re-instating an include. Signed-off-by: Mark McLoughlin --- net.c | 74 +-

[Qemu-devel] [PATCH 07/44] net: remove NICInfo::private

2009-11-25 Thread Mark McLoughlin
Was used by hot-unplug, but not anymore. Signed-off-by: Mark McLoughlin --- net.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/net.h b/net.h index bc8392b..9ffcfe3 100644 --- a/net.h +++ b/net.h @@ -124,7 +124,6 @@ struct NICInfo { char *devaddr; VLANState *

[Qemu-devel] [PATCH 21/44] net: convert ne2000 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/ne2000-isa.c | 22 ++ hw/ne2000.c | 35 +-- hw/ne2000.h |2 +- 3 files changed, 36 insertions(+), 23 deletions(-) diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c index 729e8e2..0260f84 100644

[Qemu-devel] [PATCH 12/44] net: convert tap-win32 to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/tap-win32.c | 39 +++ 1 files changed, 23 insertions(+), 16 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index ea66471..ef63782 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -630,25 +630,24 @@ sta

[Qemu-devel] [PATCH 22/44] net: convert pcnet to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/lance.c | 14 +++--- hw/pcnet.c | 43 +++ hw/pcnet.h |7 --- 3 files changed, 38 insertions(+), 26 deletions(-) diff --git a/hw/lance.c b/hw/lance.c index 0a96644..98033a4 100644 --- a/hw/lance.c ++

[Qemu-devel] [PATCH 35/44] net: convert xen to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/xen_nic.c | 46 +- 1 files changed, 29 insertions(+), 17 deletions(-) diff --git a/hw/xen_nic.c b/hw/xen_nic.c index bcf161c..08055b8 100644 --- a/hw/xen_nic.c +++ b/hw/xen_nic.c @@ -41,6 +41,7 @@ #include "hw.h

[Qemu-devel] [PATCH 34/44] net: move parse_macaddr() to net/util.[ch]

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |2 +- net.c | 35 ++- net/util.c | 60 net/util.h | 32 4 files changed, 95 insertions(+), 34 deletions(-) c

[Qemu-devel] [PATCH 28/44] net: convert mipsnet to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/mipsnet.c | 45 +++-- 1 files changed, 27 insertions(+), 18 deletions(-) diff --git a/hw/mipsnet.c b/hw/mipsnet.c index 67160a4..a066f63 100644 --- a/hw/mipsnet.c +++ b/hw/mipsnet.c @@ -35,7 +35,8 @@ typedef struct M

[Qemu-devel] [PATCH 11/44] net: convert tap to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/tap.c | 82 +--- 1 files changed, 45 insertions(+), 37 deletions(-) diff --git a/net/tap.c b/net/tap.c index b2e5908..d34feec 100644 --- a/net/tap.c +++ b/net/tap.c @@ -47,7 +47,7 @@ #define TAP_BUF

[Qemu-devel] [PATCH 10/44] qdev: move DO_UPCAST() into osdep.h

2009-11-25 Thread Mark McLoughlin
Nothing qdev specific about this, make it available throughtout. Signed-off-by: Mark McLoughlin --- hw/qdev.h | 10 -- osdep.h | 10 ++ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index 41642ee..8d53754 100644 --- a/hw/qdev.h +++ b

[Qemu-devel] [PATCH 17/44] net: introduce NICState and qemu_new_nic()

2009-11-25 Thread Mark McLoughlin
Common state for all NICs. The opaque member will replace the opaque member in VLANClientState since only NICs need it. The conf member will allow us to iterate over NICs, access the MAC addr for the NIC and send a packet from each NIC in qemu_announce_self(). Signed-off-by: Mark McLoughlin ---

[Qemu-devel] [PATCH 09/44] net: introduce qemu_new_net_client()

2009-11-25 Thread Mark McLoughlin
A replacement for qemu_new_vlan_client(), using NetClientInfo to replace most arguments. Signed-off-by: Mark McLoughlin --- net.c | 70 +--- net.h |5 2 files changed, 54 insertions(+), 21 deletions(-) diff --git a/net.c b/n

[Qemu-devel] [PATCH 06/44] net: remove NICInfo::vc

2009-11-25 Thread Mark McLoughlin
Since 1cc33683, this field is not set for most devices, so just remove it and its remaining few uses. Signed-off-by: Mark McLoughlin --- hw/dp8393x.c | 10 +- hw/etraxfs_eth.c | 10 +- hw/mcf_fec.c | 10 +- hw/mipsnet.c | 10 +- hw/usb-net.c

[Qemu-devel] [PATCH 01/44] net: move slirp code from net.c to net/slirp.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile|1 + monitor.c |1 + net.c | 718 +--- net.h |8 +- net/slirp.c | 752 +++ net/slirp.h | 51 vl.c|

[Qemu-devel] [PATCH 04/44] net: move dump backend code from net.c to net/dump.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c | 127 +-- net/dump.c | 151 net/dump.h | 33 + 4 files changed, 186 insertions(+), 126 deletions(-) cre

[Qemu-devel] [PATCH 02/44] net: move vde code from net.c to net/vde.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c | 102 +- net/vde.c | 124 + net/vde.h | 36 ++ 4 files changed, 162 insertions(+), 101 deletions(-) cr

[Qemu-devel] [PATCH 00/44] Fix announce_self(), misc net fixes and cleanups

2009-11-25 Thread Mark McLoughlin
Hi, Here's a new series of patches mainly to fix qemu_announce_self() with -netdev as discussed earlier on the list. I would have liked to have split the series in three, but there would be conflicts between each, so here goes: 1) Patches 01 to 05 - net.c cleanups These p

[Qemu-devel] [PATCH 03/44] net: move socket backend code from net.c to net/socket.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c| 530 +-- net/socket.c | 561 ++ net/socket.h | 33 4 files changed, 596 insertions(+), 529 deletions(-) cr

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread H. Peter Anvin
Gerd Hoffmann wrote: You can stick it into a config file[1] like this: [chardev "debuglog"] backend = "file" path = "/path/to/debug.log" [device] driver = "isa-debugcon" chardev = "debuglog" Then use "qemu -readconfig $file". Great... at least in my opinion, one of the things that

[Qemu-devel] [PATCH 3/4] pci: interrupt status bit implementation

2009-11-25 Thread Michael S. Tsirkin
interrupt status is a mandatory feature in PCI spec, so devices must implement it to be spec compliant. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 22 ++ hw/pci.h |1 + 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 77174

[Qemu-devel] [PATCH 4/4] pci: interrupt disable bit support

2009-11-25 Thread Michael S. Tsirkin
interrupt disable bit is mandatory in PCI spec, so we must implement it to be spec compliant. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 57 - hw/pci.h |4 2 files changed, 44 insertions(+), 17 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 2/4] pci: track IRQ status

2009-11-25 Thread Michael S. Tsirkin
track IRQ status in preparation for PCI_STATUS_INTERRUPT support Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 10 +- hw/pci.h |3 +++ 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 5ff0d46..7717461 100644 --- a/hw/pci.c +++ b/hw/pci.c

[Qemu-devel] [PATCH 1/4] pci: rearrange code for interrupts

2009-11-25 Thread Michael S. Tsirkin
Rearranges code slightly in preparation for interrupt status and interrupt disable support: split actual irq change from irq_state management. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 26 -- 1 files changed, 16 insertions(+), 10 deletions(-) diff --git a/hw/pci

[Qemu-devel] [PATCH 0/4] pci: interrupt status/interrupt disable support

2009-11-25 Thread Michael S. Tsirkin
This patchset adds support for mandatory interupt status and interrupt disable bits to all PCI devices. This is required for PCI compliancy. These patches are on top of my pci tree, including Isaku Yamahata's fixes. If this is a problem, let me know and I will rebase. This works fine for me, but

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Gleb Natapov
On Wed, Nov 25, 2009 at 10:31:16AM -0500, Kevin O'Connor wrote: > On Wed, Nov 25, 2009 at 02:20:39PM +0200, Gleb Natapov wrote: > > On Wed, Nov 25, 2009 at 06:09:51AM +, Jamie Lokier wrote: > > > But the BIOS must be reloaded from ROM, I'm guessing, if the keyboard > > > controller method is us

Re: [Qemu-devel] [sneak preview] major scsi overhaul

2009-11-25 Thread Gerd Hoffmann
On 11/24/09 14:51, Paul Brook wrote: On Tuesday 24 November 2009, Gerd Hoffmann wrote: On 11/16/09 19:53, Paul Brook wrote: Capping the amount of memory required for a transfer *is* implemented, in both LSI and virtio-blk. The exception being SCSI passthrough where the kernel API makes it impo

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 04:10:34PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Tue, Nov 24, 2009 at 08:33:11AM -0600, Anthony Liguori wrote: > >> Michael S. Tsirkin wrote: > >>> It's very easy: if their guest runs fine on the old qemu, > >>> it should be safe to migrate there.

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Kevin O'Connor
On Wed, Nov 25, 2009 at 02:20:39PM +0200, Gleb Natapov wrote: > On Wed, Nov 25, 2009 at 06:09:51AM +, Jamie Lokier wrote: > > But the BIOS must be reloaded from ROM, I'm guessing, if the keyboard > > controller method is used and the word asking for a branch back to the > > application has not

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 03:53:40PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Nov 25, 2009 at 02:59:58PM +0100, Gerd Hoffmann wrote: > >> On 11/25/09 14:40, Michael S. Tsirkin wrote: > >> > We could add a DeviceState->savevm field and make that available as > p

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Nov 25, 2009 at 02:59:58PM +0100, Gerd Hoffmann wrote: >> On 11/25/09 14:40, Michael S. Tsirkin wrote: >> We could add a DeviceState->savevm field and make that available as property for devices which need to support multiple versions. Then you

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 15:09, Michael S. Tsirkin wrote: We were discussing features that are (mostly) not user-visible. It is clear that if you have a user-visible change you have a different machine, so you can not migrate. Now if you fix a bug by changing savevm format, without user visible changes you *

[Qemu-devel] Re: [PATCH] kvm: x86: Add support for VCPU event states

2009-11-25 Thread Avi Kivity
On 11/25/2009 01:33 AM, Jan Kiszka wrote: This patch extends the qemu-kvm state sync logic with support for KVM_GET/SET_VCPU_EVENTS, giving access to yet missing exception, interrupt and NMI states. Looks good. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 03:10:16PM +0100, Gerd Hoffmann wrote: > Hi, > >>> Doesn't work. If you have a qemu 0.11 machine, a virtio nic and your >>> guest uses MSI-X you simply can't migrate to qemu 0.10. End of story. >>> If you want to be able to migrate to 0.10 you have to start in 0.10 >>> c

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
Hi, Doesn't work. If you have a qemu 0.11 machine, a virtio nic and your guest uses MSI-X you simply can't migrate to qemu 0.10. End of story. If you want to be able to migrate to 0.10 you have to start in 0.10 compat mode with MSI-X disabled. So IMHO it does makes sense to tie the savevm f

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 02:59:58PM +0100, Gerd Hoffmann wrote: > On 11/25/09 14:40, Michael S. Tsirkin wrote: > >>> We could add a DeviceState->savevm field and make that available as >>> property for devices which need to support multiple versions. Then you >>> we can use the compat properties to

Re: [Qemu-devel] Re: [PATCH 2/2] qdev: add command line option to set global defaults for properties.

2009-11-25 Thread Paul Brook
> So maybe add "use -device ? to get list of all devices" > to help text? > > [...@tuck qemu]$ ~/qemu-git/bin/qemu-system-x86_64 -device ? > /home/mst/qemu-git/bin/qemu-system-x86_64: invalid option -- '-device' You need to stop your shell eating the ? Paul

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 14:40, Michael S. Tsirkin wrote: We could add a DeviceState->savevm field and make that available as property for devices which need to support multiple versions. Then you we can use the compat properties to switch back to the older format with -M pc-0.10. I'm confused sorry. Of

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-25 Thread Carsten Otte
Arnd Bergmann wrote: Can't you just leave it out for this release? Early printk is great for debugging, but not essential if you just want to run a guest as long as you get it past the virtio init phase. The upstream kernel assumes to have this hypercall available when running on kvm. You won't

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 02:42:25PM +0100, Gerd Hoffmann wrote: >>> And this is also the trivial part to describe: I want a >>> machine like the one in qemu-0.11. >> >> Yes, but there might be a ton of reasons to want a >> machine like the one in qemu 0.11. >> The need to migrate to old qemu is ve

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 02:36:49PM +0100, Gerd Hoffmann wrote: > On 11/24/09 15:05, Michael S. Tsirkin wrote: >> On Mon, Nov 23, 2009 at 03:13:59PM +0100, Juan Quintela wrote: But this would only kick in when using pc-0.11 or something, right? >>> >>> Yeap. >>> >>> At this point, pc-0.10 is ju

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
And this is also the trivial part to describe: I want a machine like the one in qemu-0.11. Yes, but there might be a ton of reasons to want a machine like the one in qemu 0.11. The need to migrate to old qemu is very rare, it is a completely separate decision one might take long after starting

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Nov 25, 2009 at 10:30:47AM +0100, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> > On Tue, Nov 24, 2009 at 03:21:34PM +0100, Juan Quintela wrote: >> >> > A device already supports load for a range >> > of versions between X and Y. We want to support

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
On 11/24/09 15:05, Michael S. Tsirkin wrote: On Mon, Nov 23, 2009 at 03:13:59PM +0100, Juan Quintela wrote: But this would only kick in when using pc-0.11 or something, right? Yeap. At this point, pc-0.10 is just: static QEMUMachine pc_machine_v0_10 = { .name = "pc-0.10", .desc = "

[Qemu-devel] Re: [PATCH] Fix thinko in linuxboot.S

2009-11-25 Thread Paolo Bonzini
On 11/25/2009 01:53 PM, Alexander Graf wrote: On 25.11.2009, at 13:49, Paolo Bonzini wrote: The %gs segment that was used was not matching the comments. I just moved the GDT descriptor on the stack instead. Signed-off-by: Paolo Bonzini ^^

  1   2   >