Re: [Qemu-devel] [PATCH, RFC] mips: fix cpu_reset memory leak

2009-11-13 Thread Aurelien Jarno
On Tue, Nov 10, 2009 at 04:30:59PM +0100, Aurelien Jarno wrote: > On Sun, Nov 08, 2009 at 12:50:21PM +0200, Blue Swirl wrote: > > Both mmu_init() and mvp_init() allocate structures, so call > > cpu_mips_register > > only when creating a CPU. > > > > In addition, maybe some of the some of the fiel

Re: [Qemu-devel] Device initialisation problem: partially solved.

2009-11-13 Thread Ian Molton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Further investigation seems to have highlighted the problem: My code is correctly decoding the OPT_SIZE parameter into the 'value.uint' field in a QemuOpt I've also got the devices properties set up, so that the device may receive its data. Eg. in

[Qemu-devel] [PATCH] sparc32 irq clearing (guest Solaris performance+NetBSD) fix

2009-11-13 Thread Artyom Tarasenko
According to NCR89C105 documentation http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR89C105.txt Interrupts are cleared by disabling and then re-enabling them. This patch implements the specified behaviour. The most visible effects: - NetBSD 1.3.3 - 1.5.3 boots successfully - Sol

[Qemu-devel] Problems with qemu 0.11

2009-11-13 Thread gaetan
Hi, With qemu 0.11 I use this command : qemu-system-ppc -hda /mnt/divers/img_qemu/qemu-fw-ppc/hda.img -m 500 -vnc :3 -boot c -kernel /mnt/divers/img_qemu/qemu-fw-ppc/vmlinux-2.6.31-fw3 -append 'ro root=/dev/hda3' -redir tcp:19022::22 -net nic -net user The networks don't works and I can find

Re: [Qemu-devel] [PATCH] mips: fix CPU reset

2009-11-13 Thread Aurelien Jarno
On Fri, Nov 13, 2009 at 10:44:29PM +0200, Blue Swirl wrote: > This patch fixes the MIPS reset problem, so that using instructions > from http://www.aurel32.net/info/debian_mips_qemu.php, I get the > installer prompt. > --- > See f2d74978764f62d832d61ac17bb5d934ade58816. Thanks for this patch. It s

Re: [Qemu-devel] [PATCH] pci: Fix function pci_default_write_config

2009-11-13 Thread Ryan Harper
* Stefan Weil [2009-11-13 16:29]: > Change 260c0cd3d985e51b15870ff47e17b7b930efbda1 > (pci: use range helper functions) introduced a > bug which made pci cirrus vga on mips malta > (and maybe other pci devices) fail. > > Don't change addr - its original value is needed > by ranges_overlap() and r

[Qemu-devel] [PATCH] malta: Load kernel only during initialization

2009-11-13 Thread Stefan Weil
A 2nd load during reset is wrong and raises an assertion. Signed-off-by: Stefan Weil --- hw/mips_malta.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/mips_malta.c b/hw/mips_malta.c index 30fa6b8..094f597 100644 --- a/hw/mips_malta.c +++ b/hw/mips_malta.c @@ -758,7

[Qemu-devel] [PATCH] pci: Fix function pci_default_write_config

2009-11-13 Thread Stefan Weil
Change 260c0cd3d985e51b15870ff47e17b7b930efbda1 (pci: use range helper functions) introduced a bug which made pci cirrus vga on mips malta (and maybe other pci devices) fail. Don't change addr - its original value is needed by ranges_overlap() and range_covers(). Signed-off-by: Stefan Weil ---

Re: [Qemu-devel] [PATCH] Don't leak file descriptors

2009-11-13 Thread Blue Swirl
On Fri, Nov 13, 2009 at 5:17 PM, Kevin Wolf wrote: > We're leaking file descriptors to child processes. Set FD_CLOEXEC on file > descriptors that don't need to be passed to children to stop this > misbehaviour. > -        c = accept(s, (struct sockaddr *)&addr, &addrlen); > +        c = qemu_acc

[Qemu-devel] Re: [PATCH] sparc32 fix carry flag handling (Solaris bootblk fix)

2009-11-13 Thread Blue Swirl
On Fri, Nov 13, 2009 at 4:28 PM, Artyom Tarasenko wrote: >>> Could you describe the steps how to boot Solaris with OBP? I'm sure >>> there are a lot of people who'd like to test if their favorite Sparc >>> Solaris programs work on QEMU. > > Gathered things for which I currently have hacks here: >

[Qemu-devel] [PATCH] mips: fix CPU reset

2009-11-13 Thread Blue Swirl
This patch fixes the MIPS reset problem, so that using instructions from http://www.aurel32.net/info/debian_mips_qemu.php, I get the installer prompt. --- See f2d74978764f62d832d61ac17bb5d934ade58816. Signed-off-by: Blue Swirl --- hw/mips_malta.c | 23 +-- hw/mips_mipssim

[Qemu-devel] QMP unstable tree status

2009-11-13 Thread Luiz Capitulino
Hi there, I've updated my QMP patches to work on top of Anthony's QJSON and my conversion series. I was planning to post them as an RFC today, but turns out that there are issues to be fixed and some cleanup to be done. Anyway, it's already in the master branch of my qmp-unstable tree: htt

[Qemu-devel] [PATCH] libxl: check for early failures of qemu-dm

2009-11-13 Thread Ian Jackson
This patch makes xl create check whether qemu-dm has started correctly, and causes it to fail immediately with appropriate errors if not. There are other bugfixes too. More specifically: * libxl_create_device_model forks twice rather than once so that the process which calls libxl does not e

[Qemu-devel] Device initialisation problem:

2009-11-13 Thread Ian Molton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I'm trying to use the qption parser to parse my device option string, which is formatted like this: - -vrng dev=/dev/foo,rate=10K and I mostly got things to work by using this, in vl.c: static int virtio_rng_parse(const char *arg) { Qem

Re: [Qemu-devel] ppc64 target broken

2009-11-13 Thread Blue Swirl
On Wed, Nov 11, 2009 at 3:17 PM, Laurent Vivier wrote: > qemu-system-ppc is also broken. > > A bisect gives me: > > c169998802505c244b8bcad562633f29de7d74a4 is first bad commit > commit c169998802505c244b8bcad562633f29de7d74a4 > Author: Glauber Costa > Date:   Thu Nov 5 16:05:15 2009 -0200 This

Re: [Qemu-devel] [PATCH] Don't leak file descriptors

2009-11-13 Thread Kevin Wolf
Am 13.11.2009 16:41, schrieb Nathan Froyd: > On Fri, Nov 13, 2009 at 04:17:16PM +0100, Kevin Wolf wrote: >> We're leaking file descriptors to child processes. Set FD_CLOEXEC on file >> descriptors that don't need to be passed to children to stop this >> misbehaviour. >> >>> --- a/gdbstub.c >> +++ b

Re: [Qemu-devel] [PATCH] Don't leak file descriptors

2009-11-13 Thread Nathan Froyd
On Fri, Nov 13, 2009 at 04:17:16PM +0100, Kevin Wolf wrote: > We're leaking file descriptors to child processes. Set FD_CLOEXEC on file > descriptors that don't need to be passed to children to stop this > misbehaviour. > >> --- a/gdbstub.c > +++ b/gdbstub.c > @@ -2356,6 +2356,9 @@ static void gdb_

Re: [Qemu-devel] [PATCH] Don't leak file descriptors

2009-11-13 Thread Scott Tsai
On Fri, Nov 13, 2009 at 11:17 PM, Kevin Wolf wrote: > We're leaking file descriptors to child processes. Set FD_CLOEXEC on file > descriptors that don't need to be passed to children to stop this > misbehaviour. Since qemu is a multi threaded program, how about opening those file descriptors wit

[Qemu-devel] [PATCH] Don't leak file descriptors

2009-11-13 Thread Kevin Wolf
We're leaking file descriptors to child processes. Set FD_CLOEXEC on file descriptors that don't need to be passed to children to stop this misbehaviour. Signed-off-by: Kevin Wolf --- block/raw-posix.c |1 + gdbstub.c |6 ++ kvm-all.c |1 + migration-tcp.c|

Re: [Qemu-devel] [PATCH] experimental sh4 host support

2009-11-13 Thread malc
On Fri, 13 Nov 2009, Magnus Damm wrote: > From: Magnus Damm > > This patch adds experimental sh4 host support to QEMU. The patch > contains a work-in-progresss snapshot, and only the bare essentials > are in place at this point. The sh4 host support has been tested > with the sh4 target using th

[Qemu-devel] Re: [PATCH] sparc32 fix carry flag handling (Solaris bootblk fix)

2009-11-13 Thread Artyom Tarasenko
>> Could you describe the steps how to boot Solaris with OBP? I'm sure >> there are a lot of people who'd like to test if their favorite Sparc >> Solaris programs work on QEMU. Gathered things for which I currently have hacks here: http://tyom.blogspot.com/2009/11/things-missing-in-vanilla-qemu.ht

Re: [Qemu-devel] [PATCH 3/3] Add test suite for json marshalling

2009-11-13 Thread Anthony Liguori
Jamie Lokier wrote: Anthony Liguori wrote: After checking that we can demarshal, marshal again and compared to the expected decoded value. This doesn't work so well for floats because they cannot be accurately represented in decimal but we try our best. Good sprintf/scanf/strtod imple

Re: [Qemu-devel] [PATCH 1/9] QJSON: Introduce qobject_from_json_va()

2009-11-13 Thread Luiz Capitulino
On Thu, 12 Nov 2009 15:39:14 -0600 Anthony Liguori wrote: > Luiz Capitulino wrote: > > Accepts a va_list, will be used by QError. > > > > Signed-off-by: Luiz Capitulino > > --- > > qjson.c | 14 ++ > > qjson.h |2 ++ > > 2 files changed, 16 insertions(+), 0 deletions(-) > > >

[Qemu-devel] Re: [PATCH 1/6] Make fw_cfg interface 32-bit aware

2009-11-13 Thread Juan Quintela
Alexander Graf wrote: > On 13.11.2009, at 01:48, Glauber Costa wrote: > Because that would mean I'd have to deal with it in the code later on > and I don't see the point of writing code that's not in the load/save > cycle because of limitations there. Hi could you take a look at this one? This

[Qemu-devel] [PATCH] experimental sh4 host support

2009-11-13 Thread Magnus Damm
From: Magnus Damm This patch adds experimental sh4 host support to QEMU. The patch contains a work-in-progresss snapshot, and only the bare essentials are in place at this point. The sh4 host support has been tested with the sh4 target using the QEMU sh4 user space emulator and tiny assembly snip

[Qemu-devel] [PATCH] remove duplicate sar opcode from i386 tcg code

2009-11-13 Thread Magnus Damm
From: Magnus Damm Remove duplicate sar opcode from the i386 tcg code. Signed-off-by: Magnus Damm --- tcg/i386/tcg-target.c |1 - 1 file changed, 1 deletion(-) --- 0001/tcg/i386/tcg-target.c +++ work/tcg/i386/tcg-target.c 2009-11-13 16:34:21.0 +0900 @@ -1147,7 +1147,6 @@ static c

[Qemu-devel] [PATCH] sh4 disasm fixes

2009-11-13 Thread Magnus Damm
From: Magnus Damm Add the sh4 target to the monitor disassembly function, and remove a duplicate "0x" printout from the sh4 dis- assembly code. Signed-off-by: Magnus Damm --- disas.c |4 sh4-dis.c |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) --- 0001/disas.c +++ work

[Qemu-devel] [PATCH] fix make clean targets

2009-11-13 Thread Magnus Damm
From: Magnus Damm This patch fixes clean in case of missing directories and also adds code to distclean that removes the following files: qemu-monitor.texi roms/seabios/config.mak roms/vgabios/config.mak Signed-off-by: Magnus Damm --- Makefile |5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Qemu-devel] [PATCH 02/11] Add operations to qlist to allow it to be used as a stack

2009-11-13 Thread Kevin Wolf
Am 12.11.2009 18:13, schrieb Anthony Liguori: > Kevin Wolf wrote: >> Unfortunately. There are places where such comments could be a good >> specification on what an interface is actually meant to work like >> (particularly in error cases). Currently you often can't tell if the >> implementation or

Re: [Qemu-devel] Re: ANN: QEMU Monitor Protocol git tree

2009-11-13 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Sep 24, 2009 at 03:28:40PM +0200, Markus Armbruster wrote: >> Luiz Capitulino writes: >> >> > On Thu, 24 Sep 2009 00:37:53 +0200 >> > Markus Armbruster wrote: >> > >> >> Luiz Capitulino writes: >> >> >> >> [...] >> >> > 2.2 Server Greeting >> >> > -

Re: [Qemu-devel] [PATCH 7/7] net: fix qemu_announce_self()

2009-11-13 Thread Markus Armbruster
Mark McLoughlin writes: > Now that we have a sane way of iterating over NICs. > > Signed-off-by: Mark McLoughlin > --- > savevm.c | 43 ++- > 1 files changed, 26 insertions(+), 17 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 039740c..373658