[Python-Dev] Remove own implementation for thread-local storage

2017-07-03 Thread Masayuki YAMAMOTO
Hi, python-dev. I'd propose removing code which I think out-of-date. CPython has provided the own implementation for thread-local storage (TLS) on Python/thread.c, it's used in the case which a platform has not supplied native TLS. However, currently all supported platforms (NT and pthreads) have

Re: [Python-Dev] 64 bit units in PyLong

2017-07-03 Thread Victor Stinner
2017-07-03 6:52 GMT+02:00 Siyuan Ren : > The current PyLong implementation represents arbitrary precision integers in > units of 15 or 30 bits. I presume the purpose is to avoid overflow in > addition , subtraction and multiplication. But compilers these days offer > intrinsics that allow one to ac

Re: [Python-Dev] Remove own implementation for thread-local storage

2017-07-03 Thread Victor Stinner
I'm in favor of removing it. I know that it confused people many times, they look at this fallback and found an issue, whereas I'm not aware of any platform using this fallback anymore. Can you please write a PR just to remove this fallback? We can merge it and then check buildbots :-) So in the w

Re: [Python-Dev] Remove own implementation for thread-local storage

2017-07-03 Thread Antoine Pitrou
Also note that C11, MSVC and some Unix C compilers have built-in support for thread-local variables. Example: https://github.com/numba/numba/blob/master/numba/_random.c#L114-L119 Regards Antoine. On Mon, 3 Jul 2017 10:07:06 +0200 Victor Stinner wrote: > I'm in favor of removing it. I know t

Re: [Python-Dev] Remove own implementation for thread-local storage

2017-07-03 Thread Victor Stinner
Sadly, we only require C99 yet :-/ Victor 2017-07-03 10:19 GMT+02:00 Antoine Pitrou : > > Also note that C11, MSVC and some Unix C compilers have built-in support > for thread-local variables. Example: > https://github.com/numba/numba/blob/master/numba/_random.c#L114-L119 > > Regards > > Antoine

[Python-Dev] Need help to review a test_nntplib enhancement:

2017-07-03 Thread Victor Stinner
Hi, Sometimes, for an unknown reason, test_nntplib fails randomly: http://bugs.python.org/issue19613 Martin Panter wrote a patch, but since I don't know how to reproduce the bug, I'm unable to test it. Moreover, I don't know nntplib nor test_nntplib, so I don't feel able to review it. Sadly,

Re: [Python-Dev] Remove own implementation for thread-local storage

2017-07-03 Thread Nick Coghlan
On 3 July 2017 at 20:02, Victor Stinner wrote: > Sadly, we only require C99 yet :-/ Handling fallbacks when shiny new features are unavailable is what autoconf is for, though :) The fact thread specific storage support made it directly into C11 makes me more confident in dropping our emulation,

Re: [Python-Dev] Remove own implementation for thread-local storage

2017-07-03 Thread Victor Stinner
>> I'd propose removing code which I think out-of-date. Already done! https://github.com/python/cpython/commit/aa0aa0492c5fffe750a26d2ab13737a1a6d7d63c (and no buildbot complained). Victor ___ Python-Dev mailing list Python-Dev@python.org https://mail.p