Re: [Python-Dev] [Python-checkins] cpython (3.4): Issue #23840: tokenize.open() now closes the temporary binary file on error to

2015-05-26 Thread Victor Stinner
2015-05-26 8:44 GMT+02:00 Serhiy Storchaka : > No, finally is not correct there. buffer shouldn't be closed if no exception > is raised. Yep. The binary file must only be closed in case of error, as written in the commit message. > And this is one of the cases in which bare 'except:' is absolutel

Re: [Python-Dev] Unable to build regex module against Python 3.5 32-bit

2015-05-26 Thread Paul Moore
On 26 May 2015 at 07:49, Paul Moore wrote: > Do you get the same failure when using distutils to build the extension? Hmm, I just checked and it seems that only Python 3.5 ships libpythonXY.a by default - 3.4 and earlier (at least on my machine) don't have it. Presumably you generated it yourself

Re: [Python-Dev] Unable to build regex module against Python 3.5 32-bit

2015-05-26 Thread Steve Dower
The builds I am responsible for include it because someone reported an issue and was persistent and helpful enough that I fixed it for them. That said, until MinGW agrees on a stable branch/version/fork, there seems to be a good chance that the shipped lib won't work for some people. If this is

Re: [Python-Dev] Unable to build regex module against Python 3.5 32-bit

2015-05-26 Thread Paul Moore
On 26 May 2015 at 13:55, Steve Dower wrote: > The builds I am responsible for include it because someone reported an issue > and was persistent and helpful enough that I fixed it for them. > > That said, until MinGW agrees on a stable branch/version/fork, there seems > to be a good chance that the

Re: [Python-Dev] [Python-checkins] cpython (3.4): Issue #23840: tokenize.open() now closes the temporary binary file on error to

2015-05-26 Thread Yury Selivanov
On 2015-05-26 3:54 AM, Victor Stinner wrote: 2015-05-26 8:44 GMT+02:00 Serhiy Storchaka : No, finally is not correct there. buffer shouldn't be closed if no exception is raised. Yep. The binary file must only be closed in case of error, as written in the commit message. Right. My bad, sor

Re: [Python-Dev] Preserving the definition order of class namespaces.

2015-05-26 Thread Jim J. Jewett
On Sun May 24 12:06:40 CEST 2015, Nick Coghlan wrote: > On 24 May 2015 at 19:44, Mark Shannon wrote: >> On 24/05/15 10:35, Nick Coghlan wrote: >>> If we leave __definition_order__ out for the time being then, for the >>> vast majority of code, the fact that the ephemeral namespace used to >>> ev

Re: [Python-Dev] Unable to build regex module against Python 3.5 32-bit

2015-05-26 Thread MRAB
On 2015-05-26 14:24, Paul Moore wrote: > On 26 May 2015 at 13:55, Steve Dower wrote: > > The builds I am responsible for include it because someone reported an issue > > and was persistent and helpful enough that I fixed it for them. > > > > That said, until MinGW agrees on a stable branch/vers

Re: [Python-Dev] Unable to build regex module against Python 3.5 32-bit

2015-05-26 Thread Paul Moore
On 26 May 2015 at 18:23, MRAB wrote: > I made libpython35.a like I did for the others and it's all working now. All > the tests pass. :-) Cool. How did you make libpython35.a? Sounds like there is some difference in the process being used for the shipped version. Paul ___

Re: [Python-Dev] [Python-checkins] cpython (3.4): Issue #23840: tokenize.open() now closes the temporary binary file on error to

2015-05-26 Thread R. David Murray
On Tue, 26 May 2015 08:20:01 +0200, Victor Stinner wrote: > What is wrong with "except:" in this specific case? Nothing is wrong with it from a technical standpoint. However, if we use 'except BaseException' that makes it clear that someone has thought about it and decided that all exceptions s

Re: [Python-Dev] Unable to build regex module against Python 3.5 32-bit

2015-05-26 Thread MRAB
On 2015-05-26 18:27, Paul Moore wrote: > On 26 May 2015 at 18:23, MRAB wrote: > > I made libpython35.a like I did for the others and it's all working now. All > > the tests pass. :-) > > Cool. How did you make libpython35.a? Sounds like there is some > difference in the process being used for t

Re: [Python-Dev] Unable to build regex module against Python 3.5 32-bit

2015-05-26 Thread Paul Moore
On 27 May 2015 at 03:02, MRAB wrote: > When I tried: > > C:\MinGW64\bin\dlltool.exe > > or: > > C:\MinGW64\x86_64-w64-mingw32\bin\dlltool.exe > > for the 32-bit builds, they wouldn't link. Was that with "-m i386"? If so, then I suspect that's the issue. Steve, did you use 64-bit mingw to