[Python-Dev] hg verify warnings

2012-08-19 Thread Stefan Krah
Hello, In a fresh clone, I'm getting a couple of warnings in `hg verify`. Perhaps someone familiar with Mercurial could take a brief look: repository uses revlog format 1 checking changesets checking manifests crosschecking files in changesets and manifests checking files warning: copy source of

Re: [Python-Dev] 3.3 str timings

2012-08-19 Thread Łukasz Langa
Wiadomość napisana przez Antoine Pitrou w dniu 18 sie 2012, o godz. 23:27: > On Sat, 18 Aug 2012 17:17:14 -0400 > Terry Reedy wrote: >> The issue came up in python-list about string operations being slower in >> 3.3. (The categorical claim is false as some things are actually >> faster.) Some

Re: [Python-Dev] Should urlencode() sort the query parameters (if they come from a dict)?

2012-08-19 Thread Stephen J. Turnbull
Antoine Pitrou writes: > That's unsubstantiated. Sure. If I had a CVE, I would have posted it. > Give an example of how sorted URLs compromise security. That's not how you think about security; the right question about sorted URLs is "how do you know that they *don't* compromise security?"

Re: [Python-Dev] Should urlencode() sort the query parameters (if they come from a dict)?

2012-08-19 Thread Stephen J. Turnbull
Joao S. O. Bueno writes: > Ageeded that "any way one thinks about it" is far too strong a claim - > but I still hold to the point. Maybe "most ways one thinks about it" > :-) . 100% agreement now. ___ Python-Dev mailing list Python-Dev@python.org h

Re: [Python-Dev] Should urlencode() sort the query parameters (if they come from a dict)?

2012-08-19 Thread Antoine Pitrou
On Sun, 19 Aug 2012 20:55:31 +0900 "Stephen J. Turnbull" wrote: > Antoine Pitrou writes: > > > That's unsubstantiated. > > Sure. If I had a CVE, I would have posted it. Ok, so you have no evidence. Regards Antoine. ___ Python-Dev mailing list Pyth

Re: [Python-Dev] hg verify warnings

2012-08-19 Thread Antoine Pitrou
On Sun, 19 Aug 2012 11:11:34 +0200 Stefan Krah wrote: > Hello, > > In a fresh clone, I'm getting a couple of warnings in `hg verify`. Perhaps > someone familiar with Mercurial could take a brief look: > > repository uses revlog format 1 > checking changesets > checking manifests > crosschecking

Re: [Python-Dev] hg verify warnings

2012-08-19 Thread Stefan Krah
Antoine Pitrou wrote: > > warning: copy source of 'Modules/_threadmodule.c' not in parents of > > 60ad83716733 > > I don't get that problem on the master server, nor on two other > machines with fresh clones and different hg versions. I suggest you > re-try cloning and, if the issue persists, re

Re: [Python-Dev] Should urlencode() sort the query parameters (if they come from a dict)?

2012-08-19 Thread Senthil Kumaran
On Sat, Aug 18, 2012 at 1:55 PM, Glenn Linderman wrote: > > On 8/18/2012 11:47 AM, MRAB wrote: > > I vote -0. The issue can also be addressed with a small and simple > helper function that wraps urlparse and compares the query parameter. Or > you cann urlencode() with `sorted(qs.items)` instead of

Re: [Python-Dev] hg verify warnings

2012-08-19 Thread Martin v. Löwis
> warning: copy source of 'Modules/_threadmodule.c' not in parents of > 60ad83716733 > warning: copy source of 'Objects/bytesobject.c' not in parents of 64bb1d258322 > warning: copy source of 'Objects/stringobject.c' not in parents of > 357e268e7c5f These revisions are all from Benjamin. So I co