Re: [Python-Dev] possible memory leak on windows (valgrind report)

2005-09-21 Thread Martin v. Löwis
Neal Norwitz wrote: > I wonder if using attributes for other features would gain us much. I > would really like to be able to use attributes for > PyArgs_ParseTuple(), but I don't think gcc can use user defined > formats. It's only printf AFAIR. Does anyone know if this isn't true > and we can d

Re: [Python-Dev] possible memory leak on windows (valgrind report)

2005-09-21 Thread Neal Norwitz
On 9/21/05, "Martin v. Löwis" <[EMAIL PROTECTED]> wrote: > Neal Norwitz wrote: > > (I need to write a lot more suppression rules for gentoo.) > > This could be due to your using GCC 4. Apparently, gcc 4 > is willing to inline Py_ADDRESS_IN_RANGE even though it > appears at the end of the file, at -

Re: [Python-Dev] possible memory leak on windows (valgrind report)

2005-09-21 Thread Martin v. Löwis
Neal Norwitz wrote: > (I need to write a lot more suppression rules for gentoo.) This could be due to your using GCC 4. Apparently, gcc 4 is willing to inline Py_ADDRESS_IN_RANGE even though it appears at the end of the file, at -O3. To suppress that, you can declare the function as __attribute__

Re: [Python-Dev] possible memory leak on windows (valgrind report)

2005-09-19 Thread Reinhold Birkenfeld
Neal Norwitz wrote: > I ran 2.4.x through valgrind and found two small problems on Linux > that have been fixed. There may be some other issues which could > benefit from more eyes (small, probably one time memory leaks). The > entire run is here: > > http://python.org/valgrind-2.4.2.out > > (I

Re: [Python-Dev] possible memory leak on windows (valgrind report)

2005-09-19 Thread Guido van Rossum
So it is. I swear I saw "s"; I must've had an out of date version. The change to "et" is less than a week old, but that's no excuse. :-( It does look like the patch is correct then (but I can't build on Windows any more either). Sorry for the confusion. On 9/19/05, Neal Norwitz <[EMAIL PROTECTED]

Re: [Python-Dev] possible memory leak on windows (valgrind report)

2005-09-19 Thread Neal Norwitz
On 9/19/05, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > That patch doesn't make sense to me -- the "s" code to > PyArg_ParseTuple doesn't return newly allocated memory, it just > returns a pointer into a string object that is owned by the caller > (really by the call machinery I suppose). Comp

Re: [Python-Dev] possible memory leak on windows (valgrind report)

2005-09-19 Thread Guido van Rossum
On 9/19/05, Neal Norwitz <[EMAIL PROTECTED]> wrote: > I ran 2.4.x through valgrind and found two small problems on Linux > that have been fixed. There may be some other issues which could > benefit from more eyes (small, probably one time memory leaks). The > entire run is here: > > http://pytho