Re: [Python-Dev] patch for review: unittest ImportError handling

2010-04-14 Thread Michael Foord
On 14/04/2010 16:53, Nick Coghlan wrote: Michael Foord wrote: Changing the error message to provide more useful information, possibly including the original traceback, would certainly avoid the potential for incompatibility. I'd be interested in seeing what other folks here on python-dev thi

Re: [Python-Dev] patch for review: unittest ImportError handling

2010-04-14 Thread Nick Coghlan
Michael Foord wrote: > Changing the error message to provide more useful information, possibly > including the original traceback, would certainly avoid the potential > for incompatibility. I'd be interested in seeing what other folks here > on python-dev think. Without looking at the details, my

Re: [Python-Dev] patch for review: unittest ImportError handling

2010-04-14 Thread Chris Jerdonek
On Wed, Apr 14, 2010 at 4:12 AM, Michael Foord wrote: > On 14/04/2010 12:54, Chris Jerdonek wrote: >> >> On Wed, Apr 14, 2010 at 2:07 AM, Michael Foord >>  wrote: >> >>> >>> I'm still not convinced that this isn't a backwards incompatible change - >>> up >>> until now, however horrible it may be,

Re: [Python-Dev] patch for review: unittest ImportError handling

2010-04-14 Thread Michael Foord
On 14/04/2010 12:54, Chris Jerdonek wrote: On Wed, Apr 14, 2010 at 2:07 AM, Michael Foord wrote: I'm still not convinced that this isn't a backwards incompatible change - up until now, however horrible it may be, TestLoader.loadTestsFromName only raised an AttributeError when it failed to

Re: [Python-Dev] patch for review: unittest ImportError handling

2010-04-14 Thread Chris Jerdonek
On Wed, Apr 14, 2010 at 2:07 AM, Michael Foord wrote: > I'm still not convinced that this isn't a backwards incompatible change - up > until now, however horrible it may be, TestLoader.loadTestsFromName only > raised an AttributeError when it failed to load a test. Changing it to allow > it propag

Re: [Python-Dev] patch for review: unittest ImportError handling

2010-04-14 Thread Robert Collins
I'd really like to see a fix that works with loadTestsFromNames - generating failing tests, for instance, and the failing tests having the full import error string in them. This doesn't preclude raising ImportError from loadTestFromName, and in fact I'd encourage that as a step towards the aforemen

Re: [Python-Dev] patch for review: unittest ImportError handling

2010-04-14 Thread Michael Foord
On 14/04/2010 05:49, Chris Jerdonek wrote: Hi folks, I have a patch to the unittest module for review here: http://bugs.python.org/issue7559#msg102801 (There have already been a couple rounds of discussion on how to best fix this.) This is my first patch, so any feedback is appreciated.