On Sat, Jul 28, 2012 at 6:21 AM, Nick Coghlan wrote:
> On Sat, Jul 28, 2012 at 8:25 PM, Chris Jerdonek
> wrote:
>> Also, this response seems somewhat at odds to the response I got to a
>> patch that refactors part of regrest, fixes some bugs in it, and adds
>> its first unit tests (in particular,
On Sat, Jul 28, 2012 at 8:25 PM, Chris Jerdonek
wrote:
> Also, this response seems somewhat at odds to the response I got to a
> patch that refactors part of regrest, fixes some bugs in it, and adds
> its first unit tests (in particular, increasing code coverage):
>
> http://bugs.python.org/issue1
On Wed, Jul 25, 2012 at 4:29 PM, Benjamin Peterson wrote:
>> (2) When adding new tests (e.g. in the course of fixing a bug or
>> increasing test coverage), are we allowed to refactor other tests so
>> that supporting test code can be shared? Or should the tests be added
>> in a less DRY fashion a
Am 26.07.2012 10:24, schrieb Eli Bendersky:
>>> I have a few questions about feature freeze:
>>>
>>> (1) Is increasing test coverage acceptable during feature freeze, even
>>> if it does not involve fixing a bug?
>>>
>>> (2) When adding new tests (e.g. in the course of fixing a bug or
>>> increasin
On Thu, Jul 26, 2012 at 6:24 PM, Eli Bendersky wrote:
> You cannot skip the peer review during an RC, no matter how small!
> Even if it is a simple copy-and-paste change, everything requires peer
> review from a core developer.
The extra restrictions during RC are more about not doing things
>> I have a few questions about feature freeze:
>>
>> (1) Is increasing test coverage acceptable during feature freeze, even
>> if it does not involve fixing a bug?
>>
>> (2) When adding new tests (e.g. in the course of fixing a bug or
>> increasing test coverage), are we allowed to refactor other
2012/7/25 Chris Jerdonek :
> I have a few questions about feature freeze:
>
> (1) Is increasing test coverage acceptable during feature freeze, even
> if it does not involve fixing a bug?
>
> (2) When adding new tests (e.g. in the course of fixing a bug or
> increasing test coverage), are we allowe
