Re: [Python-Dev] cpython (3.4): handle errors without a reason attribute

2014-11-25 Thread Antoine Pitrou
On Tue, 25 Nov 2014 19:21:08 -0500 Benjamin Peterson wrote: > > > > You should be able to keep the e.reason test if you only catch SSLError. > > Unfortunately, test_robotparser seems to manage to raise a cert > validation error without a reason. Ahh... Perhaps it's urllib catching the SSLError

Re: [Python-Dev] cpython (3.4): handle errors without a reason attribute

2014-11-25 Thread Benjamin Peterson
On Tue, Nov 25, 2014, at 19:16, Antoine Pitrou wrote: > On Wed, 26 Nov 2014 00:06:06 + > benjamin.peterson wrote: > > > https://hg.python.org/cpython/rev/e635c3ba75c8 > > changeset: 93591:e635c3ba75c8 > > branch: 3.4 > > user:Benjamin Peterson > > date:Tue Nov 25 15:

Re: [Python-Dev] cpython (3.4): handle errors without a reason attribute

2014-11-25 Thread Antoine Pitrou
On Wed, 26 Nov 2014 00:06:06 + benjamin.peterson wrote: > https://hg.python.org/cpython/rev/e635c3ba75c8 > changeset: 93591:e635c3ba75c8 > branch: 3.4 > user:Benjamin Peterson > date:Tue Nov 25 15:43:58 2014 -0600 > summary: > handle errors without a reason attribute