Re: [Python-Dev] cpython: inspect: Add __slots__ to BoundArguments.

2015-05-15 Thread Yury Selivanov
There are pickle tests for all signature related classes (all protocols for BoundArguments, Signature and Parameter). This patch ensures that old pickled BoundArguments will be unpickled without a problem in 3.5. Yury On 2015-05-15 7:57 AM, Antoine Pitrou wrote: On Fri, 15 May 2015 09:28:07

Re: [Python-Dev] cpython: inspect: Add __slots__ to BoundArguments.

2015-05-15 Thread Yury Selivanov
No, it does not. I implemented __getstate__/__setstate__ specifically to maintain backwards compatibility (I also tested it). Yury On 2015-05-15 2:28 AM, Serhiy Storchaka wrote: On 14.05.15 00:38, yury.selivanov wrote: https://hg.python.org/cpython/rev/ee31277386cb changeset: 96038:ee3127

Re: [Python-Dev] cpython: inspect: Add __slots__ to BoundArguments.

2015-05-15 Thread Antoine Pitrou
On Fri, 15 May 2015 09:28:07 +0300 Serhiy Storchaka wrote: > On 14.05.15 00:38, yury.selivanov wrote: > > https://hg.python.org/cpython/rev/ee31277386cb > > changeset: 96038:ee31277386cb > > user:Yury Selivanov > > date:Wed May 13 17:18:41 2015 -0400 > > summary: > >inspect:

Re: [Python-Dev] cpython: inspect: Add __slots__ to BoundArguments.

2015-05-14 Thread Serhiy Storchaka
On 14.05.15 00:38, yury.selivanov wrote: https://hg.python.org/cpython/rev/ee31277386cb changeset: 96038:ee31277386cb user:Yury Selivanov date:Wed May 13 17:18:41 2015 -0400 summary: inspect: Add __slots__ to BoundArguments. Note that adding __slots__ breaks pickleability.