Re: [Python-Dev] Rietveld integration into Roundup

Le jeudi 07 octobre 2010 à 23:17 +0200, "Martin v. Löwis" a écrit : > > As I said, most patches are supposed to be produced against py3k HEAD, > > so you could try just that as the primary heuristic. > > I think this is impractical. There are tons of patches (the majority) > which are in the track

Re: [Python-Dev] Rietveld integration into Roundup

> As I said, most patches are supposed to be produced against py3k HEAD, > so you could try just that as the primary heuristic. I think this is impractical. There are tons of patches (the majority) which are in the tracker and *not* against py3k head. So this heuristics will only cover a small min

Re: [Python-Dev] Rietveld integration into Roundup

On Thu, 07 Oct 2010 23:04:54 +0200 "Martin v. Löwis" wrote: > > However, if I get something like > > diff -r e981b6cc56b0 Include/longintrepr.h > --- a/Include/longintrepr.h Thu Oct 07 03:12:19 2010 +0200 > +++ b/Include/longintrepr.h Thu Oct 07 13:53:41 2010 +0200 > > I have no clue where

Re: [Python-Dev] Rietveld integration into Roundup

Am 04.10.2010 03:56, schrieb Daniel Stutzbach: > On Sat, Oct 2, 2010 at 3:55 PM, "Martin v. Löwis" > wrote: > > I'll have to come up with a better way to determine the branch > which a patch was created on. > > > That would also be helpful for those of us usin

Re: [Python-Dev] Rietveld integration into Roundup

I attempted to fix the branch at http://bugs.python.org/file18220 , but it did not trigger rietveld update. I assume you made "Tracker Branch" editable on purpose, but there should be a way rietveld side to know when this field is changed I think. Please start submitting issues with the Rietv

Re: [Python-Dev] Rietveld integration into Roundup

On Tue, Oct 5, 2010 at 3:25 PM, "Martin v. Löwis" wrote: .. >> >> Error fetching None/Modules/arraymodule.c?rev=83179: InvalidURLError: >> Protocol '%s' is not supported. > > That currently happens for a lot of patches. It can't figure out what > the base branch is, and goes to the Rietveld Issue

Re: [Python-Dev] Rietveld integration into Roundup

Am 05.10.10 20:15, schrieb Alexander Belopolsky: I followed the review link from issue5109 to arrive at http://bugs.python.org/review/5109/patch/179/325 . On the review page I clicked on Modules/arraymodule.c> View for side-by-side diff and got Error fetching None/Modules/arraymodule.c?rev=831

Re: [Python-Dev] Rietveld integration into Roundup

I followed the review link from issue5109 to arrive at http://bugs.python.org/review/5109/patch/179/325 . On the review page I clicked on Modules/arraymodule.c > View for side-by-side diff and got Error fetching None/Modules/arraymodule.c?rev=83179: InvalidURLError: Protocol '%s' is not supported

Re: [Python-Dev] Rietveld integration into Roundup

I feel that, only if a roundup issue has patch, the corresponding rietveld issue be created, it is more helpful there and avoids needless duplication. I have changed that now. Regards, Martin ___ Python-Dev mailing list Python-Dev@python.org http:/

Re: [Python-Dev] Rietveld integration into Roundup

Thanks Martin, this is really good. On Sun, Oct 3, 2010 at 1:33 AM, "Martin v. Löwis" wrote: >  Patches are skipped if: >  * they have been added to Rietveld already >  * they have no clear base version (i.e. they don't originate >    from svn diff) >  * they belong to no or a closed issue >  * t

Re: [Python-Dev] Rietveld integration into Roundup

On Sat, Oct 2, 2010 at 3:55 PM, "Martin v. Löwis" wrote: > I'll have to come up with a better way to determine the branch > which a patch was created on. > That would also be helpful for those of us using DVCS software to talk to the svn server. :-) -- Daniel Stutzbach, Ph.D. President, Stutzba

Re: [Python-Dev] Rietveld integration into Roundup

> 1) who is the notification e-mail sent to when a review is published? I haven't figured that out yet. I'm not even sure whether email gets sent at all. I'll look into this a week from now, unless someone resolves that earlier. But... > I > just tried on one of my patches and the e-mail came wit

Re: [Python-Dev] Rietveld integration into Roundup

Le samedi 02 octobre 2010 à 22:55 +0200, "Martin v. Löwis" a écrit : > > > 2) if I look at http://bugs.python.org/issue9962, only the second patch > > of all three has been enabled for review. Yet they were all created > > through "svn diff" against a recent py3k checkout. > > They had both the s

Re: [Python-Dev] Rietveld integration into Roundup

Hello, On Sat, 02 Oct 2010 22:03:57 +0200 "Martin v. Löwis" wrote: > Following up to the recent thread, I have now integrated Rietveld > into Roundup. This is a rough draft still, and highly experimental. > Please try it out, but expect that it may be necessary to discard > all data (including c

Re: [Python-Dev] Rietveld integration into Roundup

Thanks for this. It looks very nice. 2010/10/2 "Martin v. Löwis" : > Following up to the recent thread, I have now integrated Rietveld > into Roundup. This is a rough draft still, and highly experimental. > Please try it out, but expect that it may be necessary to discard > all data (including co