Re: [Python-Dev] Request for review: binary op dispatch rules for subclasses

2018-09-17 Thread Guido van Rossum
FWIW I wrote up what I recall about the issue and kicked it to the next BDFL: https://bugs.python.org/issue30140#msg325553 On Fri, Sep 14, 2018 at 6:42 PM Stephan Hoyer wrote: > Over a year ago, I made a pull request ( > https://github.com/python/cpython/pull/1325) to fix a long-standing issue >

Re: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Gregory P. Smith
> As I mentioned earlier I'd like to get patch 1446489 (support for > zip64 extensions in the zipfile module) in python 2.5. The patch > should be perfectly safe, it comes with unittests and a documentation > update. I'm also using this version of zipfile in (closed-source) > projects to ha

Re: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Ronald Oussoren
On 13-jun-2006, at 15:08, Aahz wrote: On Tue, Jun 13, 2006, Ronald Oussoren wrote: There are two backward incompatbile changes, both minor. First of all ZipInfo will lose the file_offset attribute because calculating it when opening a zipfile is very expensive (it basically requires a full sc

Re: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Aahz
On Tue, Jun 13, 2006, Ronald Oussoren wrote: > > There are two backward incompatbile changes, both minor. First of all > ZipInfo will lose the file_offset attribute because calculating it > when opening a zipfile is very expensive (it basically requires a > full scan of the zipfile). This sh

Re: [Python-Dev] Request for review

2006-04-13 Thread Nick Coghlan
Tim Peters wrote: > [Georg Brandl] >> Hm. This broke a few doctests. I can fix them, but I wonder if >> doctest should accept a bare exception name if the exception >> is defined in the current module. > > No. > >> Or should it ignore the module name altogether? > > No. doctest strives to be ma

Re: [Python-Dev] Request for review

2006-04-12 Thread Tim Peters
[Georg Brandl] > Hm. This broke a few doctests. I can fix them, but I wonder if > doctest should accept a bare exception name if the exception > is defined in the current module. No. > Or should it ignore the module name altogether? No. doctest strives to be magic-free WYSIWYG. If someone _int

Re: [Python-Dev] Request for review

2006-04-12 Thread Georg Brandl
Georg Brandl wrote: > Seo Sanghyeon wrote: >> Can someone have a look at #860326? I got bitten by it today, and I can >> see no reason not to apply suggested patch. > > I've reviewed it and checked it in. Hm. This broke a few doctests. I can fix them, but I wonder if doctest should accept a bare

Re: [Python-Dev] Request for review

2006-04-12 Thread Georg Brandl
Seo Sanghyeon wrote: > Can someone have a look at #860326? I got bitten by it today, and I can > see no reason not to apply suggested patch. I've reviewed it and checked it in. Cheers, Georg ___ Python-Dev mailing list Python-Dev@python.org http://mail