Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-31 Thread Gregory Szorc
On 5/20/2019 4:09 AM, Victor Stinner wrote: > Hi Gregory, > > IMHO your remarks are not directly related to the PEP 587 and can be > addressed in parallel. > >> It sounds like PyOxidizer and Hermetic Python are on the same page and >> we're working towards a more official solution. But I want to

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-20 Thread Victor Stinner
Hi Gregory, IMHO your remarks are not directly related to the PEP 587 and can be addressed in parallel. > It sounds like PyOxidizer and Hermetic Python are on the same page and > we're working towards a more official solution. But I want to make sure > by explicitly stating what PyOxidizer is doi

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-19 Thread Gregory Szorc
On 5/16/2019 10:25 AM, Victor Stinner wrote: > Le jeu. 16 mai 2019 à 16:10, Thomas Wouters a écrit : >>> Would you be ok with a "PyConfig_Init(PyConfig *config);" function >>> which would initialize all fields to theire default values? Maybe >>> PyConfig_INIT should be renamed to PyConfig_STATIC_I

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-16 Thread Victor Stinner
Le jeu. 16 mai 2019 à 16:10, Thomas Wouters a écrit : >> Would you be ok with a "PyConfig_Init(PyConfig *config);" function >> which would initialize all fields to theire default values? Maybe >> PyConfig_INIT should be renamed to PyConfig_STATIC_INIT. >> >> You can find a similar API for pthread

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-16 Thread Steve Dower
On 16May2019 0710, Thomas Wouters wrote: A couple of things are documented as performing pre-initialisation (PyConfig_SetBytesString, PyConfig_SetBytesArgv). I understand why, but I feel like that might be confusing and error-prone. Would it not be better to have them fail if pre-initialisation

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-16 Thread Steve Dower
On 15May2019 1610, Victor Stinner wrote: Thanks to the constructive discussions, I enhanced my PEP 587. I don't plan any further change, the PEP is now ready to review (and maybe even for pronouncement, hi Thomas! :-)). My view is that while this is a fantastic PEP and the groundwork that alre

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-16 Thread Steve Dower
Thanks for adding your input, Gregory! It's much appreciated. I'll shuffle your comments around a bit, as I'd rather address the themes than each individual point. On 15May2019 2134, Gregory Szorc wrote: PyPreConfig_INIT and PyConfig_INIT as macros that return a struct feel weird to me. Speci

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-16 Thread Thomas Wouters
On Thu, May 16, 2019 at 2:03 PM Victor Stinner wrote: > (Le jeu. 16 mai 2019 à 06:34, Gregory Szorc a > écrit : > > > I know that the PEP is long, but well, it's a complex topic, and I > > > chose to add many examples to make the API easier to understand. > > > > I saw your request for feedback

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-16 Thread Paul Moore
On Thu, 16 May 2019 at 13:05, Victor Stinner wrote: > > PyPreConfig_INIT and PyConfig_INIT as macros that return a struct feel > > weird to me. Specifically, the `PyPreConfig preconfig = > > PyPreConfig_INIT;` pattern doesn't feel right. I'm sort of OK with these > > being implemented as macros. B

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-16 Thread Victor Stinner
(Le jeu. 16 mai 2019 à 06:34, Gregory Szorc a écrit : > > I know that the PEP is long, but well, it's a complex topic, and I > > chose to add many examples to make the API easier to understand. > > I saw your request for feedback on Twitter a few days back and found > this thread. > > This PEP is

Re: [Python-Dev] RFC: PEP 587 "Python Initialization Configuration": 3rd version

2019-05-15 Thread Gregory Szorc
On 5/15/2019 4:10 PM, Victor Stinner wrote: > Hi, > > Thanks to the constructive discussions, I enhanced my PEP 587. I don't > plan any further change, the PEP is now ready to review (and maybe > even for pronouncement, hi Thomas! :-)). > > The Rationale now better explains all challenges and the