Re: [Python-Dev] Py_END_ALLOW_THREADS and GetLastError()

2009-01-10 Thread Ulrich Eckhardt
On Saturday 10 January 2009 15:11:16 Martin v. Löwis wrote: > > Well, that's what you get for using globals > > Please do take a look at the issue at hand before pointing fingers. I'm really sorry if this sounded like I was accusing someone, that was not my intention. Uli

Re: [Python-Dev] Py_END_ALLOW_THREADS and GetLastError()

2009-01-10 Thread Martin v. Löwis
> Well, that's what you get for using globals Please do take a look at the issue at hand before pointing fingers. First, GetLastError() isn't a really a global (and neither is errno); they are both thread-local. Next, there is really no choice to use or not use errno - if you want to find out what

Re: [Python-Dev] Py_END_ALLOW_THREADS and GetLastError()

2009-01-10 Thread Ulrich Eckhardt
On Saturday 10 January 2009 12:29:47 Kristján Valur Jónsson wrote: > Currently on Windows, Py_END_ALLOW_THREADS can have the side effect of > resetting the windows error code returned by GetLastError(). There is a > number of cases, particularly in posixmodule, with a pattern like: > Py_BEGIN_ALLOW

Re: [Python-Dev] Py_END_ALLOW_THREADS and GetLastError()

2009-01-10 Thread Hirokazu Yamamoto
Kristján Valur Jónsson wrote: > Currently on Windows, Py_END_ALLOW_THREADS can have the side effect of > resetting the windows error code returned by GetLastError(). > > There is a number of cases, particularly in posixmodule, with a pattern > like: > > Py_BEGIN_ALLOW_THREADS > > resul