Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-06 Thread Brett Cannon
On Mon, Jan 6, 2014 at 3:40 PM, Skip Montanaro wrote: > On Mon, Jan 6, 2014 at 2:17 PM, Antoine Pitrou > wrote: > >> I agree with Serhiy, but that is probably known at this point. :) > > > > I agree with Serhiy and you too. Clinic's current output makes C files > > more tedious to read, and I'm

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-06 Thread Serhiy Storchaka
06.01.14 22:53, Erik Bray написав(ла): I ask because some built-in functions are used internally by other built-in functions. I don't know how common this is but, for example, fileio_read calls fileio_readall. So if fileio_readall is renamed to io_FileIO_readall_impl or whatever we need to also

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-06 Thread Guido van Rossum
On Mon, Jan 6, 2014 at 10:17 AM, Antoine Pitrou wrote: > On Mon, 6 Jan 2014 00:25:53 +0100 > Stefan Krah wrote: >> Nick Coghlan wrote: >> > > I had that working at one point. Guido said no, keep it all in one file. >> > > I'm flexible but first you'd have to convince him. >> > >> > It's also no

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-06 Thread Erik Bray
On Sun, Jan 5, 2014 at 11:21 AM, Larry Hastings wrote: > Now, properly converting a function to work with Argument Clinic does not > change its behavior. Internally, the code performing argument parsing > should be nigh-identical; it should call the same PyArg_Parse function, with > the same argu

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-06 Thread Skip Montanaro
On Mon, Jan 6, 2014 at 2:17 PM, Antoine Pitrou wrote: >> I agree with Serhiy, but that is probably known at this point. :) > > I agree with Serhiy and you too. Clinic's current output makes C files > more tedious to read, and I'm not really willing to participate in the > "conversion derby" becaus

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-06 Thread Antoine Pitrou
On Mon, 6 Jan 2014 00:25:53 +0100 Stefan Krah wrote: > Nick Coghlan wrote: > > > I had that working at one point. Guido said no, keep it all in one file. > > > I'm flexible but first you'd have to convince him. > > > > It's also not something we're stuck with forever - we can start with it >

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-05 Thread Stefan Krah
Nick Coghlan wrote: > > I had that working at one point. Guido said no, keep it all in one file. > > I'm flexible but first you'd have to convince him. > > It's also not something we're stuck with forever - we can start with it inline > (which has the advantage of keeping all the code in the sa

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-05 Thread Nick Coghlan
On 6 Jan 2014 05:54, "Larry Hastings" wrote: > > On 01/05/2014 01:49 PM, Serhiy Storchaka wrote: >> >> But I very much upset by the fact that the generated code is written mixed with written manually. It is difficult to navigate (list of symbols now contains three times more names), makes it diffi

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-05 Thread Larry Hastings
On 01/05/2014 01:49 PM, Serhiy Storchaka wrote: But I very much upset by the fact that the generated code is written mixed with written manually. It is difficult to navigate (list of symbols now contains three times more names), makes it difficult to read and provokes error (editing the generat

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-05 Thread Serhiy Storchaka
It looks interesting enough. I volunteer to convert at least the audioop, grp, operator, pwd, spw, sre, struct, tkinter modules (audioop already converted, tkinter in progress). If no one will get them, I perhaps will convert the builtins, sys, itertools, functools modules and str, bytes, byte

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-05 Thread Larry Hastings
On 01/05/2014 11:49 AM, Terry Reedy wrote: On 1/5/2014 11:21 AM, Larry Hastings wrote: By my estimate, there are about six hundred places that could be converted to work with Argument Clinic in CPython; as of this writing only a dozen or two have actually been converted. Do you remember which?

Re: [Python-Dev] Proposed: The Great Argument Clinic Conversion Derby

2014-01-05 Thread Terry Reedy
On 1/5/2014 11:21 AM, Larry Hastings wrote: Let me start with a summary of the current status of Argument Clinic. It's checked in, it seems to be working fine. As of Friday I've checked in some reasonably complete documentation as a howto: http://docs.python.org/3.4/howto/clinic.html At