Re: [Python-Dev] Please merge : bpo-34848

2019-05-09 Thread Victor Stinner
Le ven. 3 mai 2019 à 17:47, Jeroen Demeyer a écrit : > > On 2019-05-03 14:24, Victor Stinner wrote: > > Hi Srinivas, > > > > I merged your obvious doc fix, thanks. > > Can you please do the same for > https://github.com/python/cpython/pull/12784 This PR is modying critical code (signal). I don't

Re: [Python-Dev] Please merge : bpo-34848

2019-05-09 Thread Victor Stinner
Le ven. 3 mai 2019 à 17:47, Jeroen Demeyer a écrit : > On 2019-05-03 14:24, Victor Stinner wrote: > > Hi Srinivas, > > > > I merged your obvious doc fix, thanks. > > Can you please do the same for > > https://github.com/python/cpython/pull/12784 This PR is modying critical change. I don't have th

Re: [Python-Dev] Please merge : bpo-34848

2019-05-03 Thread Jeroen Demeyer
On 2019-05-03 14:24, Victor Stinner wrote: Hi Srinivas, I merged your obvious doc fix, thanks. Can you please do the same for https://github.com/python/cpython/pull/12784 ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mail

Re: [Python-Dev] Please merge : bpo-34848

2019-05-03 Thread Brett Cannon
The "awaiting merge" was originally created to help with this. On Fri., May 3, 2019, 08:51 Miro Hrončok, wrote: > On 03. 05. 19 14:24, Victor Stinner wrote: > > Does someone know how I can list pull requests which has been approved > but not > > merged yet? > > Add review:approved to the search

Re: [Python-Dev] Please merge : bpo-34848

2019-05-03 Thread Miro Hrončok
On 03. 05. 19 14:24, Victor Stinner wrote: Does someone know how I can list pull requests which has been approved but not merged yet? Add review:approved to the search filed. https://github.com/python/cpython/pulls?q=is%3Apr+is%3Aopen+review%3Aapproved Or click on **Reviews** in the top bar a

Re: [Python-Dev] Please merge : bpo-34848

2019-05-03 Thread Victor Stinner
Hi Srinivas, I merged your obvious doc fix, thanks. Does someone know how I can list pull requests which has been approved but not merged yet? Victor Le vendredi 3 mai 2019, Srinivas Reddy Thatiparthy < thatiparthysreeni...@gmail.com> a écrit : > Hi, >The PR - https://github.com/python/cpyt

Re: [Python-Dev] Please merge : bpo-34848

2019-05-03 Thread Srinivas Reddy Thatiparthy
Yes, I agree. Please do as I do not have permission. Best Regards, Srinivas Reddy Thatipathy On Fri, 3 May 2019 at 16:52, Steve Holden wrote: > Looks like the failure is due to absence of a News entry. Maybe add a > "skip news" label if this doesn't need to be documented? > > Kind regards.

Re: [Python-Dev] Please merge : bpo-34848

2019-05-03 Thread Steve Holden
Looks like the failure is due to absence of a News entry. Maybe add a "skip news" label if this doesn't need to be documented? Kind regards. Steve Holden On Fri, May 3, 2019 at 9:48 AM Srinivas Reddy Thatiparthy < thatiparthysreeni...@gmail.com> wrote: > Hi, >The PR - https://github.com/pyt