Re: [Python-Dev] PEP 448 review

2015-04-07 Thread Nick Coghlan
On 7 Apr 2015 03:43, "Neil Girdhar" wrote: > > Hello, > > Following up with PEP 448, I've gone over the entire code review except a few points as mentioned at the issue: http://bugs.python.org/review/2292/. I'm hoping that this will get done at the PyCon sprints. Is there any way I can help? > >

Re: [Python-Dev] PEP 448 review

2015-04-07 Thread Neil Girdhar
Hello, Following up with PEP 448, I've gone over the entire code review except a few points as mentioned at the issue: http://bugs.python.org/review/2292/. I'm hoping that this will get done at the PyCon sprints. Is there any way I can help? I couldn't make it to PyCon, but I do live in Montrea

Re: [Python-Dev] PEP 448 review

2015-03-18 Thread Nick Coghlan
On 17 March 2015 at 23:49, Brett Cannon wrote: > > > On Mon, Mar 16, 2015 at 7:11 PM Neil Girdhar wrote: >> >> Hi everyone, >> >> I was wondering what is left with the PEP 448 >> (http://bugs.python.org/issue2292) code review? Big thanks to Benjamin, >> Ethan, and Serhiy for reviewing some (all?

Re: [Python-Dev] PEP 448 review

2015-03-17 Thread Brett Cannon
On Mon, Mar 16, 2015 at 7:11 PM Neil Girdhar wrote: > Hi everyone, > > I was wondering what is left with the PEP 448 ( > http://bugs.python.org/issue2292) code review? Big thanks to Benjamin, > Ethan, and Serhiy for reviewing some (all?) of the code. What is the next > step of this process? >

Re: [Python-Dev] PEP 448 review

2015-03-16 Thread Neil Girdhar
Hi everyone, I was wondering what is left with the PEP 448 ( http://bugs.python.org/issue2292) code review? Big thanks to Benjamin, Ethan, and Serhiy for reviewing some (all?) of the code. What is the next step of this process? Thanks, Neil On Sun, Mar 8, 2015 at 4:38 PM, Neil Girdhar wrote

Re: [Python-Dev] PEP 448 review

2015-03-08 Thread Neil Girdhar
Anyone have time to do a code review? http://bugs.python.org/issue2292 On Mon, Mar 2, 2015 at 4:54 PM, Neil Girdhar wrote: > It's from five days ago. I asked Joshua to take a look at something, but > I guess he is busy. > > Best, > > Neil > > — > > The latest file there is from Feb 26, while y

Re: [Python-Dev] PEP 448 review

2015-03-02 Thread Neil Girdhar
It's from five days ago. I asked Joshua to take a look at something, but I guess he is busy. Best, Neil — The latest file there is from Feb 26, while your message that the patch was ready for review is from today -- so is the patch from five days ago the most recent? -- ~Ethan~ On Mon, Mar

Re: [Python-Dev] PEP 448 review

2015-03-02 Thread Ethan Furman
On 03/02/2015 12:18 PM, Neil Girdhar wrote: > On Mon, Mar 2, 2015 at 3:17 PM, Victor Stinner wrote: >> Le lundi 2 mars 2015, Neil Girdhar a écrit : >>> >>> The patch is ready for review now, and I should have time this week to >>> make changes and respond to comments. >> >> Where is the patch? >

Re: [Python-Dev] PEP 448 review

2015-03-02 Thread Neil Girdhar
http://bugs.python.org/issue2292 On Mon, Mar 2, 2015 at 3:17 PM, Victor Stinner wrote: > Where is the patch? > > Victor > > Le lundi 2 mars 2015, Neil Girdhar a écrit : > > Hi everyone, >> >> The patch is ready for review now, and I should have time this week to >> make changes and respond to c

Re: [Python-Dev] PEP 448 review

2015-03-02 Thread Victor Stinner
Where is the patch? Victor Le lundi 2 mars 2015, Neil Girdhar a écrit : > Hi everyone, > > The patch is ready for review now, and I should have time this week to > make changes and respond to comments. > > Best, > > Neil > > On Wed, Feb 25, 2015 at 2:42 PM, Guido van Rossum > wrote: > >> I'm b

Re: [Python-Dev] PEP 448 review

2015-03-02 Thread Neil Girdhar
Hi everyone, The patch is ready for review now, and I should have time this week to make changes and respond to comments. Best, Neil On Wed, Feb 25, 2015 at 2:42 PM, Guido van Rossum wrote: > I'm back, I've re-read the PEP, and I've re-read the long thread with "(no > subject)". > > I think G

Re: [Python-Dev] PEP 448 review

2015-02-27 Thread Thomas Wouters
On Thu, Feb 26, 2015 at 12:37 PM, Ethan Furman wrote: > On 02/26/2015 12:19 PM, Guido van Rossum wrote: > > > As a follow-up, Joshua updated the PEP to remove *comprehensions, and it > is now accepted. > > Congratulations Thomas, Joshua, and Neil!! > Wot, me? No, no, all credit goes to Joshua an

Re: [Python-Dev] PEP 448 review

2015-02-27 Thread Nick Coghlan
On 27 Feb 2015 07:12, "Brett Cannon" wrote: > > > > On Thu, Feb 26, 2015 at 3:38 PM Ethan Furman wrote: >> >> On 02/26/2015 12:19 PM, Guido van Rossum wrote: >> >> > As a follow-up, Joshua updated the PEP to remove *comprehensions, and it is now accepted. >> >> Congratulations Thomas, Joshua, and

Re: [Python-Dev] PEP 448 review

2015-02-26 Thread Brett Cannon
On Thu, Feb 26, 2015 at 3:38 PM Ethan Furman wrote: > On 02/26/2015 12:19 PM, Guido van Rossum wrote: > > > As a follow-up, Joshua updated the PEP to remove *comprehensions, and it > is now accepted. > > Congratulations Thomas, Joshua, and Neil!! > I'll add a "thanks" to everyone involved with t

Re: [Python-Dev] PEP 448 review

2015-02-26 Thread Ethan Furman
On 02/26/2015 12:19 PM, Guido van Rossum wrote: > As a follow-up, Joshua updated the PEP to remove *comprehensions, and it is > now accepted. Congratulations Thomas, Joshua, and Neil!! -- ~Ethan~ signature.asc Description: OpenPGP digital signature ___

Re: [Python-Dev] PEP 448 review

2015-02-26 Thread Guido van Rossum
One more thing. This PEP would never have been accepted without a working implementation. Thanks Neil and Joshua for that! (And for being flexible.) On Thu, Feb 26, 2015 at 12:19 PM, Guido van Rossum wrote: > As a follow-up, Joshua updated the PEP to remove *comprehensions, and it > is now accep

Re: [Python-Dev] PEP 448 review

2015-02-26 Thread Guido van Rossum
As a follow-up, Joshua updated the PEP to remove *comprehensions, and it is now accepted. On Wed, Feb 25, 2015 at 11:42 AM, Guido van Rossum wrote: > I'm back, I've re-read the PEP, and I've re-read the long thread with "(no > subject)". > > I think Georg Brandl nailed it: > > """ > > > > > > >