Re: [Python-Dev] PATCH: Fast globals/builtins lookups for 2.6

2007-12-27 Thread Daniel Stutzbach
On Dec 27, 2007 4:22 AM, Armin Rigo <[EMAIL PROTECTED]> wrote: > How much time does it take if the loop is in a C extension module, e.g. > like the following? > > while (1) { PyDict_SetItem(d, k, v); PyDict_DelItem(d, k); } > > How much time would it take the same loop to overflow even the 64-b

Re: [Python-Dev] PATCH: Fast globals/builtins lookups for 2.6

2007-12-27 Thread Armin Rigo
Hi Neil, On Fri, Nov 30, 2007 at 09:14:04AM -0700, Neil Toronto wrote: > >> whether 64 bits is necessary. It takes an hour of concerted effort - > >> nothing but "module.d = 1; del module.d" for an hour straight - to > >> overflow a 32-bit version number. Is anybody going to actually get close

Re: [Python-Dev] PATCH: Fast globals/builtins lookups for 2.6

2007-11-30 Thread Neil Toronto
Steve Holden wrote: > Neil Toronto wrote: >> Speaking of which, here's a question for everybody. I was wondering >> whether 64 bits is necessary. It takes an hour of concerted effort - >> nothing but "module.d = 1; del module.d" for an hour straight - to >> overflow a 32-bit version number. Is a

Re: [Python-Dev] PATCH: Fast globals/builtins lookups for 2.6

2007-11-30 Thread Steve Holden
Neil Toronto wrote: > Guido van Rossum wrote: >> Hm. >> >> On my Linux box, in the trunk: >> >> Before the patch: >> Pystone(1.1) time for 5 passes = 1.16 >> This machine benchmarks at 43103.4 pystones/second >> >> After the patch: >> Pystone(1.1) time for 5 passes = 1.14 >> This machine be

Re: [Python-Dev] PATCH: Fast globals/builtins lookups for 2.6

2007-11-29 Thread Neil Toronto
Guido van Rossum wrote: > Hm. > > On my Linux box, in the trunk: > > Before the patch: > Pystone(1.1) time for 5 passes = 1.16 > This machine benchmarks at 43103.4 pystones/second > > After the patch: > Pystone(1.1) time for 5 passes = 1.14 > This machine benchmarks at 43859.6 pystones/s

Re: [Python-Dev] PATCH: Fast globals/builtins lookups for 2.6

2007-11-29 Thread Guido van Rossum
On Nov 29, 2007 1:07 PM, Neil Toronto <[EMAIL PROTECTED]> wrote: > Guido van Rossum wrote: > > Cool! Can't wait to get my hands on it. How does it affect pystone? > > Pystone likes it, according to my tests and Chris's. On his machine, if > I'm reading these stones right, it takes about 7% off the

Re: [Python-Dev] PATCH: Fast globals/builtins lookups for 2.6

2007-11-29 Thread Neil Toronto
Guido van Rossum wrote: > Cool! Can't wait to get my hands on it. How does it affect pystone? Pystone likes it, according to my tests and Chris's. On his machine, if I'm reading these stones right, it takes about 7% off the run time on average. On mine it takes off 4%. > What happens if the glo

Re: [Python-Dev] PATCH: Fast globals/builtins lookups for 2.6

2007-11-29 Thread Guido van Rossum
Cool! Can't wait to get my hands on it. How does it affect pystone? What happens if the globals are not a real dict but an instance of another collections.MutableMapping (virtual or real) subclass? We've worked hard (well, some folks have) to enable this. It would be a show-stopper if this broke