Re: [Python-Dev] NeedsReview keyword

2008-04-15 Thread Martin v. Löwis
> > the flush fails but the programs fails to recognize it? i.e. the > program > > assumes the data is written to disk but it isn't? > > Why would the program fail to recognize it? It should just look at the > result being returned. > > > sorry no. Sorry no what? Regards, M

Re: [Python-Dev] NeedsReview keyword

2008-04-15 Thread Ralf Schmitt
> > > > the flush fails but the programs fails to recognize it? i.e. the program > > assumes the data is written to disk but it isn't? > > Why would the program fail to recognize it? It should just look at the > result being returned. > sorry no. everything else raises an error. this is not docume

Re: [Python-Dev] NeedsReview keyword

2008-04-15 Thread Martin v. Löwis
> Just name your patch files .patch or .diff the next time, not .txt, and > the keyword will get automatically set. > > > fine. I used .txt cause I wanted to view it in my browser (without the > browser asking me for an application) .diff would have done the same thing. > as it only

Re: [Python-Dev] NeedsReview keyword

2008-04-14 Thread Ralf Schmitt
On Tue, Apr 15, 2008 at 7:54 AM, "Martin v. Löwis" <[EMAIL PROTECTED]> wrote: > > Just name your patch files .patch or .diff the next time, not .txt, and > the keyword will get automatically set. > fine. I used .txt cause I wanted to view it in my browser (without the browser asking me for an app

Re: [Python-Dev] NeedsReview keyword

2008-04-14 Thread Martin v. Löwis
> I think it would be nice if that patch keyword could be set by non-admins. > This would mean I didn't have to write to the mailing list asking for > people to look at > some specific bug. Like "did someone look at > http://bugs.python.org/issue2122. Just name your patch files .patch or .diff the

Re: [Python-Dev] NeedsReview keyword

2008-04-14 Thread Ralf Schmitt
On Tue, Apr 15, 2008 at 7:21 AM, "Martin v. Löwis" <[EMAIL PROTECTED]> wrote: > > I think it would be useful for the tracker to grow a "NeedsReview" > > keyword. I realize the "patch" keyword does some of this, but it may > > just represent some initial or trivial work. "NeedsReview" should > > re

Re: [Python-Dev] NeedsReview keyword

2008-04-14 Thread Martin v. Löwis
> I think it would be useful for the tracker to grow a "NeedsReview" > keyword. I realize the "patch" keyword does some of this, but it may > just represent some initial or trivial work. "NeedsReview" should > represent a mature patch that some senior dev needs to look hard at > and make the choice