Re: [Python-Dev] NOARGS_NULL

2007-03-02 Thread K D
Martin v. Löwis wrote: > The style-guide in C is that macro names are spelled in all-caps, so > if you see an all-caps identifier, you expect it to be a macro name. Hi Martin. OK, so somewhere we have: /* NOARGS_NULL: A parameter declared in this way is present only because * the function is r

Re: [Python-Dev] NOARGS_NULL

2007-02-25 Thread Martin v. Löwis
K D schrieb: > I thought it would be nice to have the code marked somehow so that it > was obvious what the additional (and obviously unused) parameter was. > The two references (NULL and METH_NOARGS) are both in upper-case and as > C is a case-sensitive language I think it's probably usual to do >

Re: [Python-Dev] NOARGS_NULL

2007-02-23 Thread Martin v. Löwis
Thomas Wouters schrieb: > My only objection (which is a minor one) is with the 'NOARGS_NULL' name. > Caps don't fit the normal style rules, and 'noargs_null' doesn't make > much sense to me. 'unused' strikes me as a clearer name (or > 'noargs_unused' or 'args_unused' or such.) The point clearly i

Re: [Python-Dev] NOARGS_NULL

2007-02-23 Thread Thomas Wouters
My only objection (which is a minor one) is with the 'NOARGS_NULL' name. Caps don't fit the normal style rules, and 'noargs_null' doesn't make much sense to me. 'unused' strikes me as a clearer name (or 'noargs_unused' or 'args_unused' or such.) It should be fine to fix this in 2.5 as well (as lon