Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-11 Thread Guido van Rossum
On Wed, May 11, 2011 at 9:39 AM, Éric Araujo wrote: > Funny, I always use the present tense, to convey what the code does now. Yeah, and that's exactly what I am objecting to. Please describe what changed how, since that is the focus of the patch. -- --Guido van Rossum (python.org/~guido) _

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-11 Thread Terry Reedy
On 5/11/2011 12:39 PM, Éric Araujo wrote: Funny, I always use the present tense, to convey what the code does now. Which code ;-). At the moment you write a push message, your private clone does something different from the public repository (and other private clones). At the moment people

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-11 Thread Éric Araujo
Le 10/05/2011 16:46, R. David Murray a écrit : On Tue, 10 May 2011 17:45:44 +0400, Oleg Broytman wrote: Why "fixed" is in the past tense, but "improve", and "change" are in present tense? I use past tense to describe what I did on the code, and present simple to describe what the new cod

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-10 Thread R. David Murray
On Tue, 10 May 2011 17:45:44 +0400, Oleg Broytman wrote: > On Tue, May 10, 2011 at 09:33:13AM -0400, R. David Murray wrote: > > commit: > > 11999: sync based on comparing mtimes, not mtime to system clock > > NEWS: > > Issue 11999: fixed sporadic sync failure mailbox.Maildir due to its > >

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-10 Thread Oleg Broytman
On Tue, May 10, 2011 at 09:33:13AM -0400, R. David Murray wrote: > commit: > 11999: sync based on comparing mtimes, not mtime to system clock > NEWS: > Issue 11999: fixed sporadic sync failure mailbox.Maildir due to its > trying to detect mtime changes by comparing to the system clock >

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-10 Thread R. David Murray
On Tue, 10 May 2011 22:29:58 +1000, Nick Coghlan wrote: > On Tue, May 10, 2011 at 5:36 AM, Eric Smith wrote: > > Thanks indeed for bringing this up, Terry. It's been on my to-do list > > for a while. I think it comes from just copying the title of a bug > > report. The bug is "X does Y", and that

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-10 Thread Nick Coghlan
On Tue, May 10, 2011 at 5:36 AM, Eric Smith wrote: > Thanks indeed for bringing this up, Terry. It's been on my to-do list > for a while. I think it comes from just copying the title of a bug > report. The bug is "X does Y", and that's what's used in the fix. I believe I've actually seen it in NE

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-09 Thread Terry Reedy
On 5/9/2011 4:05 PM, Guido van Rossum wrote: On Mon, May 9, 2011 at 12:36 PM, Eric Smith wrote: On 05/09/2011 03:17 PM, Guido van Rossum wrote: While my own preference is "make X properly raise an exception" I'm happy with any of the alternatives proposed here, and grateful to Terry for call

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-09 Thread Guido van Rossum
On Mon, May 9, 2011 at 12:36 PM, Eric Smith wrote: > On 05/09/2011 03:17 PM, Guido van Rossum wrote: >> On Mon, May 9, 2011 at 11:36 AM, Ned Batchelder >> wrote: >>> On 5/9/2011 1:24 PM, Terry Reedy wrote: A commit (push) partition time and behavior into before and after (with a s

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-09 Thread Eric Smith
On 05/09/2011 03:17 PM, Guido van Rossum wrote: > On Mon, May 9, 2011 at 11:36 AM, Ned Batchelder > wrote: >> On 5/9/2011 1:24 PM, Terry Reedy wrote: >>> >>> A commit (push) partition time and behavior into before and after (with a >>> short change period in between during which behavior is undef

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-09 Thread Guido van Rossum
On Mon, May 9, 2011 at 11:36 AM, Ned Batchelder wrote: > On 5/9/2011 1:24 PM, Terry Reedy wrote: >> >> A commit (push) partition time and behavior into before and after (with a >> short change period in between during which behavior is undefined). >> >> Some commit messages have the form 'x does y

Re: [Python-Dev] Commit messages: please avoid temporal ambiguity

2011-05-09 Thread Ned Batchelder
On 5/9/2011 1:24 PM, Terry Reedy wrote: A commit (push) partition time and behavior into before and after (with a short change period in between during which behavior is undefined). Some commit messages have the form 'x does y'. Does 'does' mean before or after? Sometimes that is clear. 'x cr