Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-18 Thread Georg Brandl
Neal Norwitz wrote: > I did something similar to what Andrew suggested. > > http://python.org/sf/1542451 > > Could everyone interested take a look and offer more test cases? > Note that this needs to be fixed in the compiler package too. Georg ___ P

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-18 Thread Neal Norwitz
I did something similar to what Andrew suggested. http://python.org/sf/1542451 Could everyone interested take a look and offer more test cases? n -- On 8/17/06, A.M. Kuchling <[EMAIL PROTECTED]> wrote: > On Fri, Aug 18, 2006 at 12:26:33AM +0200, Armin Rigo wrote: > > Without more inspection, I'd

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-17 Thread A.M. Kuchling
On Fri, Aug 18, 2006 at 12:26:33AM +0200, Armin Rigo wrote: > Without more inspection, I'd say that this looks like it won't do the > right thing about nested finally's, as in: I guess it'll have to loop back up through the block stack: for (j=i- 1; j>=0; j--) { switch (c->u->u_fblock[j].fb_ty

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-17 Thread Guido van Rossum
High-level remark: this seems to need more unit tests. Perhaps TDD (test-driven design) would be the best approach to obtaining a correct patch? --Guido On 8/17/06, Armin Rigo <[EMAIL PROTECTED]> wrote: > Hi Neal, > > On Wed, Aug 16, 2006 at 10:26:09PM -0700, Neal Norwitz wrote: > > @@ -2367,7 +2

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-17 Thread Armin Rigo
Hi Neal, On Wed, Aug 16, 2006 at 10:26:09PM -0700, Neal Norwitz wrote: > @@ -2367,7 +2374,9 @@ > compiler_use_next_block(c, end); > if (!compiler_push_fblock(c, FINALLY_END, end)) > return 0; > + c->c_in_finally = 1; > VISIT_SEQ(c, stmt, s->v.TryFinally.finalbod

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-16 Thread James Y Knight
On Aug 17, 2006, at 1:26 AM, Neal Norwitz wrote: > Thanks Dino. > > The attached patch should fix the problem. Once RC1 is cut, I'll > check this in unless someone beats me to it. Since the compiler > changed, I can't backport this. If someone wants to make a similar > fix for 2.4 go for it. Th

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-16 Thread Neal Norwitz
Thanks Dino. The attached patch should fix the problem. Once RC1 is cut, I'll check this in unless someone beats me to it. Since the compiler changed, I can't backport this. If someone wants to make a similar fix for 2.4 go for it. n -- On 8/16/06, Dino Viehland <[EMAIL PROTECTED]> wrote: W

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-16 Thread Dino Viehland
Carlson [mailto:[EMAIL PROTECTED] Sent: Wednesday, August 16, 2006 10:11 AM To: Dino Viehland; python-dev@python.org Subject: Re: [Python-Dev] 2.4 & 2.5 beta 3 crash Dino Viehland <[EMAIL PROTECTED]> wrote: > > We've been working on fixing some exception handling bugs in >

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-16 Thread Dino Viehland
Dino Viehland; python-dev@python.org Subject: Re: [Python-Dev] 2.4 & 2.5 beta 3 crash def test(): for abc in range(10): try: pass finally: try: pass except: pass test() does not raise a segmentation fault. On Wed, 16 Aug 2006, Josia

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-16 Thread Dennis Allison
def test(): for abc in range(10): try: pass finally: try: pass except: pass test() does not raise a segmentation fault. On Wed, 16 Aug 2006, Josiah Carlson wrote: > > Dino Viehland <[EMAIL PROTECTED]> wrote: > > > > We've been w

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-16 Thread Georg Brandl
Josiah Carlson wrote: > Dino Viehland <[EMAIL PROTECTED]> wrote: >> >> We've been working on fixing some exception handling bugs in >> IronPython where we differ from CPython. Along the way we ran into >> this issue which causes CPython to crash when the code below is run. >> It crashes on both 2

Re: [Python-Dev] 2.4 & 2.5 beta 3 crash

2006-08-16 Thread Josiah Carlson
Dino Viehland <[EMAIL PROTECTED]> wrote: > > We've been working on fixing some exception handling bugs in > IronPython where we differ from CPython. Along the way we ran into > this issue which causes CPython to crash when the code below is run. > It crashes on both 2.4 and 2.5 beta 3. The code