Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-08 Thread Gregory P. Smith
On Tue, Aug 08, 2006 at 08:26:08AM +0200, "Martin v. L?wis" wrote: > Gregory P. Smith schrieb: > > Widely deployed popular applications use python for both large scale > > hashing and ssl communications. > > Yet, nobody has worried about performance in all these years to notice > that the assemble

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-08 Thread Gregory P. Smith
I have supplied a patch that does everything needed to both make the windows build process build OpenSSL with x86 assembly optimizations on Win32 and to build the _hashlib.pyd module. It works for me. The only thing the patch doesn't do is add _hashlib.pyd to the .msi windows installer because I

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-07 Thread Martin v. Löwis
Gregory P. Smith schrieb: > So is it worth my time doing this in a hurry for 2.5 or do other > people really just not care if python for windows uses a slow OpenSSL? As I said: I would accept patches. If you arrange for a separate _hashlib.pyd file, most of my concerns would go away. So please do

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-07 Thread Gregory P. Smith
On Tue, Aug 08, 2006 at 02:23:02AM +0200, "Martin v. L?wis" wrote: > Gregory P. Smith schrieb: > > Sigh. Half the reason I did the hashlib work was to get much faster > > optimized versions of the hash algorithms into python. I'll be > > disappointed if that doesn't happen. > > Sad as it sounds,

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-07 Thread Martin v. Löwis
Gregory P. Smith schrieb: > Sigh. Half the reason I did the hashlib work was to get much faster > optimized versions of the hash algorithms into python. I'll be > disappointed if that doesn't happen. Sad as it sounds, it appears you just did half of the work, then (omitting the Windows build pro

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-07 Thread Gregory P. Smith
On Tue, Aug 08, 2006 at 01:46:13AM +0200, "Martin v. L?wis" wrote: > Gregory P. Smith schrieb: > > hashlib's OpenSSL implementation on windows comes in the form of a > > 300k _hashlib.pyd library. > > What do you mean by "comes"? I can't find any _hashlib.vcproj file > inside the PCbuild directory

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-07 Thread Martin v. Löwis
Gregory P. Smith schrieb: > hashlib's OpenSSL implementation on windows comes in the form of a > 300k _hashlib.pyd library. What do you mean by "comes"? I can't find any _hashlib.vcproj file inside the PCbuild directory. >> I believe that the performance of the OpenSSL routines depends on >> the

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-07 Thread Gregory P. Smith
On Tue, Aug 08, 2006 at 03:25:46AM +1000, Anthony Baxter wrote: > I'm nervous about this change being made at this stage of the release > process. > It seems to me to have a chance of causing breakages - admittedly a small > chance, but one that's higher than I'd like. Sigh. Half the reason I

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-07 Thread Anthony Baxter
I'm nervous about this change being made at this stage of the release process. It seems to me to have a chance of causing breakages - admittedly a small chance, but one that's higher than I'd like. I'd also like to make sure that the PCBuild8 directory is updated at the same time - with the rec

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-07 Thread Gregory P. Smith
On Mon, Aug 07, 2006 at 03:16:22PM +0200, "Martin v. L?wis" wrote: > Gregory P. Smith schrieb: > > Whoever knows how the windows build process works and controls the > > python 2.5 windows release builds could you please make sure the > > hashlib module gets built + linked with OpenSSL rather than

Re: [Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-07 Thread Martin v. Löwis
Gregory P. Smith schrieb: > Whoever knows how the windows build process works and controls the > python 2.5 windows release builds could you please make sure the > hashlib module gets built + linked with OpenSSL rather than falling > back to its much slower builtin implementations. If the project

[Python-Dev] windows 2.5 build: use OpenSSL for hashlib [bug 1535502]

2006-08-06 Thread Gregory P. Smith
Whoever knows how the windows build process works and controls the python 2.5 windows release builds could you please make sure the hashlib module gets built + linked with OpenSSL rather than falling back to its much slower builtin implementations. http://sourceforge.net/tracker/index.php?func=d