Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-29 Thread Brett Cannon
On 5/28/07, "Martin v. Löwis" <[EMAIL PROTECTED]> wrote: Brett Cannon schrieb: > Unfortunately the pre-commit hook > does not specify what line a change was made on so I have no clue where > it is failing (maybe this should be added?). It creates a reindent.Reindenter on the new contents, then

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-29 Thread Georg Brandl
Martin v. Löwis schrieb: >> As I said before, you don't really need that when you can (and should!) just >> run >> reindent.py over the source file yourself, not care about any diffs and just >> resubmit. > > Right. So I withdraw my offer to do anything about the hook. I think printing something

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-29 Thread Martin v. Löwis
> As I said before, you don't really need that when you can (and should!) just > run > reindent.py over the source file yourself, not care about any diffs and just > resubmit. Right. So I withdraw my offer to do anything about the hook. Regards, Martin ___

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-29 Thread Georg Brandl
Scott Dial schrieb: > Martin v. Löwis wrote: >> Brett Cannon schrieb: >>> Unfortunately the pre-commit hook >>> does not specify what line a change was made on so I have no clue where >>> it is failing (maybe this should be added?). >> >> It creates a reindent.Reindenter on the new contents, then

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-29 Thread Scott Dial
Martin v. Löwis wrote: > Brett Cannon schrieb: >> Unfortunately the pre-commit hook >> does not specify what line a change was made on so I have no clue where >> it is failing (maybe this should be added?). > > It creates a reindent.Reindenter on the new contents, then invokes > .run() on it, and

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-28 Thread Martin v. Löwis
Brett Cannon schrieb: > Unfortunately the pre-commit hook > does not specify what line a change was made on so I have no clue where > it is failing (maybe this should be added?). It creates a reindent.Reindenter on the new contents, then invokes .run() on it, and complains if that returns true. If

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-26 Thread Brett Cannon
On 5/26/07, Neal Norwitz <[EMAIL PROTECTED]> wrote: On 5/26/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > > > On 5/25/07, Georg Brandl <[EMAIL PROTECTED]> wrote: > > Neal Norwitz schrieb: > > > On 5/25/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > > >> In my bcannon-objcap branch I am trying to

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-26 Thread Neal Norwitz
On 5/26/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > > > On 5/25/07, Georg Brandl <[EMAIL PROTECTED]> wrote: > > Neal Norwitz schrieb: > > > On 5/25/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > > >> In my bcannon-objcap branch I am trying to check in a change that > involves a > > >> soft symlink

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-26 Thread Brett Cannon
On 5/25/07, Georg Brandl <[EMAIL PROTECTED]> wrote: Neal Norwitz schrieb: > On 5/25/07, Brett Cannon <[EMAIL PROTECTED]> wrote: >> In my bcannon-objcap branch I am trying to check in a change that involves a >> soft symlink from Lib/controlled_importlib.py to >> ../importlib/controlled_importlib

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-26 Thread Brett Cannon
On 5/25/07, Neal Norwitz <[EMAIL PROTECTED]> wrote: On 5/25/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > In my bcannon-objcap branch I am trying to check in a change that involves a > soft symlink from Lib/controlled_importlib.py to > ../importlib/controlled_importlib.py through ``ln -s > ../co

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-25 Thread Georg Brandl
Neal Norwitz schrieb: > On 5/25/07, Brett Cannon <[EMAIL PROTECTED]> wrote: >> In my bcannon-objcap branch I am trying to check in a change that involves a >> soft symlink from Lib/controlled_importlib.py to >> ../importlib/controlled_importlib.py through ``ln -s >> ../controlled_importlib.py contr

Re: [Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-25 Thread Neal Norwitz
On 5/25/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > In my bcannon-objcap branch I am trying to check in a change that involves a > soft symlink from Lib/controlled_importlib.py to > ../importlib/controlled_importlib.py through ``ln -s > ../controlled_importlib.py controlled_importlib.py`` while i

[Python-Dev] whitespace normalization pre-commit hook is giving me grief

2007-05-25 Thread Brett Cannon
In my bcannon-objcap branch I am trying to check in a change that involves a soft symlink from Lib/controlled_importlib.py to ../importlib/controlled_importlib.py through ``ln -s ../controlled_importlib.py controlled_importlib.py`` while in the Lib directory. I have done this before in this branc