Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-23 Thread Brian Curtin
On Mon, Jul 23, 2012 at 11:24 AM, Andrew Svetlov wrote: > I thought my proposition is minor change, but if it's too late for 3.3 > — I'm ok. Very simply, the first beta is when feature freeze goes into effect. This is a really common policy that has been in effect for a long time in CPython and m

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-23 Thread Andrew Svetlov
I thought my proposition is minor change, but if it's too late for 3.3 — I'm ok. On Sun, Jul 22, 2012 at 8:54 PM, Antoine Pitrou wrote: > On Sun, 22 Jul 2012 20:39:15 +0300 > Andrew Svetlov wrote: >> Ok. >> Sorry for my mistake — there are really no commits for >> http://bugs.python.org/issue154

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-22 Thread Antoine Pitrou
On Sun, 22 Jul 2012 20:39:15 +0300 Andrew Svetlov wrote: > Ok. > Sorry for my mistake — there are really no commits for > http://bugs.python.org/issue15417 > It's look important for me — but you are release manager. > If you consider the patch as potentially dangerous — I have to agree with you. >

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-22 Thread Andrew Svetlov
Ok. Sorry for my mistake — there are really no commits for http://bugs.python.org/issue15417 It's look important for me — but you are release manager. If you consider the patch as potentially dangerous — I have to agree with you. You are the master :) On Sun, Jul 22, 2012 at 7:50 PM, Georg Brandl

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-22 Thread Georg Brandl
On 07/22/2012 06:10 PM, Andrew Svetlov wrote: > Georg, sorry, I've committed it before you answered. After you wrote that you'd wait three days... anyway, I can't find the commit in the repository, so that's fine. > If you want, I will revert it back. > But, please, describe me why those scripts

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-22 Thread Andrew Svetlov
Georg, sorry, I've committed it before you answered. If you want, I will revert it back. But, please, describe me why those scripts are to late for 3.3? I strongly checked correctness of both activation script for fish and csh/tsch shells. Works fine. It's not *new feature*, it is just extending

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-22 Thread Georg Brandl
These are new features, please do not commit before 3.3 is released. Georg On 07/22/2012 02:12 AM, Andrew Svetlov wrote: > I created http://bugs.python.org/issue15417 with required activation scripts. > If there are no objections I like to commit it after, say, three days. > > On Thu, Jul 19, 20

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-21 Thread Andrew Svetlov
I created http://bugs.python.org/issue15417 with required activation scripts. If there are no objections I like to commit it after, say, three days. On Thu, Jul 19, 2012 at 7:31 PM, Carl Meyer wrote: > On 07/19/2012 10:26 AM, Andrew Svetlov wrote: >> virtualenv has virtualenv.csh and virtualenv.f

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-19 Thread Carl Meyer
On 07/19/2012 10:26 AM, Andrew Svetlov wrote: > virtualenv has virtualenv.csh and virtualenv.fish files. > Is there any reason for restricting venv to bash/zsh only? No. As far as I'm concerned, a patch to port the virtualenv csh and fish activate scripts to pyvenv would be welcome (though I can't

[Python-Dev] venv scripts for fish and csh shells

2012-07-19 Thread Andrew Svetlov
virtualenv has virtualenv.csh and virtualenv.fish files. Is there any reason for restricting venv to bash/zsh only? -- Thanks, Andrew Svetlov ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscrib