Re: [Python-Dev] signal.alarm(3) in trunk test_socketserver.py

2008-03-04 Thread Trent Nelson
> Yep, the alarm is only there to prevent what would be deadlocks from > running forever. Sorry for breaking !unix. Your patch looks fine to > me. Do you want to submit it or shall I? I'm not a committer, so it's all yours. Thanks for the quick turnaround! Trent.

Re: [Python-Dev] signal.alarm(3) in trunk test_socketserver.py

2008-03-04 Thread Jeffrey Yasskin
On Tue, Mar 4, 2008 at 7:25 PM, Trent Nelson <[EMAIL PROTECTED]> wrote: > > r61099 added the following to trunk/Lib/test/test_socketserver.py: > > > > if __name__ == "__main__": > > test_main() > > + signal.alarm(3) # Shutdown shouldn't take more than 3 seconds. > > > > Actually,

Re: [Python-Dev] signal.alarm(3) in trunk test_socketserver.py

2008-03-04 Thread Trent Nelson
> r61099 added the following to trunk/Lib/test/test_socketserver.py: > > if __name__ == "__main__": > test_main() > + signal.alarm(3) # Shutdown shouldn't take more than 3 seconds. > Actually, signal.alarm() was introduced all over the place in that revision. I understand the intent

[Python-Dev] signal.alarm(3) in trunk test_socketserver.py

2008-03-04 Thread Trent Nelson
r61099 added the following to trunk/Lib/test/test_socketserver.py: if __name__ == "__main__": test_main() + signal.alarm(3) # Shutdown shouldn't take more than 3 seconds. which breaks platforms that don't have signal.alarm, like, say, !unix ;-) Trent. -- http://www.onr