Re: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Gregory P. Smith
> As I mentioned earlier I'd like to get patch 1446489 (support for > zip64 extensions in the zipfile module) in python 2.5. The patch > should be perfectly safe, it comes with unittests and a documentation > update. I'm also using this version of zipfile in (closed-source) > projects to ha

Re: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Ronald Oussoren
On 13-jun-2006, at 15:08, Aahz wrote: On Tue, Jun 13, 2006, Ronald Oussoren wrote: There are two backward incompatbile changes, both minor. First of all ZipInfo will lose the file_offset attribute because calculating it when opening a zipfile is very expensive (it basically requires a full sc

Re: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Aahz
On Tue, Jun 13, 2006, Ronald Oussoren wrote: > > There are two backward incompatbile changes, both minor. First of all > ZipInfo will lose the file_offset attribute because calculating it > when opening a zipfile is very expensive (it basically requires a > full scan of the zipfile). This sh

[Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Ronald Oussoren
Hi, As I mentioned earlier I'd like to get patch 1446489 (support for zip64 extensions in the zipfile module) in python 2.5. The patch should be perfectly safe, it comes with unittests and a documentation update. I'm also using this version of zipfile in (closed-source) projects to handle