Re: [Python-Dev] making the import machinery explicit

2012-04-17 Thread Terry Reedy
On 4/17/2012 2:01 PM, Brett Cannon wrote: Isn't it clearer to say ``sys.path_importer_cache[path] is None`` than ``isinstance(sys.path_importer_cache[path], imp.NullImporter)``? Yes. Great work. Thanks for helping with the Idle breakage. -- Terry Jan Reedy

Re: [Python-Dev] making the import machinery explicit

2012-04-17 Thread Brett Cannon
On Tue, Apr 17, 2012 at 13:45, Philip Jenvey wrote: > > On Apr 14, 2012, at 1:03 PM, Brett Cannon wrote: > > > And lastly, sticking None in sys.path_importer_cache would no longer > mean "do the implicit thing" and instead would mean the same as > NullImporter does now (which also means import ca

Re: [Python-Dev] making the import machinery explicit

2012-04-17 Thread Philip Jenvey
On Apr 14, 2012, at 1:03 PM, Brett Cannon wrote: > And lastly, sticking None in sys.path_importer_cache would no longer mean "do > the implicit thing" and instead would mean the same as NullImporter does now > (which also means import can put None into sys.path_importer_cache instead of > Null

Re: [Python-Dev] making the import machinery explicit

2012-04-17 Thread Brett Cannon
The only people to bring up worries about this thread were Eric and Nick and they both seem fine with making stuff explicit and changing the meaning of None in sys.path_importer_cache, so I have created http://bugs.python.org/issue14605 and will plan on implementing the ideas for it before Python 3

Re: [Python-Dev] making the import machinery explicit

2012-04-15 Thread Brett Cannon
On Sun, Apr 15, 2012 at 22:03, Nick Coghlan wrote: > On Mon, Apr 16, 2012 at 2:31 AM, Brett Cannon wrote: > > What about sys.path_importer_cache: all of it or just NullImporter/None > > entries (or should that be a boolean to this function)? And shouldn't it > be > > called reset_import() with t

Re: [Python-Dev] making the import machinery explicit

2012-04-15 Thread Nick Coghlan
On Mon, Apr 16, 2012 at 2:31 AM, Brett Cannon wrote: > What about sys.path_importer_cache: all of it or just NullImporter/None > entries (or should that be a boolean to this function)? And shouldn't it be > called reset_import() with the level of changes you are proposing the > function make? Hmm

Re: [Python-Dev] making the import machinery explicit

2012-04-15 Thread Brett Cannon
On Sun, Apr 15, 2012 at 07:26, Nick Coghlan wrote: > Hooray for finally having this to the point where it has been pushed to > trunk :) > > On Sun, Apr 15, 2012 at 8:16 AM, Brett Cannon wrote: > > Once again, it's just code that needs updating to run on Python 3.3 so I > > don't view it as a con

Re: [Python-Dev] making the import machinery explicit

2012-04-15 Thread Nick Coghlan
Hooray for finally having this to the point where it has been pushed to trunk :) On Sun, Apr 15, 2012 at 8:16 AM, Brett Cannon wrote: > Once again, it's just code that needs updating to run on Python 3.3 so I > don't view it as a concern. Going from list.append() to list.insert() (even > if its `

Re: [Python-Dev] making the import machinery explicit

2012-04-14 Thread Matt Joiner
+1! Thanks for pushing this. On Apr 15, 2012 4:04 AM, "Brett Cannon" wrote: > To start off, what I am about to propose was brought up at the PyCon > language summit and the whole room agreed with what I want to do here, so I > honestly don't expect much of an argument (famous last words). > > In

Re: [Python-Dev] making the import machinery explicit

2012-04-14 Thread Eric Snow
On Sat, Apr 14, 2012 at 4:16 PM, Brett Cannon wrote: > Once again, it's just code that needs updating to run on Python 3.3 so I > don't view it as a concern. Going from list.append() to list.insert() (even > if its ``list.insert(hook, len(list)-2)``) is not exactly difficult. I'm fine with that.

Re: [Python-Dev] making the import machinery explicit

2012-04-14 Thread Brett Cannon
On Sat, Apr 14, 2012 at 17:12, Eric Snow wrote: > On Sat, Apr 14, 2012 at 2:03 PM, Brett Cannon wrote: > > To start off, what I am about to propose was brought up at the PyCon > > language summit and the whole room agreed with what I want to do here, > so I > > honestly don't expect much of an ar

Re: [Python-Dev] making the import machinery explicit

2012-04-14 Thread Paul Moore
On 14 April 2012 21:03, Brett Cannon wrote: > So what I propose to do is stop having import have any kind of implicit > machinery. This means sys.meta_path gets a path finder that does the heavy > lifting for import and sys.path_hooks gets a hook which provides a default > finder. +1 to your prop

Re: [Python-Dev] making the import machinery explicit

2012-04-14 Thread Eric Snow
On Sat, Apr 14, 2012 at 2:03 PM, Brett Cannon wrote: > To start off, what I am about to propose was brought up at the PyCon > language summit and the whole room agreed with what I want to do here, so I > honestly don't expect much of an argument (famous last words). > > In the "ancient" import.c d

[Python-Dev] making the import machinery explicit

2012-04-14 Thread Brett Cannon
To start off, what I am about to propose was brought up at the PyCon language summit and the whole room agreed with what I want to do here, so I honestly don't expect much of an argument (famous last words). In the "ancient" import.c days, a lot of import's stuff was hidden deep in the C code and