Re: [Python-Dev] datetime.fromisocalendar

2019-04-29 Thread Ivan Pozdeev via Python-Dev
On 29.04.2019 16:30, Victor Stinner wrote: I reviewed and merged Paul's PR. I concur with Guido, the new constructor perfectly makes sense and is useful. About the implementation: date and time are crazy beasts. Extract of the code: if not 0 < week < 53: out_of_range = Tru

Re: [Python-Dev] datetime.fromisocalendar

2019-04-29 Thread Victor Stinner
I reviewed and merged Paul's PR. I concur with Guido, the new constructor perfectly makes sense and is useful. About the implementation: date and time are crazy beasts. Extract of the code: if not 0 < week < 53: out_of_range = True if week == 53: #

Re: [Python-Dev] datetime.fromisocalendar

2019-04-27 Thread Guido van Rossum
I think it’s a good idea. On Sat, Apr 27, 2019 at 11:43 AM Paul Ganssle wrote: > Greetings, > > Some time ago, I proposed adding a `.fromisocalendar` alternate > constructor to `datetime` (bpo-36004 ), > with a corresponding implementation (PR #11888 >

[Python-Dev] datetime.fromisocalendar

2019-04-27 Thread Paul Ganssle
Greetings, Some time ago, I proposed adding a `.fromisocalendar` alternate constructor to `datetime` (bpo-36004 ), with a corresponding implementation (PR #11888 ). I advertised it on datetime-SIG some time ago but h