Re: [Python-Dev] cpython: Implement PEP 380 - 'yield from' (closes #11682)

2012-01-14 Thread Nick Coghlan
On Jan 14, 2012 5:56 PM, "Georg Brandl" wrote: > > On 01/14/2012 07:53 AM, Nick Coghlan wrote: > > I agree, but it's one of the challenges of a long-lived branch like > > the PEP 380 one (I believe some of these cosmetic changes started life > > in Greg's original patch and separating them out wo

Re: [Python-Dev] cpython: Implement PEP 380 - 'yield from' (closes #11682)

2012-01-13 Thread Georg Brandl
On 01/14/2012 07:53 AM, Nick Coghlan wrote: >>> +PyAPI_FUNC(int) PyGen_FetchStopIterationValue(PyObject **); >> >> Does this API need to be public? If yes, it needs to be documented. > > Hmm, good point - that one needs a bit of thought, so I've put it on > the tracker: http://bugs.python.org/iss

Re: [Python-Dev] cpython: Implement PEP 380 - 'yield from' (closes #11682)

2012-01-13 Thread Nick Coghlan
On Sat, Jan 14, 2012 at 1:17 AM, Georg Brandl wrote: > On 01/13/2012 12:43 PM, nick.coghlan wrote: >> diff --git a/Doc/reference/expressions.rst b/Doc/reference/expressions.rst > > There should probably be a "versionadded" somewhere on this page. Good catch, I added versionchanged notes to this p

Re: [Python-Dev] cpython: Implement PEP 380 - 'yield from' (closes #11682)

2012-01-13 Thread Georg Brandl
Caution, long review ahead. On 01/13/2012 12:43 PM, nick.coghlan wrote: > http://hg.python.org/cpython/rev/d64ac9ab4cd0 > changeset: 74356:d64ac9ab4cd0 > user:Nick Coghlan > date:Fri Jan 13 21:43:40 2012 +1000 > summary: > Implement PEP 380 - 'yield from' (closes #11682) > dif