Re: [Python-Dev] cpython: Closes issue 17467. Add readline and readlines support to

2013-03-20 Thread Michael Foord
On 19 Mar 2013, at 23:09, "Gregory P. Smith" wrote: > > On Tue, Mar 19, 2013 at 9:44 PM, Michael Foord > wrote: >> >> On 19 Mar 2013, at 17:26, Antoine Pitrou wrote: >> >> > On Wed, 20 Mar 2013 01:22:58 +0100 (CET) >> > michael.foord wrote: >> >> http://hg.python.org/cpython/rev/684b756

Re: [Python-Dev] cpython: Closes issue 17467. Add readline and readlines support to

2013-03-20 Thread Michael Foord
On 20 Mar 2013, at 01:03, Antoine Pitrou wrote: > On Wed, 20 Mar 2013 00:50:27 -0700 > Michael Foord wrote: >> >> If you want to add support for additional functionality feel free to propose >> a patch. > > This isn't about additional functionality, this is about > correctness. You don't wa

Re: [Python-Dev] cpython: Closes issue 17467. Add readline and readlines support to

2013-03-20 Thread Antoine Pitrou
On Wed, 20 Mar 2013 00:50:27 -0700 Michael Foord wrote: > > If you want to add support for additional functionality feel free to propose > a patch. This isn't about additional functionality, this is about correctness. You don't want to write multiple, slightly different, implementations of read

Re: [Python-Dev] cpython: Closes issue 17467. Add readline and readlines support to

2013-03-20 Thread Michael Foord
On 20 Mar 2013, at 00:09, Antoine Pitrou wrote: > On Tue, 19 Mar 2013 21:44:15 -0700 > Michael Foord wrote: >> >> mock_open makes it easy to put a StringIO in place if that's what you want. >> It's just a simple helper function for providing some known data *along with >> the Mock api* to mak

Re: [Python-Dev] cpython: Closes issue 17467. Add readline and readlines support to

2013-03-20 Thread Antoine Pitrou
On Tue, 19 Mar 2013 21:44:15 -0700 Michael Foord wrote: > > mock_open makes it easy to put a StringIO in place if that's what you want. > It's just a simple helper function for providing some known data *along with > the Mock api* to make asserts that it was used correctly. It isn't presenting

Re: [Python-Dev] cpython: Closes issue 17467. Add readline and readlines support to

2013-03-19 Thread Gregory P. Smith
On Tue, Mar 19, 2013 at 9:44 PM, Michael Foord wrote: > > On 19 Mar 2013, at 17:26, Antoine Pitrou wrote: > > > On Wed, 20 Mar 2013 01:22:58 +0100 (CET) > > michael.foord wrote: > >> http://hg.python.org/cpython/rev/684b75600fa9 > >> changeset: 82811:684b75600fa9 > >> user:Michael Foor

Re: [Python-Dev] cpython: Closes issue 17467. Add readline and readlines support to

2013-03-19 Thread Michael Foord
On 19 Mar 2013, at 17:26, Antoine Pitrou wrote: > On Wed, 20 Mar 2013 01:22:58 +0100 (CET) > michael.foord wrote: >> http://hg.python.org/cpython/rev/684b75600fa9 >> changeset: 82811:684b75600fa9 >> user:Michael Foord >> date:Tue Mar 19 17:22:51 2013 -0700 >> summary: >> Clo

Re: [Python-Dev] cpython: Closes issue 17467. Add readline and readlines support to

2013-03-19 Thread Antoine Pitrou
On Wed, 20 Mar 2013 01:22:58 +0100 (CET) michael.foord wrote: > http://hg.python.org/cpython/rev/684b75600fa9 > changeset: 82811:684b75600fa9 > user:Michael Foord > date:Tue Mar 19 17:22:51 2013 -0700 > summary: > Closes issue 17467. Add readline and readlines support to > un