Re: [Python-Dev] We now have C code coverage!

` # noqa` works with linters --Hobson On Fri, Jun 29, 2018 at 6:25 AM, Brett Cannon wrote: > > > On Thu, Jun 28, 2018, 21:28 Terry Reedy, wrote: > >> On 6/24/2018 5:03 AM, Ammar Askar wrote: >> >> Is it possible, given that we are not paying for those reports, to >> >> customize the 'exclude

Re: [Python-Dev] We now have C code coverage!

Oh whoops, sorry about that. I haven't really used mailing lists before and so I assumed hitting reply in gmail would send it to python-dev, not just your personal email. Just so the config file locations are publicly documented, here's what I responded with: > For IDLE's test suite, I use a custo

Re: [Python-Dev] We now have C code coverage!

On 6/29/2018 9:25 AM, Brett Cannon wrote: On Thu, Jun 28, 2018, 21:28 Terry Reedy, > wrote: [question about our coverage bot] Everything is either covered by the Travis or codecov configuration files which are both checked into the cpython repo. (I'm on vacation or el

Re: [Python-Dev] We now have C code coverage!

On Thu, Jun 28, 2018, 21:28 Terry Reedy, wrote: > On 6/24/2018 5:03 AM, Ammar Askar wrote: > >> Is it possible, given that we are not paying for those reports, to > >> customize the 'exclude_lines' definitions? > > > > Do you want to exclude python code or C code? > > Python code. > > > For Pytho

Re: [Python-Dev] We now have C code coverage!

On 6/24/2018 5:03 AM, Ammar Askar wrote: Is it possible, given that we are not paying for those reports, to customize the 'exclude_lines' definitions? Do you want to exclude python code or C code? Python code. For Python code, coverage.py also has some comments you can put down to exclude l

Re: [Python-Dev] We now have C code coverage!

This is awesome, thank you Ammar! On 23 June 2018 at 06:21, Brett Cannon wrote: > Thanks to a PR from Ammar Askar we now run Python under lcov as part of > the code coverage build. And thanks to codecov.io automatically merging > code coverage reports we get a complete report of our coverage (th

Re: [Python-Dev] We now have C code coverage!

> Is it possible, given that we are not paying for those reports, to > customize the 'exclude_lines' definitions? Do you want to exclude python code or C code? For C code you can mark sections that exclude coverage in lcov with comments like "LCOV_EXCL_START" http://ltp.sourceforge.net/coverage/l

Re: [Python-Dev] We now have C code coverage!

On 6/23/2018 5:48 PM, Zachary Ware wrote: On Sat, Jun 23, 2018 at 2:20 PM, Terry Reedy wrote: Rechecking now, on Gentoo test_idle appears and passed on these 3.6 and 3.7 pages http://buildbot.python.org/all/#/builders/82/builds/414/steps/5/logs/stdio Neither Firefox nor Edge can find 'test_id

Re: [Python-Dev] We now have C code coverage!

On Sat, Jun 23, 2018 at 2:20 PM, Terry Reedy wrote: > Rechecking now, on Gentoo > > test_idle appears and passed on these 3.6 and 3.7 pages > http://buildbot.python.org/all/#/builders/82/builds/414/steps/5/logs/stdio > > Neither Firefox nor Edge can find 'test_idle' on these 3.x pages > http://bui

Re: [Python-Dev] We now have C code coverage!

On 6/23/2018 1:09 PM, Zachary Ware wrote: On Sat, Jun 23, 2018 at 11:31 AM, Terry Reedy wrote: I have suggested that, and before that, the same for buildbots. The reality is that tkinter, IDLE, or turtle could be disabled on *nix by regressions and the official testing would not notice. I'm

Re: [Python-Dev] We now have C code coverage!

On 23.06.2018 13:52, Paul Moore wrote: On 22 June 2018 at 23:21, Brett Cannon wrote: Thanks to a PR from Ammar Askar we now run Python under lcov as part of the code coverage build. And thanks to codecov.io automatically merging code coverage reports we get a complete report of our coverage (th

Re: [Python-Dev] We now have C code coverage!

On Sat, Jun 23, 2018 at 11:31 AM, Terry Reedy wrote: > I have suggested that, and before that, the same for buildbots. The reality > is that tkinter, IDLE, or turtle could be disabled on *nix by regressions > and the official testing would not notice. I'm looking into enabling the GUI tests on s

Re: [Python-Dev] We now have C code coverage!

On 6/22/2018 9:40 PM, Nathaniel Smith wrote: On Fri, Jun 22, 2018 at 6:16 PM, Terry Reedy wrote: I discovered the answer to 2. by shift-clicking on a text_x file to see their coverage report for the file. The colors actually do reflect the test lines executed. codecov.io excludes gui tests*,

Re: [Python-Dev] We now have C code coverage!

On 22 June 2018 at 23:21, Brett Cannon wrote: > Thanks to a PR from Ammar Askar we now run Python under lcov as part of the > code coverage build. And thanks to codecov.io automatically merging code > coverage reports we get a complete report of our coverage (the first results > of which can now b

Re: [Python-Dev] We now have C code coverage!

On Fri, Jun 22, 2018 at 6:16 PM, Terry Reedy wrote: > On 6/22/2018 8:43 PM, Terry Reedy wrote: >> >> On 6/22/2018 6:21 PM, Brett Cannon wrote: >>> >>> Thanks to a PR from Ammar Askar we now run Python under lcov as part of >>> the code coverage build. And thanks to codecov.io >

Re: [Python-Dev] We now have C code coverage!

On 6/22/2018 8:43 PM, Terry Reedy wrote: On 6/22/2018 6:21 PM, Brett Cannon wrote: Thanks to a PR from Ammar Askar we now run Python under lcov as part of the code coverage build. And thanks to codecov.io automatically merging code coverage reports we get a complete report

Re: [Python-Dev] We now have C code coverage!

On 6/22/2018 6:21 PM, Brett Cannon wrote: Thanks to a PR from Ammar Askar we now run Python under lcov as part of the code coverage build. And thanks to codecov.io automatically merging code coverage reports we get a complete report of our coverage (the first results of whic

[Python-Dev] We now have C code coverage!

Thanks to a PR from Ammar Askar we now run Python under lcov as part of the code coverage build. And thanks to codecov.io automatically merging code coverage reports we get a complete report of our coverage (the first results of which can now be seen at https://codecov.io/gh/python/cpython). And f