Re: [Python-Dev] Updating turtle.py

2014-06-02 Thread Terry Reedy
On 6/2/2014 3:12 AM, Nick Coghlan wrote: Even if we had unlimited reviewer resources (which we don't), mechanical code cleanups tend to fall under the "if it ain't broke, don't fix it" guideline. That then sets us up for a conflict between folks just getting started and trying to be helpful, and

Re: [Python-Dev] Updating turtle.py

2014-06-02 Thread Stephen J. Turnbull
Nick Coghlan writes: > Even if we had unlimited reviewer resources (which we don't), Raymond said "interns". We at least have a mentor. > There's a reason the desire to "throw it out and start again with a > clean slate" is a common trait amongst developers: You mean the Cascade of Attentio

Re: [Python-Dev] Updating turtle.py

2014-06-02 Thread Martin v. Löwis
Am 01.06.14 00:21, schrieb Terry Reedy: >>> Responding today, I cautioned that clean-up only patches, such as she >>> apparently would like to start with, are not in favor. >> >> I would not say that. I recall that I asked Gregor to make a number of >> style changes before he submitted the code, an

Re: [Python-Dev] Updating turtle.py

2014-06-02 Thread Nick Coghlan
On 2 June 2014 14:03, Stephen J. Turnbull wrote: > Raymond Hettinger writes: > > It's a bummer, but in mature code, almost every idea that occurs to > > a beginner is something that makes the code worse in some way -- > > that isn't always true but it happens often enough to be > > discouragin

Re: [Python-Dev] Updating turtle.py

2014-06-01 Thread Stephen J. Turnbull
Raymond Hettinger writes: > One thing I would not like to see happen is telling interns that > their time is being well spent by pep-8 checking code in the > standard library. It sends that wrong message about what > constitutes an actual contribution to the core. There are plenty > of usef

Re: [Python-Dev] Updating turtle.py

2014-06-01 Thread Raymond Hettinger
On May 30, 2014, at 8:32 PM, Terry Reedy wrote: > B. Lets assuming that turtle.py is, at least to some degree, fair game for > fixes and enhancements. PSF Python PyLadies (Jessica Keller, Lynn Root) are > participating in the 2014 GNOME Outreach Program for Women (OPW) > https://wiki.python.o

Re: [Python-Dev] Updating turtle.py

2014-05-31 Thread Terry Reedy
On 5/31/2014 2:05 PM, "Martin v. Löwis" wrote: Am 31.05.14 05:32, schrieb Terry Reedy: I have two areas of questions about updating turtle.py. First the module itself, then a turtle tracker issue versus code cleanup policies. A. Unlike most stdlib modules, turtle is copyrighted and licensed by

Re: [Python-Dev] Updating turtle.py

2014-05-31 Thread Martin v. Löwis
Am 31.05.14 10:09, schrieb Stephen J. Turnbull: > AFAICT Python policy is that someone should ask Gregor (a precedent is > the Fredrik Lundh/ElementTree case). AIUI, there's been a five-year > span since Gregor's been active, so I would think it's basically a > matter of courtesy. Most likely he'

Re: [Python-Dev] Updating turtle.py

2014-05-31 Thread Martin v. Löwis
Am 31.05.14 05:32, schrieb Terry Reedy: > I have two areas of questions about updating turtle.py. First the module > itself, then a turtle tracker issue versus code cleanup policies. > > A. Unlike most stdlib modules, turtle is copyrighted and licensed by an > individual. > ''' > # turtle.py: a Tk

[Python-Dev] Updating turtle.py

2014-05-31 Thread Stephen J. Turnbull
Terry Reedy writes: > As to point 2, the source has been altered a bit (by others) but it is > not marked as such. How should it be? I would suggest adding """ Based on turtle 1.1b for Python 3.1 (4.5.2009) by Gregor Lingl. This is a revised version including changes from the Python community

[Python-Dev] Updating turtle.py

2014-05-30 Thread Terry Reedy
I have two areas of questions about updating turtle.py. First the module itself, then a turtle tracker issue versus code cleanup policies. A. Unlike most stdlib modules, turtle is copyrighted and licensed by an individual. ''' # turtle.py: a Tkinter based turtle graphics module for Python # Ve