Re: [Python-Dev] Tweaking AST lineno and col_offset

2009-08-14 Thread Frank Wierzbicki
On Fri, Aug 14, 2009 at 5:57 PM, Brett Cannon wrote: > I like the improvement, but I disagree it should be considered for > backporting as it changes semantics for something that could be considered a > bug, but that feels like a stretch. Just thought I'd ask -- I'm perfectly ok with the change bei

Re: [Python-Dev] Tweaking AST lineno and col_offset

2009-08-14 Thread Brett Cannon
On Fri, Aug 14, 2009 at 09:16, Benjamin Peterson wrote: > 2009/8/14 Frank Wierzbicki : > > Hi all, > > > > Off and on I have been directly comparing Jython's AST with Python's > > AST and generally working towards making them as close to identical as > > possible. There are a couple of places whe

Re: [Python-Dev] Tweaking AST lineno and col_offset

2009-08-14 Thread Frank Wierzbicki
On Fri, Aug 14, 2009 at 3:41 PM, Frank Wierzbicki wrote: >> It's at the bottom of the test file. :) You can add a handwritten test >> above that, though. > Heh -- how did I miss that :) ? -- I'll resubmit the patch with tests. Resubmitted http://bugs.python.org/issue6704 with tests. -Frank ___

Re: [Python-Dev] Tweaking AST lineno and col_offset

2009-08-14 Thread Frank Wierzbicki
On Fri, Aug 14, 2009 at 3:11 PM, Benjamin Peterson wrote: > 2009/8/14 Frank Wierzbicki : >> On Fri, Aug 14, 2009 at 12:16 PM, Benjamin Peterson >> wrote: >> I have a local patch that changes the CPython col_offset to match Jython's, but before I submit a patch I thought I'd ask here if t

Re: [Python-Dev] Tweaking AST lineno and col_offset

2009-08-14 Thread Benjamin Peterson
2009/8/14 Frank Wierzbicki : > On Fri, Aug 14, 2009 at 12:16 PM, Benjamin Peterson > wrote: > >>> I have a local patch that changes the CPython col_offset to match >>> Jython's, but before I submit a patch I thought I'd ask here if there >>> is support for this sort of change and if I should conti

Re: [Python-Dev] Tweaking AST lineno and col_offset

2009-08-14 Thread Frank Wierzbicki
On Fri, Aug 14, 2009 at 12:16 PM, Benjamin Peterson wrote: >> I have a local patch that changes the CPython col_offset to match >> Jython's, but before I submit a patch I thought I'd ask here if there >> is support for this sort of change and if I should continue to find >> col_offset and lineno r

Re: [Python-Dev] Tweaking AST lineno and col_offset

2009-08-14 Thread Benjamin Peterson
2009/8/14 Frank Wierzbicki : > Hi all, > > Off and on I have been directly comparing Jython's AST with Python's > AST and generally working towards making them as close to identical as > possible.  There are a couple of places where I haven't "fixed" Jython > because it looks to me like Jython has

[Python-Dev] Tweaking AST lineno and col_offset

2009-08-14 Thread Frank Wierzbicki
Hi all, Off and on I have been directly comparing Jython's AST with Python's AST and generally working towards making them as close to identical as possible. There are a couple of places where I haven't "fixed" Jython because it looks to me like Jython has slightly better offsets. One example: