[Python-Dev] Re: Pull Request bpo-1812

2020-03-13 Thread Peter Donis
Ok, thanks for the update! ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives

[Python-Dev] Re: Pull Request bpo-1812

2020-03-13 Thread Zachary Ware
On Fri, Mar 13, 2020 at 9:36 AM Peter Donis wrote: > Is there any update on this? I have put the setup/teardown code in a context > manager as Zach recommended. The setup/teardown code covers everything that > could possibly be mutated by the test. It's probably not the most elegant way > to do

[Python-Dev] Re: Pull Request bpo-1812

2020-03-13 Thread Peter Donis
Is there any update on this? I have put the setup/teardown code in a context manager as Zach recommended. The setup/teardown code covers everything that could possibly be mutated by the test. It's probably not the most elegant way to do it, but all of the tests pass which indicates that it works

[Python-Dev] Re: Pull Request bpo-1812

2020-02-11 Thread Guido van Rossum
Thank you, thank you! Hopefully we can pull this one over the finish line, and it won't have to linger for another decade. :-) On Tue, Feb 11, 2020 at 8:42 PM Zachary Ware wrote: > On Tue, Feb 11, 2020 at 9:59 PM Guido van Rossum wrote: > > The Pull Request title is "Fix newline conversion when

[Python-Dev] Re: Pull Request bpo-1812

2020-02-11 Thread Zachary Ware
On Tue, Feb 11, 2020 at 9:59 PM Guido van Rossum wrote: > The Pull Request title is "Fix newline conversion when doctest.testfile loads > from a package whose loader has a get_data method", it looks relatively > straightforward and thorough. I've submitted a review; the actual code change is ve

[Python-Dev] Re: Pull Request bpo-1812

2020-02-11 Thread Guido van Rossum
For folks who wouldn't click on the links, the title of the issue is "doctest _load_testfile function -- newline handling seems incorrect", it was filed in 2008 and has many comments, plus diffs dating back to 2008. The Pull Request title is "Fix newline conversion when doctest.testfile loads from