[Python-Dev] Re: Providing fix for modulefinder.py regression on Windows

2020-04-15 Thread Brett Cannon
Barry Scott wrote: > > On 12 Apr 2020, at 21:49, Eric V. Smith e...@trueblade.com wrote: > > On 4/12/2020 4:08 PM, Barry Scott wrote: > > On 11 Apr > > 2020, at 16:28, Barry Scott > mailto:ba...@barrys-emacs.org> wrote: > > modulefinder.py does not open source files in "rb" which > > prevents comp

[Python-Dev] Re: Providing fix for modulefinder.py regression on Windows

2020-04-13 Thread Barry Scott
> On 12 Apr 2020, at 21:49, Eric V. Smith wrote: > > On 4/12/2020 4:08 PM, Barry Scott wrote: >> >>> On 11 Apr 2020, at 16:28, Barry Scott >> > wrote: >>> >>> modulefinder.py does not open source files in "rb" which >>> prevents compile() from applying the encod

[Python-Dev] Re: Providing fix for modulefinder.py regression on Windows

2020-04-12 Thread Victor Stinner
Barry Scott created https://bugs.python.org/issue40260 and https://github.com/python/cpython/pull/19488. Victor Le dim. 12 avr. 2020 à 22:11, Barry Scott a écrit : > > > On 11 Apr 2020, at 16:28, Barry Scott wrote: > > modulefinder.py does not open source files in "rb" which > prevents compile(

[Python-Dev] Re: Providing fix for modulefinder.py regression on Windows

2020-04-12 Thread Eric V. Smith
On 4/12/2020 4:08 PM, Barry Scott wrote: On 11 Apr 2020, at 16:28, Barry Scott > wrote: modulefinder.py does not open source files in "rb" which prevents compile() from applying the encoding rules. snip *I have created the bpo, the pr and have the checks passi

[Python-Dev] Re: Providing fix for modulefinder.py regression on Windows

2020-04-12 Thread Barry Scott
> On 11 Apr 2020, at 16:28, Barry Scott wrote: > > modulefinder.py does not open source files in "rb" which > prevents compile() from applying the encoding rules. > snip I have created the bpo, the pr and have the checks passing except that I need a NEWS.d entry to make bedevere/news happy. I

[Python-Dev] Re: Providing fix for modulefinder.py regression on Windows

2020-04-11 Thread Guido van Rossum
This seems like a noble pursuit. File a bug on bugs.python.org with the results you posted here, and submit a PR via GitHub ( github.com/python/cpython/). On Sat, Apr 11, 2020 at 9:09 AM Barry Scott wrote: > modulefinder.py does not open source files in "rb" which > prevents compile() from apply