[Python-Dev] Re: Merging PRs without CLA signed

My personal stance is if Microsoft Word could have come up with the change then a signed CLA is _probably_ not needed (IOW typos and grammatical errors). But honestly, I fall into the same camp as Mariatta and Pablo out of laziness and fear of being wrong. :) Laziness because there are plenty of

[Python-Dev] Re: Merging PRs without CLA signed

> I remember seeing it too. It may have originally been in the tracker > instructions, but should definitely be in the devguide now. >From looking through the devguide for every instance of "CLA" and "trivial", there seems to be just one section that mentions anything regarding the triviality of

[Python-Dev] Re: Merging PRs without CLA signed

don't remember if there's a magic comment that contributors can leave to get the bot to check again on its own, but the usual trigger for this is the submitter posting to say they've signed it, a core dev or triager seeing that and removing the "CLA Not Signed" label, There is no magic comment,

[Python-Dev] Re: Merging PRs without CLA signed

On Mon, 24 Feb 2020 at 14:51, Kyle Stanley wrote: > > > Note that if you open a PR, and _then_ sign the CLA, the label is not > > updated (at least, that's what I experienced before I did). So this list is > > likely inaccurate. > > I believe that I might have seen this happen a few times, but i

[Python-Dev] Re: Merging PRs without CLA signed

FWIW, I'm also one of the few core devs who won't merge a PR unless CLA is signed. Such PRs (and the backports) can't be automerged, creating manual work. I find the "triviality" is subjective. One line change in documentation is maybe trivial. One line change in the code is probably not as trivia

[Python-Dev] Re: Merging PRs without CLA signed

On 2/23/2020 11:44 PM, Guido van Rossum wrote: On Sun, Feb 23, 2020 at 8:11 PM Kyle Stanley > wrote: In a recently opened typo fixing PR [1], an issue came up regarding the lack of a signed CLA, where the author specifically mentioned they did not want to s

[Python-Dev] Re: Merging PRs without CLA signed

On 2/24/2020 10:32 AM, Chris Angelico wrote: On Tue, Feb 25, 2020 at 2:25 AM Antoine Pitrou wrote: I'd like to point out that the relevant perspective here isn't PSF policy as much as copyright law. Since Python is copyrighted in the US and the license specifies Virginia as the state of ju

[Python-Dev] Re: Merging PRs without CLA signed

On 24.02.2020 8:30, Kyle Stanley wrote: > (What is it with typos anyway? Why do people feel the need to invoke megabytes if not gigabytes of internet traffic to correct a word that every reader can easily correct in their mind?) Speaking from personal experience to some degree, my first PR was

[Python-Dev] Re: Merging PRs without CLA signed

There is, for better or worse, no bright line about what is copyrightable. Unfortunately, a lot of the standard is "how deep are the pockets of the opposing party?" If you are Oracle and you want to sue Google, code which any normal person world consider trivial becomes precious intellectual prope

[Python-Dev] Re: Merging PRs without CLA signed

On Tue, Feb 25, 2020 at 2:25 AM Antoine Pitrou wrote: > > On Mon, 24 Feb 2020 00:30:41 -0500 > Kyle Stanley wrote: > > > In that case I'm not sure the author ought to get credit for the PR. They > > can file a bug pointing out the typo and someone else can submit a fix. > > > > That sounds like a

[Python-Dev] Re: Merging PRs without CLA signed

On Mon, 24 Feb 2020 00:30:41 -0500 Kyle Stanley wrote: > > In that case I'm not sure the author ought to get credit for the PR. They > can file a bug pointing out the typo and someone else can submit a fix. > > That sounds like a reasonable solution to me; even for more substantial > issues (if

[Python-Dev] Re: Merging PRs without CLA signed

On 02/23/2020 08:44 PM, Guido van Rossum wrote: (What is it with typos anyway? Why do people feel the need to invoke megabytes if not gigabytes of internet traffic to correct a word that every reader can easily correct in their mind?) Typos are like skate boarding on fresh asphalt and then h

[Python-Dev] Re: Merging PRs without CLA signed

> In that case I'm not sure the author ought to get credit for the PR. They can file a bug pointing out the typo and someone else can submit a fix. That sounds like a reasonable solution to me; even for more substantial issues (if signing the CLA is a genuine issue). I think there are a fair numbe

[Python-Dev] Re: Merging PRs without CLA signed

> Note that if you open a PR, and _then_ sign the CLA, the label is not updated (at least, that's what I experienced before I did). So this list is likely inaccurate. I believe that I might have seen this happen a few times, but in the majority cases the label is updated from "CLA not signed" => "

[Python-Dev] Re: Merging PRs without CLA signed

On Sun, Feb 23, 2020 at 8:11 PM Kyle Stanley wrote: > In a recently opened typo fixing PR [1], an issue came up regarding the > lack of a signed CLA, where the author specifically mentioned they did not > want to sign it for privacy concerns. > In that case I'm not sure the author ought to get c

[Python-Dev] Re: Merging PRs without CLA signed

On 24.02.2020 7:07, Kyle Stanley wrote: For a full list of merged PRs to CPython with a "CLA not signed" label, see the following: https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Apr+state%3Amerged+label%3A%22CLA+not+signed%22 Note that if you open a PR, and _then_ sign the CLA