Re: [Python-Dev] Question over splitting unittest into a package

2010-01-07 Thread Olemis Lang
On Mon, Jan 4, 2010 at 9:24 AM, Olemis Lang wrote: > On Thu, Dec 31, 2009 at 10:30 AM, Martin (gzlist) > wrote: >> Thanks for the quick response. >> >> On 30/12/2009, Benjamin Peterson wrote: >> >> but maybe a >> discussion could start about a new, less hacky, way of doing the same >> > > I am

Re: [Python-Dev] Question over splitting unittest into a package

2010-01-04 Thread Olemis Lang
On Thu, Dec 31, 2009 at 10:30 AM, Martin (gzlist) wrote: > Thanks for the quick response. > > On 30/12/2009, Benjamin Peterson wrote: >> >> When I made that change, I didn't know that the __unittest "hack" was >> being used elsewhere outside of unittest, so I felt fine replacing it >> with anothe

Re: [Python-Dev] Question over splitting unittest into a package

2009-12-31 Thread Martin (gzlist)
Thanks for the quick response. On 30/12/2009, Benjamin Peterson wrote: > > When I made that change, I didn't know that the __unittest "hack" was > being used elsewhere outside of unittest, so I felt fine replacing it > with another. While I still consider it an implementation detail, I > would be

Re: [Python-Dev] Question over splitting unittest into a package

2009-12-30 Thread Nick Coghlan
Olemis Lang wrote: > PS: `assertRaises` context managers are great !!! BTW > ;o) The detailed comparison methods added for 2.7 are really nice too. It's great getting error messages that tell me what I broke rather than "you broke it!" :) Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com

Re: [Python-Dev] Question over splitting unittest into a package

2009-12-30 Thread Benjamin Peterson
2009/12/30 Olemis Lang : > Hmmm ... One of the issues I didn't notice ... > > IMO +1 for leaving it as it was before (i.e. __unittest) because : > >  - the double underscore should mean (CMIIW) that it's an implementation > detail >  - not few libs use that name already ;o) > > +0.5 for adding `__

Re: [Python-Dev] Question over splitting unittest into a package

2009-12-30 Thread Olemis Lang
On Wed, Dec 30, 2009 at 3:04 PM, Benjamin Peterson wrote: > 2009/12/30 Martin (gzlist) : >> Hi Benjamin, > > Hi! > >> In rev 74094 of Python, you split the unittest module up, +1 >> could you >> point me at any bug entries or discussion over this revision so I can >> catch up? > > This was mostl

Re: [Python-Dev] Question over splitting unittest into a package

2009-12-30 Thread Benjamin Peterson
2009/12/30 Martin (gzlist) : > Hi Benjamin, Hi! > > In rev 74094 of Python, you split the unittest module up, could you > point me at any bug entries or discussion over this revision so I can > catch up? This was mostly a discussion on IRC between Michael Foord and myself. > > As a side-effect