On Thu, Dec 18, 2008 at 12:27 PM, Guido van Rossum wrote:
> It sounds like the self-closing is an implementation detail, meant to
> make sure the socket is closed as early as possible (which I suppose
> is a good thing if there's a server waiting for the final ACK on the
> other side). Perhaps it
Jeremy Hylton wrote:
> but I worry that change the self-closing
> behavior too dramatically isn't appropriate for a bug fix. Will look
> some more at this tomorrow.
Reading through the code, it looks like you've already fixed bug 1348.
Thanks!
Bill
It sounds like the self-closing is an implementation detail, meant to
make sure the socket is closed as early as possible (which I suppose
is a good thing if there's a server waiting for the final ACK on the
other side). Perhaps it should not use close() but something slightly
lower level that affe
On Wed, Dec 17, 2008 at 1:05 PM, Guido van Rossum wrote:
> The inheritance from io.RawIOBase seems fine.
There is a small problem with the interaction between HTTPResponse and
RawIOBase, but I think the problem is more on the http side. You may
recall that the HTTP code has a habit of closing th
The inheritance from io.RawIOBase seems fine.
--Guido van Rossum (home page: http://www.python.org/~guido/)
On Mon, Dec 15, 2008 at 11:19 AM, Jeremy Hylton wrote:
> I have a patch that appears to fix this bug
> http://bugs.python.org/file12361/urllib-chunked.diff
> but I'm not sure about its i
I have a patch that appears to fix this bug
http://bugs.python.org/file12361/urllib-chunked.diff
but I'm not sure about its interaction with the io module and
RawIOBase. Is there a new IO expert who could take a look at it for
me?
Jeremy
On Sun, Dec 14, 2008 at 11:06 PM, Jeremy Hylton wrote:
>
This bug is pretty serious, because urllib will insert garbage into
the application-visible data for a chunked response. It simply
ignores the fact that it's reading a chunked response and includes the
chunked header data is payload data. The original bug was reported in
September, but no one not
