Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-11 Thread Antoine Pitrou
On Tue, 9 Sep 2014 08:20:52 +1000 Nick Coghlan wrote: > On 9 Sep 2014 04:00, "Barry Warsaw" wrote: > > > > > >This would need to be updated first, once it *did* take such an argument, > > >this would be accomplished by: > > > > > >context = ssl.create_default_context() > > >context.verify_mode =

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-11 Thread Antoine Pitrou
On Mon, 8 Sep 2014 10:44:51 -0700 Alex Gaynor wrote: > *Shifts uncomfortably* it looks like presently there's not a good way to > change anything about the SSL configuration for urllib.request.urlopen. It > does not take a `context` argument, as the http.client API does: > https://docs.python.org/

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-10 Thread Larry Hastings
On 09/08/2014 05:08 AM, Nick Coghlan wrote: On 8 September 2014 14:28, Ned Deily wrote: As I've already discussed with Larry, I think adding a week to the scheduled dates would be preferable. The original dates give pretty short notice and there are a number of open issues that would be good t

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Glenn Linderman
On 9/8/2014 8:41 PM, Stephen J. Turnbull wrote: > Why not provide _urlopen_with_scary_keyword_parameter as the > monkey-patch option? > > So after the (global to the module) monkeypatch, they would_still_ have > to add the keyword parameter. I understand the hardline position, though

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Stephen J. Turnbull
Glenn Linderman writes: > Well, this thread seems to be top-posted so... Not a good enough reason for me! > Why not provide _urlopen_with_scary_keyword_parameter as the > monkey-patch option? > > So after the (global to the module) monkeypatch, they would _still_ have > to add the k

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Guido van Rossum
Replacing urllib.urlopen(url) with urllib._unsafe_urlopen_without_secure_https(url) would be fine too (actual name to be picked by whoever writes the code) but I don't see that it offers much more of a barrier against abuse of this compatibility feature compared to a keyword argument. Requiring a

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Glenn Linderman
Well, this thread seems to be top-posted so... Why not provide _urlopen_with_scary_keyword_parameter as the monkey-patch option? So after the (global to the module) monkeypatch, they would _still_ have to add the keyword parameter. On 9/8/2014 4:31 PM, Guido van Rossum wrote: I still p

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Guido van Rossum
I still prefer having a parameter on urlopen (or thereabouts) -- it feels wrong to make it easier to change this globally than on a per-call basis, and if you don't understand monkey-patching, it's impossible to debug if you put the patch in the wrong place. For the poor soul who has a script with

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Donald Stufft
> On Sep 8, 2014, at 6:43 PM, Nick Coghlan wrote: > > > On 9 Sep 2014 08:30, "Donald Stufft" > wrote: > > > > If someone wants to do this, can’t they write their own 6 line function? > > Unfortunately not, as the domain knowledge required to know what those six > lin

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Nick Coghlan
On 9 Sep 2014 08:30, "Donald Stufft" wrote: > > If someone wants to do this, can’t they write their own 6 line function? Unfortunately not, as the domain knowledge required to know what those six lines should look like is significant. Keeping the old unsafe behaviour around with a more obviously

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Nick Coghlan
On 9 Sep 2014 08:20, "Nick Coghlan" wrote: > > > On 9 Sep 2014 04:00, "Barry Warsaw" wrote: > > > > > >This would need to be updated first, once it *did* take such an argument, > > >this would be accomplished by: > > > > > >context = ssl.create_default_context() > > >context.verify_mode = CERT_OP

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Donald Stufft
> On Sep 8, 2014, at 6:20 PM, Nick Coghlan wrote: > > > On 9 Sep 2014 04:00, "Barry Warsaw" > wrote: > > > > > >This would need to be updated first, once it *did* take such an argument, > > >this would be accomplished by: > > > > > >context = ssl.create_default_context

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Barry Warsaw
On Sep 09, 2014, at 08:20 AM, Nick Coghlan wrote: >We could actually make it an "official" hack: > >import urllib.request >urllib.request.urlopen = urllib.request._unverified_urlopen > >Or else the user can just change the code to call the unverified one >directly. > >All we'd have to do i

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Nick Coghlan
On 9 Sep 2014 04:00, "Barry Warsaw" wrote: > > > >This would need to be updated first, once it *did* take such an argument, > >this would be accomplished by: > > > >context = ssl.create_default_context() > >context.verify_mode = CERT_OPTIONACERT_NONE > >context.verify_hostname = False > >urllib.re

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Jim Baker
+1 for the suggested change to 2.7. Something I have put off in the work on SSL support in Jython 2.7 is what to do about the possibility of adding a large security hole to support standard Python behavior here with CERT_NONE. By default, we use the standard trust database and corresponding manage

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Barry Warsaw
On Sep 08, 2014, at 10:44 AM, Alex Gaynor wrote: >*Shifts uncomfortably* it looks like presently there's not a good way to >change anything about the SSL configuration for urllib.request.urlopen. It >does not take a `context` argument, as the http.client API does: >https://docs.python.org/3/librar

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Guido van Rossum
Well, get cracking then! :-) On Mon, Sep 8, 2014 at 10:44 AM, Alex Gaynor wrote: > *Shifts uncomfortably* it looks like presently there's not a good way to > change anything about the SSL configuration for urllib.request.urlopen. It > does not take a `context` argument, as the http.client API do

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Alex Gaynor
*Shifts uncomfortably* it looks like presently there's not a good way to change anything about the SSL configuration for urllib.request.urlopen. It does not take a `context` argument, as the http.client API does: https://docs.python.org/3/library/urllib.request.html#module-urllib.request and instea

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Guido van Rossum
I will pronounce for 3.4 once you point me to the documentation that explains how to disable cert validation for an example program that currently pulls down an https URL using urlopen. Without adding package dependencies. On Mon, Sep 8, 2014 at 10:25 AM, Alex Gaynor wrote: > Guido van Rossum p

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Alex Gaynor
Guido van Rossum python.org> writes: > > Would you be willing to officially pronounce on PEP-476 in the context of 3.4.x, so we can get it into the release, and then we can defer on officially approving it for 2.7.X until we figure out all the moving pieces? Cheers, Alex

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Guido van Rossum
On Mon, Sep 8, 2014 at 5:08 AM, Nick Coghlan wrote: > > It would also be good to get Guido's official verdict on PEP 476 (the > switch to validating HTTPS by default) in time for 3.4.2. Based on the > previous discussion, Alex updated the PEP to suggest "just fix it" for > all of 3.5, 3.4.x and 2

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-08 Thread Nick Coghlan
On 8 September 2014 14:28, Ned Deily wrote: > In article <540c521c.7070...@hastings.org>, > Larry Hastings wrote: >> Matthias asked me when I was going to release 3.4.2. I propose the >> following schedule: >> >> Tag 3.4.2rc1 Friday Sep 12 2014 >> Release 3.4.2rc1 Saturday Sep 13 2014 >

Re: [Python-Dev] Proposed schedule for 3.4.2

2014-09-07 Thread Ned Deily
In article <540c521c.7070...@hastings.org>, Larry Hastings wrote: > Matthias asked me when I was going to release 3.4.2. I propose the > following schedule: > > Tag 3.4.2rc1 Friday Sep 12 2014 > Release 3.4.2rc1 Saturday Sep 13 2014 > Tag 3.4.2 final Saturday Sep 27 2014 > Rele

[Python-Dev] Proposed schedule for 3.4.2

2014-09-07 Thread Larry Hastings
Matthias asked me when I was going to release 3.4.2. I propose the following schedule: Tag 3.4.2rc1 Friday Sep 12 2014 Release 3.4.2rc1 Saturday Sep 13 2014 Tag 3.4.2 final Saturday Sep 27 2014 Release 3.4.2 final Sunday Sep 28 2014 Normally I want to tag on Saturdays and releas