Brett C. wrote:
> OK, EXTRA_CFLAGS support has been checked into Makefile.pre.in and
> distutils.sysconfig . Martin, please double-check I tweaked sysconfig the way
> you wanted.
It is the way I wanted it, but it doesn't work. Just try and use it for
some extension modules to see for yourself, I
OK, EXTRA_CFLAGS support has been checked into Makefile.pre.in and
distutils.sysconfig . Martin, please double-check I tweaked sysconfig the way
you wanted. I also wasn't sure of compatibility for Distutils (first time
touching it); checked PEP 291 but Distutils wasn't listed. I went ahead and
u
Brett C. wrote:
>>You means sysconfig.py, right?
Right.
> No, I mean Python's setup.py; line 174.
Ah, ok.
> You mean Distutils' sysconfig, right? I can change that as well if you want.
Please do; otherwise, people might see strange effects.
Regards,
Martin
___
Brett C. wrote:
> Yep, you're right. I initially thought that the parentheses meant it was a
> Makefile-only variable, but it actually goes to the environment for those
> unknown values.
>
> Before I check it in, though, should setup.py be tweaked to use it as well? I
> say yes.
You means sysco
Martin v. LÃwis wrote:
> Brett C. wrote:
>
>>Yep, you're right. I initially thought that the parentheses meant it was a
>>Makefile-only variable, but it actually goes to the environment for those
>>unknown values.
>>
>>Before I check it in, though, should setup.py be tweaked to use it as well? I
Martin v. LÃwis wrote:
> Brett C. wrote:
>
>>Works for me. If no one objects I will check in the change for CFLAGS to make
>>it ``$(BASECFLAGS) $(OPT) "$EXTRA_CFLAGS"`` soon (is quoting it enough to make
>>sure that it isn't evaluated by configure but left as a string to be evaluated
>>by the she
Brett C. wrote:
> Works for me. If no one objects I will check in the change for CFLAGS to make
> it ``$(BASECFLAGS) $(OPT) "$EXTRA_CFLAGS"`` soon (is quoting it enough to make
> sure that it isn't evaluated by configure but left as a string to be evaluated
> by the shell when the Makefile is runn
Martin v. LÃwis wrote:
> Brett C. wrote:
>
>>Hmm. OK, that is an interesting idea. Would make rebuilding a lot easier if
>>it was just an environment variable that was part of the default OPT value;
>>``OPT="$BUILDFLAGS -g -Wall -Wstrict-prototyping".
>>
>>I say we go with that. What is a good
Brett C. wrote:
> Hmm. OK, that is an interesting idea. Would make rebuilding a lot easier if
> it was just an environment variable that was part of the default OPT value;
> ``OPT="$BUILDFLAGS -g -Wall -Wstrict-prototyping".
>
> I say we go with that. What is a good name, though? PY_OPT?
I th
Martin v. LÃwis wrote:
> Brett C. wrote:
>
>>The other option is to not make configure.in skip injecting arguments when a
>>pydebug build is done based on whether OPT is defined in the environment. So
>>configure.in:670 could change to ``OPT="$OPT -g -Wall -Wstrict-prototypes"``.
>
>
> That's a
Brett C. wrote:
> The other option is to not make configure.in skip injecting arguments when a
> pydebug build is done based on whether OPT is defined in the environment. So
> configure.in:670 could change to ``OPT="$OPT -g -Wall -Wstrict-prototypes"``.
That's a procedural question: do we want to
Martin v. LÃwis wrote:
> Brett C. wrote:
>
>>I am currently adding some code for a Py_COMPILER_DEBUG build for use on the
>>AST branch. I thought that OPT was the proper variable to put stuff like this
>>into for building (``-DPy_COMPILER_DEBUG``), but that erases ``-g -Wall
>>-Wstrict-prototypes
Brett C. wrote:
> I am currently adding some code for a Py_COMPILER_DEBUG build for use on the
> AST branch. I thought that OPT was the proper variable to put stuff like this
> into for building (``-DPy_COMPILER_DEBUG``), but that erases ``-g -Wall
> -Wstrict-prototypes``. Obviously I could just
I am currently adding some code for a Py_COMPILER_DEBUG build for use on the
AST branch. I thought that OPT was the proper variable to put stuff like this
into for building (``-DPy_COMPILER_DEBUG``), but that erases ``-g -Wall
-Wstrict-prototypes``. Obviously I could just tack all of that into my
14 matches
Mail list logo
