Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread Skip Montanaro
On Tue, Aug 25, 2015 at 11:17 AM, Brett Cannon wrote: > With a `make develop` target we also can make sure not only that > --with-pydebug is used but that the installation target is /tmp so that new > contributors don't accidentally install a debug build. You need to be careful there. In my env

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread Patrascu, Alecsandru
@python.org Subject: Re: [Python-Dev] Profile Guided Optimization active by-default PGO is unrelated to the particular CPU the profiling is done on. (It is conceivable that it'd make a small difference but I've never observed that in practice) On Tue, Aug 25, 2015, 9:28 AM Xavier Combelle wrote:

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread Gregory P. Smith
On Mon, Aug 24, 2015, 11:19 PM Nick Coghlan wrote: On 25 August 2015 at 05:52, Gregory P. Smith wrote: > What we tested and decided to use on our own builds after benchmarking at > work was to build with: > > make profile-opt PROFILE_TASK="-m test.regrtest -w -uall,-audio -x test_gdb > test_mult

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread Gregory P. Smith
PGO is unrelated to the particular CPU the profiling is done on. (It is conceivable that it'd make a small difference but I've never observed that in practice) On Tue, Aug 25, 2015, 9:28 AM Xavier Combelle wrote: Pardon me if I'm not in the right place to ask the following naive question. (say m

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread Xavier Combelle
Pardon me if I'm not in the right place to ask the following naive question. (say me if it's the case) Does Profile Guided Optimization performance improvements are specific to the chip where the built is done or the performance is better on a larger set of chips? _

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread Brett Cannon
On Tue, 25 Aug 2015 at 09:10 R. David Murray wrote: > On Tue, 25 Aug 2015 15:59:23 -, Brett Cannon wrote: > > On Mon, 24 Aug 2015 at 23:19 Nick Coghlan wrote: > > > > > On 25 August 2015 at 05:52, Gregory P. Smith wrote: > > > > What we tested and decided to use on our own builds after > b

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread R. David Murray
On Tue, 25 Aug 2015 15:59:23 -, Brett Cannon wrote: > On Mon, 24 Aug 2015 at 23:19 Nick Coghlan wrote: > > > On 25 August 2015 at 05:52, Gregory P. Smith wrote: > > > What we tested and decided to use on our own builds after benchmarking at > > > work was to build with: > > > > > > make pro

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread Brett Cannon
On Mon, 24 Aug 2015 at 23:19 Nick Coghlan wrote: > On 25 August 2015 at 05:52, Gregory P. Smith wrote: > > What we tested and decided to use on our own builds after benchmarking at > > work was to build with: > > > > make profile-opt PROFILE_TASK="-m test.regrtest -w -uall,-audio -x > test_gdb >

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread Maciej Fijalkowski
> > Interesting. So pypy (with it's profiling JIT) would be in a similar boat, > potentially. > PGO and what pypy does have pretty much nothing to do with each other. I'm not sure what do you mean by "similar boat" ___ Python-Dev mailing list Python-Dev

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-25 Thread Eric Snow
On Aug 24, 2015 3:51 PM, "Stewart, David C" wrote: > > (Sorry about the format here - I honestly just subscribed to Python-dev so > be gentle ...) :) > > > Date: Sat, 22 Aug 2015 11:25:59 -0600 > > From: Eric Snow > > >On Aug 22, 2015 9:02 AM, "Patrascu, Alecsandru" >intel.com

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-24 Thread Nick Coghlan
On 25 August 2015 at 05:52, Gregory P. Smith wrote: > What we tested and decided to use on our own builds after benchmarking at > work was to build with: > > make profile-opt PROFILE_TASK="-m test.regrtest -w -uall,-audio -x test_gdb > test_multiprocessing" > > In general if a test is unreliable o

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-24 Thread Stewart, David C
(Sorry about the format here - I honestly just subscribed to Python-dev so be gentle ...) > Date: Sat, 22 Aug 2015 11:25:59 -0600 > From: Eric Snow >On Aug 22, 2015 9:02 AM, "Patrascu, Alecsandru" intel.com > >wrote:[snip]> For instance, as sh

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-24 Thread Matthias Klose
The current pgo target just uses a very specific task to train for the feedback. For my Debian/Ubuntu builds I'm using the testsuite minus some problematic tests to train. Otoh I don't know if this is the best way to do it, however it gave better results at some time in the past. What I would like

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-24 Thread Gregory P. Smith
On Sat, Aug 22, 2015 at 9:27 AM Brett Cannon wrote: > On Sat, Aug 22, 2015, 09:17 Guido van Rossum wrote: > > How about we first add a new Makefile target that enables PGO, without > turning it on by default? Then later we can enable it by default. > > There already is one and has been for many

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-23 Thread Patrascu, Alecsandru
I removed the zip file and uploaded the patches individually. Alecsandru From: Brett Cannon [mailto:br...@python.org] Sent: Sunday, August 23, 2015 4:47 AM To: Patrascu, Alecsandru; python-dev@python.org Subject: Re: [Python-Dev] Profile Guided Optimization active by-default On Sat, 22 Aug

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Brett Cannon
Patrascu, Alecsandru; python-dev@python.org > Subject: Re: [Python-Dev] Profile Guided Optimization active by-default > > I just realized I didn't see anyone say it, but please upload the patches > to bugs.Python.org for easier tracking and reviewing. > > On Sat, Aug 22, 2015, 0

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Patrascu, Alecsandru
n-Dev] Profile Guided Optimization active by-default I just realized I didn't see anyone say it, but please upload the patches to bugs.Python.org for easier tracking and reviewing. On Sat, Aug 22, 2015, 08:01 Patrascu, Alecsandru wrote: Hi All, This is Alecsandru from Server Scripting

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Patrascu, Alecsandru
-bounces+alecsandru.patrascu=intel@python.org] On Behalf Of Stefan Behnel Sent: Saturday, August 22, 2015 8:25 PM To: python-dev@python.org Subject: Re: [Python-Dev] Profile Guided Optimization active by-default Guido van Rossum schrieb am 22.08.2015 um 18:55: > Regarding the training set

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Brett Cannon
I just realized I didn't see anyone say it, but please upload the patches to bugs.Python.org for easier tracking and reviewing. On Sat, Aug 22, 2015, 08:01 Patrascu, Alecsandru < alecsandru.patra...@intel.com> wrote: > Hi All, > > This is Alecsandru from Server Scripting Languages Optimization te

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Brett Cannon
rett Cannon [mailto:br...@python.org] Sent: Saturday, August 22, 2015 7:25 PM To: gu...@python.org; Patrascu, Alecsandru Cc: python-dev@python.org Subject: Re: [Python-Dev] Profile Guided Optimization active by-default On Sat, Aug 22, 2015, 09:17 Guido van Rossum wrote: How about we first add a

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Patrascu, Alecsandru
PM To: Patrascu, Alecsandru Cc: Python-Dev Subject: Re: [Python-Dev] Profile Guided Optimization active by-default On Aug 22, 2015 9:02 AM, "Patrascu, Alecsandru" wrote: [snip]  > For instance, as shown from attached sample performance results from the > Grand Unified Pytho

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Stefan Behnel
Stefan Behnel schrieb am 22.08.2015 um 19:25: > Guido van Rossum schrieb am 22.08.2015 um 18:55: >> Regarding the training set, I agree that regrtest sounds to be better than >> pybench. If we make this an opt-in change, we can experiment with different >> training sets easily. (Also, I haven't see

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Eric Snow
On Aug 22, 2015 9:02 AM, "Patrascu, Alecsandru" < alecsandru.patra...@intel.com> wrote: [snip] > For instance, as shown from attached sample performance results from the Grand Unified Python Benchmark, >20% speed up was observed. Are you referring to the tests in the benchmarks repo? [1] How does

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Stefan Behnel
Guido van Rossum schrieb am 22.08.2015 um 18:55: > Regarding the training set, I agree that regrtest sounds to be better than > pybench. If we make this an opt-in change, we can experiment with different > training sets easily. (Also, I haven't seen the patch yet, but I presume > it's easy to use a

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Patrascu, Alecsandru
half Of Guido van Rossum Sent: Saturday, August 22, 2015 7:15 PM To: Patrascu, Alecsandru Cc: python-dev@python.org Subject: Re: [Python-Dev] Profile Guided Optimization active by-default How about we first add a new Makefile target that enables PGO, without turning it on by default? Then later we can

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Patrascu, Alecsandru
n-Dev] Profile Guided Optimization active by-default On Sat, Aug 22, 2015, 09:17 Guido van Rossum wrote: How about we first add a new Makefile target that enables PGO, without turning it on by default? Then later we can enable it by default. I agree. Updating the Makefile so it's easier to

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Guido van Rossum
> > From: gvanros...@gmail.com [mailto:gvanros...@gmail.com] On Behalf Of > Guido van Rossum > Sent: Saturday, August 22, 2015 7:15 PM > To: Patrascu, Alecsandru > Cc: python-dev@python.org > Subject: Re: [Python-Dev] Profile Guided Optimization active by-default > > How abou

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Patrascu, Alecsandru
ru Cc: python-dev@python.org Subject: Re: [Python-Dev] Profile Guided Optimization active by-default How about we first add a new Makefile target that enables PGO, without turning it on by default? Then later we can enable it by default. Also, I have my doubts about regrtest. How sure are we th

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Brett Cannon
On Sat, Aug 22, 2015, 09:17 Guido van Rossum wrote: How about we first add a new Makefile target that enables PGO, without turning it on by default? Then later we can enable it by default. I agree. Updating the Makefile so it's easier to use PGO is great, but we should do a release with it as o

Re: [Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Guido van Rossum
How about we first add a new Makefile target that enables PGO, without turning it on by default? Then later we can enable it by default. Also, I have my doubts about regrtest. How sure are we that it represents a typical Python load? Tests are often using a different mix of operations than product

[Python-Dev] Profile Guided Optimization active by-default

2015-08-22 Thread Patrascu, Alecsandru
Hi All, This is Alecsandru from Server Scripting Languages Optimization team at Intel Corporation. I would like to submit a request to turn-on Profile Guided Optimization or PGO as the default build option for Python (both 2.7 and 3.6), given its performance benefits on a wide variety of workl